Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aL8id-00066p-JD for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Jan 2016 12:15:35 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aL8ic-0005jM-KQ for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Jan 2016 12:15:34 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aL8ic-0005id-4h for pgadmin-hackers@postgresql.org; Mon, 18 Jan 2016 12:15:34 +0000 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aL8iY-00014J-IP for pgadmin-hackers@postgresql.org; Mon, 18 Jan 2016 12:15:32 +0000 Received: by mail-wm0-x22b.google.com with SMTP id r129so48815959wmr.0 for ; Mon, 18 Jan 2016 04:15:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=vu+6+bUsx8X6RHb5bqPY/Mk/HLatWPNWwkhzio3rAUk=; b=vMYBE1afESGZKurSFKY550BNbsqCDpjFaovsnk7oCFOaVI1pXWJSiqsQSUWTVv58oJ stvJtgskjR7AXIFdzOlaipMHdZtmt/NvlWGxrn3SWsenQBN+cp9JpHA5ZhFt0tOAJCOK exJ4uqM9jDhaglKIC4znEZszgnfEWU9AQKHIs5cD9GMAYemk04AuTdrmFAorArEbm6x/ yBRBawzLOKmjWjBzh4hUo7Kj7yS/z0IxFIuR3jTtqhvce3yvyQ38gCB2y5phZb3RDUFa nz3VyOVi5QY+OxeBo1eodGZRcYo0Vo+kaxeV0MK+I5mowNofRYCRzaK9a66of93oaCia HdJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=vu+6+bUsx8X6RHb5bqPY/Mk/HLatWPNWwkhzio3rAUk=; b=nG6G/eBUOKUg5jt1lyxcDmbthnlHzwQFXcAgvnUv17e8SY0bwtNeYDs7T/n4MJ5mnZ pVdlgK3dg7Ikmmf+mPQwb7yUGA8J7AUug++tNxCVQoAuvfFRQe03qUk8eWWzK6qevxxr WBdtk/wpvdKdZ4UQZc4rKF/StVY+iJ4iO9j98fUQUNJvbJ/WeG3CAQrxa5AK8loqhGI5 Fqtf1+UkZQu3KfpO1FlqAWhS6SvSulyyyk68tY+8rLD3LnaayS/qJVUmhxg8T2rLcp0c pxd3E/g09Joj9rBMjB3n2O30dhNJlU3difIz2S90uo22PxR1gbZlzw1hGvhnzDx/bvfa 16zA== X-Gm-Message-State: AG10YOTLJbgld6jBCEi6z1VofKN2Ne2xYFQUU9srWEBwFYNdG8BHyVEa4tyQvf/EAa//Frm6fYTEkb6Tfvttexia X-Received: by 10.28.107.81 with SMTP id g78mr12283715wmc.16.1453119328965; Mon, 18 Jan 2016 04:15:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.15.66 with HTTP; Mon, 18 Jan 2016 04:14:59 -0800 (PST) In-Reply-To: References: From: Surinder Kumar Date: Mon, 18 Jan 2016 17:44:59 +0530 Message-ID: Subject: Re: [pgAdmin4] [Patch]: Extension Module To: Neel Patel Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11477e1c6d36d905299ab542 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11477e1c6d36d905299ab542 Content-Type: text/plain; charset=UTF-8 Thanks Neel for reviewing. I'll send the patch with the fixes suggested. On Mon, Jan 18, 2016 at 4:52 PM, Neel Patel wrote: > Hi Surinder, > > We have applied/tested the patch and below are the review comments. > > 1. When we select the extension "plpython3u", "plperl", "plperu" etc. then > it gives 'TypeError' in Javascript. > TypeError: d.version is undefined > 'version': (!_.isNull(d.version[0]) ? d.version[0]: '') > > We are getting this error while selecting many extensions so please test > with all types of extensions, it should not give any error at client side. > > 2. Use 2 space indentation instead of 4 space in javascript file. > > 3. In "validate" function in "extension.js" file, validate only the > changed values not all, and "this.get('name') - should be called only one > time not multiple > time". > > 4. When we pass object identifier, use the function 'qtIdent', and for > the values, use function 'qtLiteral' in all the sql files. > > 5. By default, when we create the extension, "schema_name" and "version" > should not be be set with value. It should be set blank by default. > > 6. When we create any extension like "citext" then we are not able to > create the same extension again after deleting the same extension. May be > issue > with caching mechanism. > > 7. When we remove the schema_name during the "Edit" operation then wrong > SQL is getting generated. > > 8. Remove "Use Slony" option. As discussed with Ashesh, we will implement > it as separate module. > > > Please fix the above issues. Let us know if you want more information. > > Thanks, > Neel Patel > > > Thanks, > Neel Patel > > > On Tue, Jan 12, 2016 at 1:15 PM, Surinder Kumar < > surinder.kumar@enterprisedb.com> wrote: > >> Please find the updated patch with following changes: >> >> 1. corrected copyright. >> 2. Added proper comment for script_module function in __init__.py >> file. >> 3. Renamed collection Node's label to Extensions in extensions.js >> file. >> >> >> On Tue, Jan 12, 2016 at 12:44 PM, Surinder Kumar < >> surinder.kumar@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find attached patch for the extension module. >>> Please review it and Let me know for any comments. >>> >>> >>> Thanks, >>> Surinder Kumar >>> >> >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > --001a11477e1c6d36d905299ab542 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks Neel for reviewing. I'll send the patch with th= e fixes suggested.

On Mon, Jan 18, 2016 at 4:52 PM, Neel Patel <neel.patel@e= nterprisedb.com> wrote:
Hi Surinder,

We have applied/tested the pa= tch and below are the review comments.

1. Whe= n we select the extension "plpython3u", "plperl", "= ;plperu" etc. then it gives 'TypeError' in Javascript.
TypeError: d.version is undefined
'version': (!_.isNul= l(d.version[0]) ? d.version[0]: '')

We are= getting this error while selecting many extensions so please test with all= types of extensions, it should not give any error at client side.

2.=C2=A0 Use 2 space indentation instead of 4 space in jav= ascript file.

3. In "validate" fun= ction in "extension.js" file, validate only the changed values no= t all, and "this.get('name') - should be called only one time = not multiple=C2=A0
=C2=A0 =C2=A0 time".

=
4.=C2=A0When we pass object identifie= r, use the function 'qtIdent', and for the values, use function =C2= =A0'qtLiteral' in all the sql files.

5. By default, when we create the extension, "schema_name" and = "version" should not be be set with value. It should be set blank= by default.

6. When we create any extension like = "citext" then we are not able to create the same extension again = after deleting the same extension. May be issue=C2=A0
=C2=A0 =C2= =A0 with caching mechanism.

7. When we remove the = schema_name during the "Edit" operation then wrong SQL is getting= generated.

8. Remove "Use Slony" option= . As discussed with Ashesh, we will implement it as separate module.
<= div>

Please fix the above issues. Let us know = if you want more information.

Thanks,
Ne= el Patel


Thanks,
Neel Pat= el


On Tue, Jan 12, 2016 at 1:15 PM, Surinde= r Kumar <surinder.kumar@enterprisedb.com> wrot= e:
Please find the updated patch with following changes:
  • corrected copyright.
  • Added proper comment for script_module fu= nction in __init__.py file.
  • Renamed collection Node's label to = Extensions in extensions.js file.

    • On Tue, Jan 12, 2016 at 12:= 44 PM, Surinder Kumar <surinder.kumar@enterprisedb.com&g= t; wrote:
    Hi= ,

    Please find attached patch for the extension mod= ule.
    Please review it and Let me know for any comments.


    Thanks,
    Surinder Kumar



    --
    Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
    To make changes to your subscription:
    http://www.postgresql.org/mailpref/pgadmin-hackers=



    --001a11477e1c6d36d905299ab542--