Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNKbn-0006J5-Eq for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jul 2016 13:53:51 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bNKbn-0002O4-1r for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jul 2016 13:53:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bNKba-0002AI-0e for pgadmin-hackers@postgresql.org; Wed, 13 Jul 2016 13:53:38 +0000 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bNKbV-00007U-Rs for pgadmin-hackers@postgresql.org; Wed, 13 Jul 2016 13:53:37 +0000 Received: by mail-wm0-x232.google.com with SMTP id i5so70487887wmg.0 for ; Wed, 13 Jul 2016 06:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Da4bwM5jJ5H/YhCHKCM2NVLcN5hHXkH0BSJOSBX26fU=; b=pviq+otBZi07UxRGPiwXoLg42gvtB1/iWw/h+7bRrDuRIisRgmp2ihkKcYLK8+8m+V DXZyJtsfo6qzh7NmfRTVaiMa8XXs+EN8FqKkf0NklCWGdywt+8Ddea77FwLYeuWMiZNy c9N7PBshmMeGe7jgBcOuIzP4xlMd0Zh2gyWtrqsQLh+oJvxhgFJOQEzbuvz8NzQVzyVS TmEmon0ojoTDrp4FF1zbh2Dx6XrlKdG7N29ytlmYs83NuWwVtVB4fWGKaaA8qkBPXoh9 q7JU6tDD5wDLiSWksbWUtFR5Rxl89BsSZkRYPE/eyNDWOsOq6n7G1b1oEYkX5Fz30i6b qiLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Da4bwM5jJ5H/YhCHKCM2NVLcN5hHXkH0BSJOSBX26fU=; b=CCfv7nmPyGzeOziUV/3JWUZbgk9XIFPjRm+dV3Qwg3G8bjE6LlwQiIs+4gQ8BC54Yx pR0L9H3p8isOlHR+AWoZ5bYlRfATPwZKYpiUdvTmMpozI6IOg0AiYjteD/WQoiv0gl02 fJId+Xurrz86N7iKv/YEUm2/6RNoilbJ0VVnpppAqoGfkjX6WR9oe4I7Y+iaOxstdIDW kf5WRnVmncwDL5P8Q/Z2kDM21/kCgGSs4f++gXVifiA5Jf3vEIFLELKbf1W2DmMrQMAP wR1XSpzqNz25/abYD8K2/jVsvxhhGnGMD3lxr4e12uHXb0jl9Gi9MU/B8W0cSvBUrqEw MZgA== X-Gm-Message-State: ALyK8tLmstiIp1oS21j1vzfTDGBhJ6MVX74wvAXWbTO0c82znGvRm02itdDvO1Co/rHWt7qqTH8PAv2z9PFX+wpU X-Received: by 10.28.109.197 with SMTP id b66mr26911419wmi.68.1468418013067; Wed, 13 Jul 2016 06:53:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.54.164 with HTTP; Wed, 13 Jul 2016 06:53:03 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Wed, 13 Jul 2016 19:23:03 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error To: Dave Page Cc: Marc Linster , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1146b3640d1434053784b694 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1146b3640d1434053784b694 Content-Type: text/plain; charset=UTF-8 I forgot to merge the fix for issue "File Browser - File does not exist error" in the patch. Please ignore this patch. On Wed, Jul 13, 2016 at 7:20 PM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Please find updated patch with following changes/enhancements: > > 1. Double click on file/folder icon or name will navigate to the > folder/file. > 2. Selected file/folder can be renamed by Rename button only. Double > click rename is removed. > 3. Filename text box will not hide on smaller screen. Setting minimum > width of File Browser fixed it. > 4. Path at top will only show directory name, not the file name and it > is greyed out. > > *Issue not fixed:* > Icons and fonts of Query tool and File Browser looks blurred in Runtime > environment. > I tried debugging it. while debugging, It gets fixed on my ubuntu runtime. > but I don't know how it gets fixed without changing css styles. It needs > more time to debug. > > Please review. > > On Wed, Jul 13, 2016 at 5:15 PM, Dave Page wrote: > >> On Tue, Jul 12, 2016 at 7:10 AM, Surinder Kumar >> wrote: >> > On Mon, Jul 11, 2016 at 6:41 PM, Dave Page wrote: >> >> >> >> On Thu, Jul 7, 2016 at 1:50 PM, Surinder Kumar >> >> wrote: >> >> > On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar >> >> > wrote: >> >> >> >> >> >> On Wed, Jul 6, 2016 at 5:40 PM, Dave Page >> wrote: >> >> >>> >> >> >>> Hi, >> >> >>> >> >> >>> I think we need more changes than just that; >> >> >>> >> >> >>> - The path at the top should not be editable (it should be greyed >> in >> >> >>> fact) >> >> >> >> >> >> Ok >> >> >>> >> >> >>> >> >> >>> - The path at the top should only show the directory path. The >> >> >>> filename should never be appended. >> >> >> >> >> >> Ok >> >> >>> >> >> >>> >> >> >>> - The CSS needs to be fixed so the filename textbox at the bottom >> is >> >> >>> never hidden (as it is now if the dialogue opens at a small size). >> >> >> >> >> >> Ok >> >> >>> >> >> >>> >> >> >>> - Double-click to navigate vs. rename should be modified to work in >> >> >>> part like it does on Mac - Double-click on either the icon or the >> name >> >> >>> should open the item (browser into a folder, or select and "OK" on >> a >> >> >>> file), and Click then Enter should rename. I'm hesitant to try to >> >> >>> implement "slow double click to rename" as that would likely need >> to >> >> >>> be tunable for accessibility reasons. >> >> >> >> >> >> Ok, I will fix it. >> >> > >> >> > In the current scenario, the Enter Key is bound to the OK button by >> >> > default >> >> > in Alertify dialog which servers the purpose of closing the dialog. >> >> > Should we de-attach Enter Key event bound to OK button and use it for >> >> > rename >> >> > file? >> >> > please suggest what should I do? >> >> >> >> Hmm, good point. >> >> >> >> How hard would it be to look for 2 consecutive single-clicks (but not >> >> a double-click) for rename? If we can do that, it avoids timing >> >> considerations for double-clicks (which would be defined by the OS). >> > >> > >> > I tried to implement slow double click, here is Fiddle >> > There are two events 1) double click (it will be used for folder >> navigation) >> > 2) Slow double click(For rename), It is a simple click event, when >> clicked >> > twice after delay we consider it a slow double click. >> > >> > But it is not working smoothly, double click and single click events are >> > conflicting. >> >> Yeah, so I see. >> >> > Also, we have rename button in navigation for rename operation, >> > Can we skip slow double click because it is very confusing? >> >> OK, I must have been having a brain failure moment or something. Yes, >> skip it - we obviously don't need it with the rename button. >> >> So we have: >> >> - Click to select >> - Double click to open a folder >> - Button to rename the select file/folder >> >> Sorry! >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a1146b3640d1434053784b694 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I forgot to merge the fix for issue "File Browser - File does not exist error" in the= patch.
Please ignore this patch.

On Wed, Jul 13, 2016 at 7:20 PM, Surinder K= umar <surinder.kumar@enterprisedb.com> wrote:<= br>
Please find updated patc= h with following changes/enhancements:
  1. Double click on file/fol= der icon or name will navigate to the folder/file.
  2. Selected fil= e/folder can be renamed by Rename button only. Double click rename is remov= ed.
  3. Filename text box will not hide on smaller screen. Setting = minimum width of File Browser fixed it.
  4. Path at top will only s= how directory name, not the file name and it is greyed out.
<= u>Issue not fixed:
Icons and fonts of Query tool and File Bro= wser looks blurred in Runtime environment.
I tried debugging it. = while debugging, It gets fixed on my ubuntu runtime. but I don't know h= ow it gets fixed without changing css styles. It needs more time to debug.<= /div>

Please review.

On Wed, Jul 13, 2016 at 5:15 PM, Dave Page <dpage@pgadmin.org>= wrote:
On Tue, Jul 12, 2016 at 7:= 10 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> On Mon, Jul 11, 2016 at 6:41 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Thu, Jul 7, 2016 at 1:50 PM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>> > On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar
>> > <surinder.kumar@enterprisedb.com> wrote:
>> >>
>> >> On Wed, Jul 6, 2016 at 5:40 PM, Dave Page <dpage@pgadmin.org> wrote= :
>> >>>
>> >>> Hi,
>> >>>
>> >>> I think we need more changes than just that;
>> >>>
>> >>> - The path at the top should not be editable (it shou= ld be greyed in
>> >>> fact)
>> >>
>> >> Ok
>> >>>
>> >>>
>> >>> - The path at the top should only show the directory = path. The
>> >>> filename should never be appended.
>> >>
>> >> Ok
>> >>>
>> >>>
>> >>> - The CSS needs to be fixed so the filename textbox a= t the bottom is
>> >>> never hidden (as it is now if the dialogue opens at a= small size).
>> >>
>> >> Ok
>> >>>
>> >>>
>> >>> - Double-click to navigate vs. rename should be modif= ied to work in
>> >>> part like it does on Mac - Double-click on either the= icon or the name
>> >>> should open the item (browser into a folder, or selec= t and "OK" on a
>> >>> file), and Click then Enter should rename. I'm he= sitant to try to
>> >>> implement "slow double click to rename" as = that would likely need to
>> >>> be tunable for accessibility reasons.
>> >>
>> >> Ok, I will fix it.
>> >
>> > In the current scenario, the Enter Key is bound to the OK but= ton by
>> > default
>> > in Alertify dialog which servers the purpose of closing the d= ialog.
>> > Should we de-attach Enter Key event bound to OK button and us= e it for
>> > rename
>> > file?
>> > please suggest what should I do?
>>
>> Hmm, good point.
>>
>> How hard would it be to look for 2 consecutive single-clicks (but = not
>> a double-click) for rename? If we can do that, it avoids timing >> considerations for double-clicks (which would be defined by the OS= ).
>
>
> I tried to implement slow double click, here is Fiddle
> There are two events 1) double click (it will be used for folder navig= ation)
> 2) Slow double click(For rename), It is a simple click event, when cli= cked
> twice after delay we consider it a slow double click.
>
> But it is not working smoothly, double click and single click events a= re
> conflicting.

Yeah, so I see.

> Also, we have rename button in navigation for rename operation,
> Can we skip slow double click because it is very confusing?

OK, I must have been having a brain failure moment or something. Yes= ,
skip it - we obviously don't need it with the rename button.

So we have:

- Click to select
- Double click to open a folder
- Button to rename the select file/folder

Sorry!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--001a1146b3640d1434053784b694--