Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjOPu-00079S-I4 for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Sep 2016 10:24:46 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bjOPu-0001mN-33 for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Sep 2016 10:24:46 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bjOPt-0001mG-JE for pgadmin-hackers@postgresql.org; Mon, 12 Sep 2016 10:24:45 +0000 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bjOPq-0005xz-QS for pgadmin-hackers@postgresql.org; Mon, 12 Sep 2016 10:24:44 +0000 Received: by mail-wm0-x22a.google.com with SMTP id b187so128020486wme.1 for ; Mon, 12 Sep 2016 03:24:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=Wr2QJKGolT9U3Im3ucOBW175UP5nfvtfEo5oSywqrhY=; b=A4GjB2rMfuq8T1QcGgIAyUpl7xRenbRDuPeUf5sXfk4hiz8oL9XDC7LNY7UVYaQUb3 /Ke903Jk5UblbIRlA9TgtEhtcEV+CBUM8bmZDds9BRR3YcFQ2qcOmX5R+Pk3ZMTAOgLh X/lMU45wRqQaOfCEUozaXnuQhiM1CFRYsxOhmkBMv7tKaAK+w0OwRFAXKl3x9Ul+EupX WaXBk5kHZDqmsqdL49gNTiGcAH9GhbPUQGl+tk9JEU2QVcQalB/YeHiqDEebnWqyXZEX Wb5TDF6du4sCNPDUr7Nf0hxGRbOkF5KOv7DlKNQN0v/JnZnmg1ohM6QtMjvwg58qYejo 4zVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=Wr2QJKGolT9U3Im3ucOBW175UP5nfvtfEo5oSywqrhY=; b=cnnyyCAwYZ3VgL5nO5f/3QPdxXz8lKMw8JXuQtahftkq1bfYJYY4zZWgbLwBS30Ayr fKtt3tcVY9lCr0rMK5T2CPdSoJwVa2cML3juOlyiI5N4ymNj1//OsEadkZL2aP698IXs DgNFDZ4ePe3y8OIV9QM10jkcupJ/QlNQesXNRnCdGe4sUmIljFV7iTF/zUSOwqYyviNl 5ZY14WlcVYAAm13eSVBV3dw2/Et+MCodOMfGnFpqPgqZXAjasfnjjuosvn1jGfSQU56L Ww3PZzeti29M3kSdjAz1aEMqZ315vE4PrQ5hpDwHQk5VdrKTQLbHJYhTHZoKUMvt/W3b /W0g== X-Gm-Message-State: AE9vXwNBCrvArl3paZvHjDS0JRQ3z6/pp2WAkLIh0aOkJmqza+wKvTzLDdv0ccem0zd4dnrHnlt/AM/W1tVifHgC X-Received: by 10.194.83.33 with SMTP id n1mr13605168wjy.36.1473675881055; Mon, 12 Sep 2016 03:24:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Mon, 12 Sep 2016 03:24:10 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Mon, 12 Sep 2016 15:54:10 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters To: pgadmin-hackers Content-Type: multipart/alternative; boundary=047d7bb04d7e679cbe053c4ce74c X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7bb04d7e679cbe053c4ce74c Content-Type: text/plain; charset=UTF-8 This patch doesn't fix the issue in Procedure node. I will send updated patch. On Mon, Sep 12, 2016 at 3:12 PM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Hi, > > Please find attached patch with fix. > *Changes:* > 1) Take a list of "function argument types", create a string separated by > comma(removing trailing comma). > 2) Function arguments in ALTER and GRANT not necessarily to have *argument > mode, name, *they are optional. Only type is required. > Now GRANT statement is represented as > > *GRANT EXECUTE ON FUNCTION test_schema.test_func(integer, integer, > integer) TO postgres *as in pgadmin3. > > > Please review. > --047d7bb04d7e679cbe053c4ce74c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thi= s patch doesn't fix the issue in Procedure node. I will send updated pa= tch.

O= n Mon, Sep 12, 2016 at 3:12 PM, Surinder Kumar <surinder.kum= ar@enterprisedb.com> wrote:
Hi= ,

Please find attached pa= tch with fix.
<= b>Changes:
1) Take a list of "function argument types", create a stri= ng separated by comma(removing trailing comma).
2) Function arguments in ALTER and GRANT n= ot necessarily to have argument mode, name,=C2=A0they are optional. = Only type is required.
Now GRANT statement is represented as

G= RANT EXECUTE ON FUNCTION test_schema.test_func(integer, integer, integer= ) TO postgres=C2=A0as in pgadmin3.


Please review.

--047d7bb04d7e679cbe053c4ce74c--