Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d43Sp-0003nV-K3 for pgadmin-hackers@arkaria.postgresql.org; Fri, 28 Apr 2017 10:49:27 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d43Sp-00038q-6e for pgadmin-hackers@arkaria.postgresql.org; Fri, 28 Apr 2017 10:49:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d43Sb-0002kP-9h for pgadmin-hackers@postgresql.org; Fri, 28 Apr 2017 10:49:13 +0000 Received: from mail-wr0-x230.google.com ([2a00:1450:400c:c0c::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d43SX-0008V1-L4 for pgadmin-hackers@postgresql.org; Fri, 28 Apr 2017 10:49:12 +0000 Received: by mail-wr0-x230.google.com with SMTP id l50so31457753wrc.3 for ; Fri, 28 Apr 2017 03:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=UfIXO00hIWPCuQ0NF2duDWw1SvstunC5jlEe5N7sV4E=; b=1s5EXBDzeFNDToJNDiHQeyEUwwWWdeLYr11aKPeGYEYXaXzso8p/NeSEKPLqgZsnhq 8DA0qmTwb0TIPughlLaDBxUnr3A5V8ORUFYiTEfGQOIDf4JVJN4o3Gkx0PBKWCKI+tE9 xWXmZzduXmKGLepBc5nO/dqSxDl1kJHnD1eRKkgNnn+BHslEQliCEYQkjyGvjtNHwfaK du4KGaluzE0jjB6igW/tEvlgeZiIOVjGspdcWo5CSk+H5+asaZpLmyTp/4udlWHyDldM w22jqkdvZxIEAsMELIj7M+Gqx1MJU88X+bHXoKyHjlBGzwL54uHieWI5nFb+4cqhMavM hFPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=UfIXO00hIWPCuQ0NF2duDWw1SvstunC5jlEe5N7sV4E=; b=s4GGZsI7HaexN/UE3dH49P8Z5+exegvTuuMlxIVr/pseKRgqyN/849MZVYGnwOm/8N KePwpmKLwK2D6cqswjk5X5pcf7ybAwmBgcm/CbK+mKIoBoAH/94j9CxV1C2TdPYNou5+ Fl+XWBmFVHu78oZ50scrrMD1cWRGHNtrGXK5HpsyiDtgXhxJCX2HPeKVA0IgHGkajfsJ fZBrZL8/guRfT6wLY2D2QNpa0G2+VTpjdyGegPeBqe45+NRT71EuTE0oE8y2WgicKBr7 RLUKV/30nAK0wFNx2jrXLmJchUFB8sWcwCLsOc5r3F3G/0ROSqZZHSxvPV6FKIvCiDlI 8YLA== X-Gm-Message-State: AN3rC/7ojoNy+P7x1QrREK5MfhBMdI0Z3lVXl5BBxY9cHjFh744Q+nki ZuOVD7k4u/VXbHr/pkkWEUnHrEZdbsvO+Hs= X-Received: by 10.223.155.2 with SMTP id b2mr7106277wrc.87.1493376548083; Fri, 28 Apr 2017 03:49:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.101.2 with HTTP; Fri, 28 Apr 2017 03:48:37 -0700 (PDT) From: Surinder Kumar Date: Fri, 28 Apr 2017 16:18:37 +0530 Message-ID: Subject: [pgAdmin4][Patch]: Delete row server error not shown to GUI user To: pgadmin-hackers Content-Type: multipart/mixed; boundary=94eb2c1cd484aa9c22054e37d28d X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c1cd484aa9c22054e37d28d Content-Type: multipart/alternative; boundary=94eb2c1cd484aa9c1d054e37d28b --94eb2c1cd484aa9c1d054e37d28b Content-Type: text/plain; charset=UTF-8 Hi The variable list_of_rowid doesn't keep track of rows to be deleted. If this list is empty simply return 0 since '_rowid' is being used to highlight the row for which error is occurred in only insert and update operation. Please find attached patch and review. Thanks, Surinder Kumar --94eb2c1cd484aa9c1d054e37d28b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

The variable=C2=A0list_of_r= owid=C2=A0doesn't keep track of rows to be deleted.
If this list is empty simply return 0 since '_row= id' is being used to highlight the row for which error is occurred in o= nly insert and update operation.

Please find attached patch and review.
=

Thanks,=
Surinder Kumar
--94eb2c1cd484aa9c1d054e37d28b-- --94eb2c1cd484aa9c22054e37d28d Content-Type: application/octet-stream; name="RM_2356.patch" Content-Disposition: attachment; filename="RM_2356.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j21psenr0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9jb21t YW5kLnB5IGIvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL2NvbW1hbmQu cHkKaW5kZXggYmU3ZjIxZi4uMTc5NTE1NSAxMDA2NDQKLS0tIGEvd2ViL3Bn YWRtaW4vdG9vbHMvc3FsZWRpdG9yL2NvbW1hbmQucHkKKysrIGIvd2ViL3Bn YWRtaW4vdG9vbHMvc3FsZWRpdG9yL2NvbW1hbmQucHkKQEAgLTUyNiw3ICs1 MjYsOSBAQCBjbGFzcyBUYWJsZUNvbW1hbmQoR3JpZENvbW1hbmQpOgogICAg ICAgICAgICAgICAgICAgICAgICAgZm9yIHZhbCBpbiBxdWVyeV9yZXM6CiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgcXVlcnlfcmVzW3ZhbF1b J3N0YXR1cyddOgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBx dWVyeV9yZXNbdmFsXVsncmVzdWx0J10gPSAnVHJhbnNhY3Rpb24gUk9MTEJB Q0snCi0gICAgICAgICAgICAgICAgICAgICAgICBfcm93aWQgPSBsaXN0X29m X3Jvd2lkW2ldCisKKyAgICAgICAgICAgICAgICAgICAgICAgICMgSWYgbGlz dCBpcyBlbXB0eSBzZXQgcm93aWQgdG8gMQorICAgICAgICAgICAgICAgICAg ICAgICAgX3Jvd2lkID0gbGlzdF9vZl9yb3dpZFtpXSBpZiBsaXN0X29mX3Jv d2lkIGVsc2UgMQogCiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4g c3RhdHVzLCByZXMsIHF1ZXJ5X3JlcywgX3Jvd2lkCiAK --94eb2c1cd484aa9c22054e37d28d Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --94eb2c1cd484aa9c22054e37d28d--