Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bWjTS-00009X-Tk for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Aug 2016 12:16:07 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bWjTS-0000zm-96 for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Aug 2016 12:16:06 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bWjTQ-0000zd-C2 for pgadmin-hackers@postgresql.org; Mon, 08 Aug 2016 12:16:04 +0000 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bWjTI-0007Fe-2o for pgadmin-hackers@postgresql.org; Mon, 08 Aug 2016 12:16:02 +0000 Received: by mail-wm0-x234.google.com with SMTP id i5so135010478wmg.0 for ; Mon, 08 Aug 2016 05:15:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=t1MIbmNSp5K7XEPEoXuPzO8EY5OtCn5+HBhbm+mwnJQ=; b=dd/jgxiHwg5dsfIvdBHxJVMoGW5q1Vbj7H1PyTvpeSPpreOTxED4Co+L6sP1ax1emZ TBJZSeO+Jlsn80xf0ghodzfd8MFqDPdjOkuSPeaB0Thw+srml9D2I8HQEEuMtoMac0vY TV7o+G4eiS/53dPecqSyQnkPGtIecALgRY2eC9B4jwhzJaNE7z9shtW+VM8zaXUhG1f5 su4mpSB6Ao9qp2xzHjbHI9CkTEif7l4guyXed8MvKR+EtFsy5AHkgtYsQIPLTu+4d7aw c2C+gLwEiXXxazVqIjJGykG0KaExDvpiPK+wF0U8Yk6r8EoiE+1RkVJizKJj+4IsEoLl xjYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=t1MIbmNSp5K7XEPEoXuPzO8EY5OtCn5+HBhbm+mwnJQ=; b=Gwk3NcOeHTpEuXhaoEtxlwTun+45mdIejyYt1wkNC8nijMLbLLj3f65lfbbnBZ7blL PATZ9lThG5eK1oLQMhaXss/e8ignz3Kd/rRCEpyErCPZvvbk6S+syBwxuwj2ub+gQ+lm EjTGf1BhaYm0rmdXM2CtP7f1k3SBL41/J+Sv5Jek2M8KzXbhjmk8VIaL35JauCTnguxH 2AI2JgquybAiFaMQu+3tyb32tS2+AwauhzKW1CzCt02xularlh8ghFFkwLWEK8tBHCXb P+pk1wiOtGBct8tvp0fphKGW+r+IBkiwZKYm15Jqvl2zjax3/VFDa1lEGsVZKVPXu3nT 1XZQ== X-Gm-Message-State: AEkoouupy0Rg5OgNbub6mkXS0eBMTN7/cPJZQA4A3EJpnjLDBXLfs7abv7xEAB73gx5JVE66YH232r9NNQ7S0Zws X-Received: by 10.28.211.10 with SMTP id k10mr15254355wmg.16.1470658553437; Mon, 08 Aug 2016 05:15:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.167.81 with HTTP; Mon, 8 Aug 2016 05:15:22 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Mon, 8 Aug 2016 17:45:22 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM#1478 - Make code mirror text editor keyboard shortcuts consistent irrespective of platform type To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11468b5ea9fa4e05398e6024 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11468b5ea9fa4e05398e6024 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, Aug 8, 2016 at 4:43 PM, Dave Page wrote: > Hi Surinder, > > This looks very promising, but it only covers the query tool at > present. We need the shortcuts to apply to all codemirror instances. > Do the others work anyway, because we're invoking in a different way, > or is more work needed there? =E2=80=8BTo apply the same shortcuts to other codemirror instances(e.g: SqlTabControl) we just need to set a parameter *extraKeys: pgAdmin.editor_shortcut_keys=E2=80=8B *for every codemirror ins= tance. As of now, shortcuts are applicable to *query tool & data filter*. Also, we need to define *pgAdmin.editor_shortcut_keys=E2=80=8B *variable in server.js instead of sqleditor.js to work it for other code mirror instances. > On Fri, Aug 5, 2016 at 6:42 PM, Surinder Kumar > wrote: > > Hi > > > > I found that Code-mirror library itself provides the List of keyboard > > shortcuts for Mac OSX and other platform type. > > We just need to pass them in extraKeys param while creating code-mirror > > instance. > > > > Following is the keyboard shortcuts for various operations in text > editor: > > > > Copy - [Ctrl-C, Cmd-C] > > Cut - [Ctrl-X, Cmd-X] > > Select All - [Ctrl-A, Cmd-A] > > Undo - [Ctrl-Z, Cmd-Z] > > Redo - [Ctrl-Y, Cmd-Y] > > Delete Line - [Ctrl-D, Cmd-D] > > Move left/right(words) - [Alt-Left, Alt-Right] > > Move start/end of line - [Cmd-Left, Cmd-Right] // Ctrl-Left/Right are > bound > > to System shortcuts. so these keys cannot be used. > > > > These keyboard shortcuts are consistent in Web/Runtime applications in > all > > platform types. > > > > Issue not fixed: > > keyboard shortcut for Paste text doesn't work in Mac Runtime only. It i= s > > working on Linux runtime & Windows Runtime. > > An issue "Key shortcuts doesn't work on Mac OS for QWebView widget" is > also > > reported. > > > > I also found that right click paste is working in Mac Runtime which is > the > > feature of code-mirror, So I am looking into its code to figure out and= I > > will send a patch with fix once it gets fixed. > > > > Please find attached patch and review. > > > > > > Thanks, > > Surinder Kumar > > > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a11468b5ea9fa4e05398e6024 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = Mon, Aug 8, 2016 at 4:43 PM, Dave Page <dpage@pgadmin.org> w= rote:
Hi Surinder,

This looks very promising, but it only covers the query tool at
present. We need the shortcuts to apply to all codemirror instances.
Do the others work anyway, because we're invoking in a different way, or is more work needed there?
=E2=80=8BTo apply the same shortcuts to other codemir= ror instances(e.g: SqlTabControl) we just need to set a parameter
extraKeys: pgAdmin.ed= itor_shortcut_keys=E2=80=8B for every codemirror instance.
As of now, shortcuts are ap= plicable to query tool & data filter.

Also, we need to define=C2=A0pgAdmin.editor_= shortcut_keys=E2=80=8B variable in server.js instead of sqleditor.js to= work it for
ot= her code mirror instances.


On Fri, Aug 5, 2016 at 6:42 PM, Surinder Kumar
<su= rinder.kumar@enterprisedb.com> wrote:
> Hi
>
> I found that Code-mirror library itself provides the List of keyboard<= br> > shortcuts for Mac OSX and other platform type.
> We just need to pass them in extraKeys param while creating code-mirro= r
> instance.
>
> Following is the keyboard shortcuts for various operations in text edi= tor:
>
> Copy -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [Ctrl-C, Cmd-C]
> Cut -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0[Ctrl-X, Cmd-X]
> Select All -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 [Ctrl-A, Cmd-A]
> Undo -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [Ctrl-Z, Cmd-Z]
> Redo -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [Ctrl-Y, Cmd-Y]
> Delete Line -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 [Ctrl-D, Cmd-D]
> Move left/right(words) -=C2=A0 [Alt-Left, Alt-Right]
> Move start/end of line -=C2=A0 [Cmd-Left, Cmd-Right] // Ctrl-Left/Righ= t are bound
> to System=C2=A0 =C2=A0shortcuts. so these keys cannot be used.
>
> These keyboard shortcuts are consistent in Web/Runtime applications in= all
> platform types.
>
> Issue not fixed:
> keyboard shortcut for Paste text doesn't work in Mac Runtime only.= It is
> working on Linux runtime & Windows Runtime.
> An issue "Key shortcuts doesn't work on Mac OS for QWebView w= idget" is also
> reported.
>
> I also found that right click paste is working in Mac Runtime which is= the
> feature of code-mirror, So I am looking into its code to figure out an= d I
> will send a patch with fix once it gets fixed.
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadm= in-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a11468b5ea9fa4e05398e6024--