Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkSuk-0002NT-LJ for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Sep 2016 09:25:02 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bkSuk-0000Ua-0F for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Sep 2016 09:25:02 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bkSuj-0000US-Dm for pgadmin-hackers@postgresql.org; Thu, 15 Sep 2016 09:25:01 +0000 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bkSub-0006Et-Ps for pgadmin-hackers@postgresql.org; Thu, 15 Sep 2016 09:25:00 +0000 Received: by mail-wm0-x22e.google.com with SMTP id 1so80591303wmz.1 for ; Thu, 15 Sep 2016 02:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=bK2T73pWeJQOgVN9Pn+8mEktSrdQIn7mhJKcJWcV1Yc=; b=V8SMNKkLYPQzyU+jzocumDc2AZGOlhaPrD/GuMDeZy1B7oSIXapzqw0QDRg0lUF3Ov x0M16CBfFzLE1nPiDuFOGJodBuxMdBWvAN182oxsjWA66ESliawPx7ZGum+/JuZJqkHn QMVu2dTSDWRqzx37gQ6GOCrbTxu0VI3aFDh4r2W3juGEzFXmSGiIMG+qGRLShlSlwkpj 0DCPBvabUYEQb3IHNDFdFaMM7tPZxbRCI9ai4aGqRh4eIaFIe/hNE+mSg0SX04Fc3EAW Irc8eaDxOPT2bkC+XpN5Jhzm7C2sUfqaPjrOcYXle9zLTbSd9qRY7m7upLkgHgrDv+sM fp+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=bK2T73pWeJQOgVN9Pn+8mEktSrdQIn7mhJKcJWcV1Yc=; b=QjdLseYmAmv1q+/dRWHglkMQG/ySP2mLp81BMIks9DnwoDUqLU4V/y+8QijD6mo6bz hHi7hc4op97dXYjwzhl2dbEM89Rr41Cg4SflrY+yrHIN0Mnbbm2Hyak1eU8n+rS46sd4 kjXLy6XnThxcH1Ievb/eTi9r5gETe1bc+B37CFmJHdIfDugi5zi4+Asxhb3w6Ytl5GgY HFBXdWrpaD4VhOU5nnCdh1eHgukOiRfxJg8GpSRKXubhQ+NZHOvLBHI6IDEEM+q6Atfl PozoimYOYts6hCvbNTZRHTjvn1NND/HBKkKhJ/1oRo7ECZuc++PTVwey1P4BcQYHnAh7 8+MQ== X-Gm-Message-State: AE9vXwMggw2cTOs3y6UUiCbS+DYp1SYuyMXW3MJOPdYWKAIGP8jnihreO+Lz3tbUgsr02DsBorlZ+8Ywax+31+o/ X-Received: by 10.194.149.238 with SMTP id ud14mr7707188wjb.194.1473931492215; Thu, 15 Sep 2016 02:24:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Thu, 15 Sep 2016 02:24:21 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Thu, 15 Sep 2016 14:54:21 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1579 - Unable to scroll the query text window during selection To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=089e01228b940467ec053c886bd0 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e01228b940467ec053c886bd0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, Sep 15, 2016 at 2:47 PM, Dave Page wrote: > Thanks, applied. > > One minor tweak to look at - in firefox, the width of the left margin > in the query tool changes when you add a line, if the font size in > preferences is not set to 1em. I think the width is initially sized > for the font, then gets adjusted as you hit return. This doesn't seem > to affect Chrome, and is only a minor annoyance in Firefox. > =E2=80=8BOk, I will look into it.=E2=80=8B > > On Thu, Sep 15, 2016 at 10:04 AM, Surinder Kumar > wrote: > > Hi > > > > Please find updated patch. > > > > On Thu, Sep 15, 2016 at 1:38 PM, Dave Page wrote: > >> > >> (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/RM1579.patch > >> error: patch failed: web/pgadmin/static/css/overrides.css:53 > >> error: web/pgadmin/static/css/overrides.css: patch does not apply > >> > >> Please rebase! > >> > >> On Thu, Sep 15, 2016 at 8:54 AM, Surinder Kumar > >> wrote: > >> > Hi > >> > > >> > Please find the attached patch patch with following changes: > >> > > >> > 1) Implemented CodeMirror addon 'simplescrollbars'. > >> > > >> > 2) The CodeMirror instance of query tool was not rendering into > >> > wcDocker's > >> > 'pg-panel-content' div. it renders outside the div, due to which it > took > >> > little more time investigating why scrollbars doesn't appear in > editor. > >> > > >> > 3) Add new css specific to query tool. > >> > > >> > > >> > Please review. > >> > > >> > Thanks, > >> > Surinder Kumar > >> > > >> > > >> > > >> > -- > >> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.or= g > ) > >> > To make changes to your subscription: > >> > http://www.postgresql.org/mailpref/pgadmin-hackers > >> > > >> > >> > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --089e01228b940467ec053c886bd0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Thu, Sep 15, 2016 at 2:47 PM, Dave Pag= e <dpage@pgadmin.org> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">Thanks, applied.

One minor tweak to look at - in firefox, the width of the left margin
in the query tool changes when you add a line, if the font size in
preferences is not set to 1em. I think the width is initially sized
for the font, then gets adjusted as you hit return. This doesn't seem to affect Chrome, and is only a minor annoyance in Firefox.
=E2=80=8BOk, I will= look into it.=E2=80=8B

On Thu, Sep 15, 2016 at 10:04 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Please find updated patch.
>
> On Thu, Sep 15, 2016 at 1:38 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/RM1579.pat= ch
>> error: patch failed: web/pgadmin/static/css/overrides.css:53<= br> >> error: web/pgadmin/static/css/overrides.css: patch does not a= pply
>>
>> Please rebase!
>>
>> On Thu, Sep 15, 2016 at 8:54 AM, Surinder Kumar
>> <surinder.ku= mar@enterprisedb.com> wrote:
>> > Hi
>> >
>> > Please find the attached patch patch with following changes:<= br> >> >
>> > 1) Implemented CodeMirror addon 'simplescrollbars'. >> >
>> > 2) The CodeMirror instance of query tool was not rendering in= to
>> > wcDocker's
>> > 'pg-panel-content' div. it renders outside the div, d= ue to which it took
>> > little more time investigating why scrollbars doesn't app= ear in editor.
>> >
>> > 3) Add new css specific to query tool.
>> >
>> >
>> > Please review.
>> >
>> > Thanks,
>> > Surinder Kumar
>> >
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailp= ref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--089e01228b940467ec053c886bd0--