Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNEL7-0002qb-Uy for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jul 2016 07:12:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bNEL7-0002JR-3Z for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jul 2016 07:12:13 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bNEL6-0002JI-HJ for pgadmin-hackers@postgresql.org; Wed, 13 Jul 2016 07:12:12 +0000 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bNEL3-0006Yb-Bh for pgadmin-hackers@postgresql.org; Wed, 13 Jul 2016 07:12:11 +0000 Received: by mail-wm0-x22d.google.com with SMTP id f126so16140298wma.1 for ; Wed, 13 Jul 2016 00:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nMMqer91b4Lm38DyZipVvTgfz6b8xeNc4T5LHfJQA38=; b=QNCYiw88rrk5wUcfeDPqDXRBTKJj7SOMCryJVx7SSbZ2i+BXsYfhAAIVhrbmL9b0SO P/JyEjq2ufMBUukNVrCSeWQdX5t4ZDAXjz41ZMlvSCrF/kLiqRYEqehNLAordXsgtRxZ 1rG4X/NEKtWxnr+EcfmvA6/uBjMFS9GIMqvzh/v/PIlVywJYO79qBRjzYxXVqEesyiuL t2gzwpsByg5WrE2ZE1+cJ12a166sOubdXh8OudpI88Ec9F++dBAMhez0ws67e3RfoOQe pgkL4T6+6Y19n+U6qE63dau/3gIU6RRT1rJAVBoOORpPEovnfc0RI5Iqn+bdw/+Ni6QL xHsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nMMqer91b4Lm38DyZipVvTgfz6b8xeNc4T5LHfJQA38=; b=lm8g6pV0zjWwbHqdraKK7eyJyMNIx+ztb4RMrBGhQ8Tk815HDKcF85FQLdtK29doKi bZrjIwGBU0J1w34WHato6pFOp0yuM+ox6F8p6a+4DmUsUJdqyhN3jC7aQBtu1Evh9HzX MuFMrAWLl7Edci67431RskO28CCAtQRIZj2T8Mbl2jF0ybiofd3z0wYtztgxddE4bcec 65/vyM0MA0F682uqqaSOUIcQpygM1nWg2/87zb1C91tqyxlm/SGxP0XWNBMV2m0oJwMr wvsqWImwihXqF93CWkKjPWpF/GvUjKs3FSiMQhaNr0Us6BHuD8H1F0Jwhbss3a2QBor2 IsRw== X-Gm-Message-State: ALyK8tJCMWCt1iHT8EpKX2rm5pLgvq5W2kHAkQfuVhY5psygOvzoJAlWPS/0VNZbGPs0VDtYl5oJWJHfRW/VwB69 X-Received: by 10.28.50.199 with SMTP id y190mr20631867wmy.61.1468393927615; Wed, 13 Jul 2016 00:12:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.54.164 with HTTP; Wed, 13 Jul 2016 00:11:38 -0700 (PDT) In-Reply-To: <15FAEF8A-E482-40A9-8C83-57D3F8458143@pgadmin.org> References: <15FAEF8A-E482-40A9-8C83-57D3F8458143@pgadmin.org> From: Surinder Kumar Date: Wed, 13 Jul 2016 12:41:38 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: Render data grid only if Dashboard Panel is active To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1147da0c723ac805377f1a1a X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1147da0c723ac805377f1a1a Content-Type: text/plain; charset=UTF-8 On Wed, Jul 13, 2016 at 12:32 PM, Dave Page wrote: > Won't this result in incorrect graphs? I.e. chunks of data being missing > (but not obviously so)? > Oh I see.. It might result in incorrect graphs.. Please ignore the patch. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK:http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On 13 Jul 2016, at 07:47, Surinder Kumar > wrote: > > Hi > > In Dashboard, the ajax calls to *render data grid* should only made, if > dashboard panel is active. > Currently it make ajax calls even if other panels like properties, sql are > active. > > Please find attached patch and review. > > Thanks, > Surinder Kumar > > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > --001a1147da0c723ac805377f1a1a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Wed, Jul 13, 2016 at 12:32 PM, Dave Page <dpage@pgadmi= n.org> wrote:
Won't t= his result in incorrect graphs? I.e. chunks of data being missing (but not = obviously so)?
=C2=A0Oh I see.. It might r= esult in incorrect graphs..
Please ignore the patch.

--=C2=A0
Dave Page
Blog:=C2=A0http://pgsnake.blogspot.co= m
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The En= terprise PostgreSQL Company

On = 13 Jul 2016, at 07:47, Surinder Kumar <surinder.kumar@enterprisedb.com>= wrote:

Hi
In Dashboard, the ajax calls to render data grid sho= uld only made, if dashboard panel is active.
Currently it make aj= ax calls even if other panels like properties, sql are active.
Please find attached patch and review.

Thanks,
Surinder Kumar
<dashboard= _render_if_panel_is_opened.patch>

= --
Sent via pgadmin-hackers mailing list (pgadmin-hackers@p= ostgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers<= /span>

--001a1147da0c723ac805377f1a1a--