Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMXzz-0001xP-J3 for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jul 2016 09:59:35 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bMXzz-0005Xk-6M for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jul 2016 09:59:35 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bMXzm-0005JW-AC for pgadmin-hackers@postgresql.org; Mon, 11 Jul 2016 09:59:22 +0000 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bMXze-00088t-Uk for pgadmin-hackers@postgresql.org; Mon, 11 Jul 2016 09:59:21 +0000 Received: by mail-wm0-x22a.google.com with SMTP id p190so13964155wmp.1 for ; Mon, 11 Jul 2016 02:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=HLZ8yuNXNiK3kcZP8O5eCTj13bNOimdQHtnDVocsm/k=; b=wka3NgNXDIY1EN1O/rgxWQ4AWIfRCe4mTo8H1/pWOgb5MITNvC6791K7IpYxTLv0Co icVvylBjX9E9EnXCLnOWo8hVWaYkNOfyilKPUg4OhMLGFiz7gv+HDdAuOfUSqKuDR0HD ZMVI9Htm4LWCiEsgYYsWNz1G+ZVKE59NMDcAVS7zOtaMJscdkZp3y435DignOngqdPhd 3xlEleOJJ+WlZb+TAu6ggZBJS8BHY+C6fa4wQodwEPN7iCvBfa+lYM8AmuNy8FqKhZ1A neE/IdBqZG8gMBZshhRs8fQflljWS83cKDaLA1H3Hztd1b+gTP4neq/CXFAnBz+m8LJI YDag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=HLZ8yuNXNiK3kcZP8O5eCTj13bNOimdQHtnDVocsm/k=; b=mo5fhX4cyhn5cqoAyHfFydtWXhx8h3SIkPBz9W5kpUc9MKJ3uPlwIXweTFGQ7XAqPK jAygT4yRT47aY9ezP1gACu4qqICGf9Hi7jqGMQY63Mkt3nhg67OFhHA6jxiU2SPZFl2a Ygtms4u1HuO2NXvGkuJPFR8GMvYfRI4QmIJ+AOyqvrnO3RloDmpuHnN96ZFnmqVhKyRd lWBIFHZG28i3t8MRSRDHbIKoH4pC6CnTELbo4vV4eu6v8kQMuBqaTYkxYehsAKvD+/Cx RhXogPrPu0AYjq4LpfgMl2JxBF8/nCMzNEVE5Lyjat+He7o9sOwuDytLUihf9QnpplYR Hhng== X-Gm-Message-State: ALyK8tJp5FGjQ8uJ5ZUj6iIQouGFQJdbott2viwpHCq5qgP1kgR9/R3wil18vzLmS2avMc+ZU3fmlL1oUCwb/RzY X-Received: by 10.28.54.147 with SMTP id y19mr17632229wmh.68.1468231152837; Mon, 11 Jul 2016 02:59:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.54.164 with HTTP; Mon, 11 Jul 2016 02:58:43 -0700 (PDT) From: Surinder Kumar Date: Mon, 11 Jul 2016 15:28:43 +0530 Message-ID: Subject: [pgAdmin4][Patch]: RM#1420 - Reverse engineered SQL incomplete for Databases To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a1143110650d7e1053759343d X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1143110650d7e1053759343d Content-Type: multipart/alternative; boundary=001a1143110650d7df053759343b --001a1143110650d7df053759343b Content-Type: text/plain; charset=UTF-8 Hi Please find attached patch with fix and review. Included missing Create and Drop comments in generated sql query. Thanks, Surinder Kumar --001a1143110650d7df053759343b Content-Type: text/html; charset=UTF-8
Hi

Please find attached patch with fix and review.
Included missing Create and Drop comments in generated sql query.

Thanks,
Surinder Kumar
--001a1143110650d7df053759343b-- --001a1143110650d7e1053759343d Content-Type: application/octet-stream; name="RM#1420.patch" Content-Disposition: attachment; filename="RM#1420.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iqhux50l0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9fX2luaXRfXy5weSBiL3dlYi9wZ2FkbWlu L2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9fX2lu aXRfXy5weQppbmRleCAxZjdmZDA3Li4wOGI2ODJkIDEwMDY0NAotLS0gYS93 ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRh YmFzZXMvX19pbml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL19faW5pdF9fLnB5CkBA IC04NjAsOCArODYwLDE2IEBAIGNsYXNzIERhdGFiYXNlVmlldyhQR0NoaWxk Tm9kZVZpZXcpOgogICAgICAgICBmcm10ZF92YXJpYWJsZXMgPSBwYXJzZV92 YXJpYWJsZXNfZnJvbV9kYihyZXMxWydyb3dzJ10pCiAgICAgICAgIHJlc3Vs dC51cGRhdGUoZnJtdGRfdmFyaWFibGVzKQoKKyAgICAgICAgc3FsX2hlYWRl ciA9ICIiIgorLS0gRGF0YWJhc2U6IHswfQorCistLSBEUk9QIERBVEFCQVNF IHswfTsKKworIiIiLmZvcm1hdChyZXN1bHRbJ25hbWUnXSkKKwogICAgICAg ICBTUUwgPSBzZWxmLmdldF9uZXdfc3FsKGdpZCwgc2lkLCByZXN1bHQsIGRp ZCkKICAgICAgICAgU1FMID0gcmUuc3ViKCdcbnsyLH0nLCAnXG5cbicsIFNR TCkKKyAgICAgICAgU1FMID0gc3FsX2hlYWRlciArIFNRTAogICAgICAgICBT UUwgPSBTUUwuc3RyaXAoJ1xuJykKICAgICAgICAgcmV0dXJuIGFqYXhfcmVz cG9uc2UocmVzcG9uc2U9U1FMKQoK --001a1143110650d7e1053759343d Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a1143110650d7e1053759343d--