Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnIau-0002Oq-7Z for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Sep 2016 05:00:16 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bnIat-0007fQ-QN for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Sep 2016 05:00:15 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bnIag-0007OS-C5 for pgadmin-hackers@postgresql.org; Fri, 23 Sep 2016 05:00:02 +0000 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bnIad-0002I7-4Z for pgadmin-hackers@postgresql.org; Fri, 23 Sep 2016 05:00:01 +0000 Received: by mail-wm0-x22c.google.com with SMTP id l132so8803068wmf.0 for ; Thu, 22 Sep 2016 21:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=FkykM6bi0r4Q6tENhSrbrcjpO5TkbvbbCIR989oR4jw=; b=SkcCGbWQcyYIBfuRXRIc5xJJU2bPq0jrgqKC0W69jw0wcVonPUM1O7iZ1EuAwdVp8L 8t9cclDpfwyvnevms/CWt2sjChi6ACIDfAD6gPTBJspBgwzazeOu+nXLRwrLSdwva7S9 m4HyQ8NbL2JDlox/cMkY1TmcbTgLS2p3AjFIjgespoJLAIy5RitswyTN5kvxV7SP1nvy s2QpvdSsd+nHcYN8HCTULqD8SEsdTrHLrvX29TO10TY3ZUcm28VZBJo6XzcBq9pAq1WL opJbrpAKmekv9qiLUxJokG0Sv+P2zmk6xUWRtpBAXSAuUZH1uph5f95ibcq5rMWRL6DE N6iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FkykM6bi0r4Q6tENhSrbrcjpO5TkbvbbCIR989oR4jw=; b=HUd5vnqAgNzq/oL3meh2l3YZSEjT5uyVifv9r1Bvkigu+yY8RLCiKWw1jkpr2aIYlx ekil3dErrRr9yCgBbOGBSDgk6UfBS/2Ckkl6yyqSfYQia0bZMD7G8jrs7YE2Y4ZN9OyN 56zLzlOhWJMBRDTX+83BXqiHWfmb6IYtZ3ePTBMTImib1xS4arMjgNnF304m4eLDO9Nd 8bl6jrekCZDkik8h/q8cIxGbWR1LgadtSyrg+hhzWlb2jWN1IZ+/frMWBr3kt4X4zwcz skNwIAfx9J2YGAxnfQ6DuDtkCFRFRc8tbhiZat0WAu2mYJ7CQBztZGCWqb2FyowZU9UG fM0w== X-Gm-Message-State: AA6/9RkeOa52d+0bql4L54BuU5qvmqInf47cLoIOiczqmb69IQn9Y61xcCq4n9SDEdjtjU/ExmH13Ynk8irGbh2K X-Received: by 10.28.142.197 with SMTP id q188mr809520wmd.119.1474606796975; Thu, 22 Sep 2016 21:59:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Thu, 22 Sep 2016 21:59:26 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Fri, 23 Sep 2016 10:29:26 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1143d598514781053d25a644 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1143d598514781053d25a644 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =E2=80=8BActually It doesn't broke anywhere, instead It runs successfully. = On debugging I found that it runs the subprocess.Popen() utility but it doesn't run internally the pg_dump utitliy. On running the same command on windows cmd prompt it works. Then on setting parameters close_fds=3DFalse and cmd_shell=3DTrue, It works= . I ran backup in Google Chrome. On Thu, Sep 22, 2016 at 6:35 PM, Dave Page wrote: > Can you explain what was broken exactly please? Backups work fine for > me without the patch - and whilst they also work with it, I now get an > ugly command shell window flash up which I didn't before. > > On Wed, Sep 21, 2016 at 11:48 AM, Surinder Kumar > wrote: > > Hi > > > > While working on RM1391 I found another issue 'Backup is not working on > > windows". > > > > The reason is that the process executor which uses subprocess Popen() t= o > > execute job fails when we pass close_fds=3DTrue and shell=3DFalse in wi= ndows. > > > > Now we are settings close_fds=3DFalse and shell=3DTrue to fix it. These > settings > > are specific to windows only. > > > > Please review the attached patch. > > > > > > Thanks, > > Surinder Kumar > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a1143d598514781053d25a644 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
=E2= =80=8BActually It doesn't broke anywhere, instead It runs successfully.= On debugging I found that it runs the subprocess.Popen() utility but it do= esn't run internally the pg_dump utitliy. On running the same command o= n windows cmd prompt it works.
Then on setting parameters close_fds=3DFalse and cmd_shell= =3DTrue, It works.
I ran backup in Google Chrome.


On Thu, Sep 22, 2016 at 6:35 PM, Dave Page <dpage@pgad= min.org> wrote:
Can you exp= lain what was broken exactly please? Backups work fine for
me without the patch - and whilst they also work with it, I now get an
ugly command shell window flash up which I didn't before.

On Wed, Sep 21, 2016 at 11:48 AM, Surinder Kumar
<surinder.kumar@enter= prisedb.com> wrote:
> Hi
>
> While working on RM1391 I found another issue 'Backup is not worki= ng on
> windows".
>
> The reason is that the process executor which uses subprocess Popen() = to
> execute job fails when we pass close_fds=3DTrue and shell=3DFalse in w= indows.
>
> Now we are settings close_fds=3DFalse and shell=3DTrue to fix it. Thes= e settings
> are specific to windows only.
>
> Please review the attached patch.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadm= in-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a1143d598514781053d25a644--