Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bWgFF-000112-53 for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Aug 2016 08:49:13 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bWgFE-0005jU-NS for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Aug 2016 08:49:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bWgF1-0005GG-5U for pgadmin-hackers@postgresql.org; Mon, 08 Aug 2016 08:48:59 +0000 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bWgEy-0004nO-4J for pgadmin-hackers@postgresql.org; Mon, 08 Aug 2016 08:48:58 +0000 Received: by mail-wm0-x230.google.com with SMTP id i5so123454343wmg.0 for ; Mon, 08 Aug 2016 01:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=SZvxJAn+Hf0tu1OzcZHRlkJt4pZctbp9odeSNLYW2O0=; b=MOchbn5ArSf7s1Y7sSnlnLSx2pDgzRs5LTb9AjwJe/R2boDXaNkRUaKuXiFGAMD/3S FLzI9ZyvPAuwCQ2a6MdZgTJe5qkxV0TYM03tg4qpJ8o+n+dAab9WJlfjI8sIDZ6QpTQa BPwtuPFrB2sP4AEV/sULQrGA3+BOaN9/vE9m29Cj0V73DWeAXibhmbWMwVlOPxo03rZY ZzfY053BEAr1iSv/3ksT5QXHWaygZFcgSnjszfHu3kpF6Kn4xsR8L66GXJr6A53o0aDh 8zs3Q8HQIR4HoffxnjLmq6lYfnXDwW7dzjfw6UZFaf3CN7RsZEnDZw3WGnPe8A4N8fhf SXkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=SZvxJAn+Hf0tu1OzcZHRlkJt4pZctbp9odeSNLYW2O0=; b=gs13KUPCWjBPc8DXrVFvLSSKTnOafEn/U2gqhJw7bFtI1dbHJ6i79o7glR/v6wDEbA ad2zeQvXH3UybqlLZnEaPUALli/1B6qz+mvSIYcrJWB1d1vDhVFIDuBzQfvxGzSBo3h8 +wqPnJgmOgFXtxYvYyvNssa02EMcMExrZrdBuYgWrM0YRwmaxw/1LJR9+3VfUSc+659E QYx7FVOZd0TuNmNqvVp5x8BvviSmUJhuPREOe3MXvtPXifuW1OiVAXskkzt1VmVNd8iM IuBp1YN2lAISWkFmDhbW52YDvcOZ98Zhvc1JQXRNJEb9aamGez15cwu1hUDvNN6POHnJ Y5Bg== X-Gm-Message-State: AEkoousYk2ukI0CjH+wmFupbgEntQcmxvdvt8VzrBJ9yet0jDWXas10G41KZZ+IA8PD58bnB8tyMc0kuHz1tkS+z X-Received: by 10.28.148.21 with SMTP id w21mr15584411wmd.50.1470646134929; Mon, 08 Aug 2016 01:48:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.167.81 with HTTP; Mon, 8 Aug 2016 01:48:24 -0700 (PDT) From: Surinder Kumar Date: Mon, 8 Aug 2016 14:18:24 +0530 Message-ID: Subject: [pgAdmin4][Patch]: RM1119 - Add proper validations in fields before processing To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a114b65dc76b4b705398b7c05 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114b65dc76b4b705398b7c05 Content-Type: multipart/alternative; boundary=001a114b65dc76b4b205398b7c03 --001a114b65dc76b4b205398b7c03 Content-Type: text/plain; charset=UTF-8 Hi Issues fixed: 1) Add proper validation checks for fields. 2) Fixed wrong sql generation due to incorrect conditions in template. Please find attached patch and review. Thanks, Surinder Kumar --001a114b65dc76b4b205398b7c03 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

Issues fixed:
1) Add proper validation c= hecks for fields.
2) Fixed wrong sql generation due to incorrect conditions in template.

Please find attached patch= and review.


Thanks,
Surinder Kumar

--001a114b65dc76b4b205398b7c03-- --001a114b65dc76b4b705398b7c05 Content-Type: application/octet-stream; name="RM1119.patch" Content-Disposition: attachment; filename="RM1119.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_irlsp7b80 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3NlcXVlbmNlcy90ZW1wbGF0 ZXMvc2VxdWVuY2UvanMvc2VxdWVuY2UuanMgYi93ZWIvcGdhZG1pbi9icm93 c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy9z ZXF1ZW5jZXMvdGVtcGxhdGVzL3NlcXVlbmNlL2pzL3NlcXVlbmNlLmpzCmlu ZGV4IDQ3NGY4NDkuLmFhZDc2YjQgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWlu L2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hl bWFzL3NlcXVlbmNlcy90ZW1wbGF0ZXMvc2VxdWVuY2UvanMvc2VxdWVuY2Uu anMKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3Nl cnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvc2VxdWVuY2VzL3RlbXBsYXRlcy9z ZXF1ZW5jZS9qcy9zZXF1ZW5jZS5qcwpAQCAtMTQ2LDcgKzE0Niw4IEBAIGZ1 bmN0aW9uKCQsIF8sIFMsIHBnQWRtaW4sIHBnQnJvd3NlciwgYWxlcnRpZnkp IHsKICAgICAgICAgICBtb2RlOiBbJ3Byb3BlcnRpZXMnLCAnY3JlYXRlJywg J2VkaXQnXQogICAgICAgICB9LHsKICAgICAgICAgICBpZDogJ2luY3JlbWVu dCcsIGxhYmVsOiAne3sgXygnSW5jcmVtZW50JykgfX0nLCB0eXBlOiAnaW50 JywKLSAgICAgICAgICBtb2RlOiBbJ3Byb3BlcnRpZXMnLCAnY3JlYXRlJywg J2VkaXQnXSwgZ3JvdXA6ICd7eyBfKCdEZWZpbml0aW9uJykgfX0nCisgICAg ICAgICAgbW9kZTogWydwcm9wZXJ0aWVzJywgJ2NyZWF0ZScsICdlZGl0J10s IGdyb3VwOiAne3sgXygnRGVmaW5pdGlvbicpIH19JywKKyAgICAgICAgICBt aW46IDEKICAgICAgICAgfSx7CiAgICAgICAgICAgaWQ6ICdzdGFydCcsIGxh YmVsOiAne3sgXygnU3RhcnQnKSB9fScsIHR5cGU6ICdpbnQnLAogICAgICAg ICAgIG1vZGU6IFsnY3JlYXRlJ10sIGdyb3VwOiAne3sgXygnRGVmaW5pdGlv bicpIH19JwpAQCAtMTYxLDcgKzE2Miw4IEBAIGZ1bmN0aW9uKCQsIF8sIFMs IHBnQWRtaW4sIHBnQnJvd3NlciwgYWxlcnRpZnkpIHsKICAgICAgICAgICBt b2RlOiBbJ3Byb3BlcnRpZXMnLCAnY3JlYXRlJywgJ2VkaXQnXSwgZ3JvdXA6 ICd7eyBfKCdEZWZpbml0aW9uJykgfX0nCiAgICAgICAgIH0sewogICAgICAg ICAgIGlkOiAnY2FjaGUnLCBsYWJlbDogJ3t7IF8oJ0NhY2hlJykgfX0nLCB0 eXBlOiAnaW50JywKLSAgICAgICAgICBtb2RlOiBbJ3Byb3BlcnRpZXMnLCAn Y3JlYXRlJywgJ2VkaXQnXSwgZ3JvdXA6ICd7eyBfKCdEZWZpbml0aW9uJykg fX0nCisgICAgICAgICAgbW9kZTogWydwcm9wZXJ0aWVzJywgJ2NyZWF0ZScs ICdlZGl0J10sIGdyb3VwOiAne3sgXygnRGVmaW5pdGlvbicpIH19JywKKyAg ICAgICAgICBtaW46IDEKICAgICAgICAgfSx7CiAgICAgICAgICAgaWQ6ICdj eWNsZWQnLCBsYWJlbDogJ3t7IF8oJ0N5Y2xlZCcpIH19JywgdHlwZTogJ3N3 aXRjaCcsCiAgICAgICAgICAgbW9kZTogWydwcm9wZXJ0aWVzJywgJ2NyZWF0 ZScsICdlZGl0J10sIGdyb3VwOiAne3sgXygnRGVmaW5pdGlvbicpIH19JywK QEAgLTE5MywxMSArMTk1LDEyIEBAIGZ1bmN0aW9uKCQsIF8sIFMsIHBnQWRt aW4sIHBnQnJvd3NlciwgYWxlcnRpZnkpIHsKICAgICAgICAgICogdGhlIEdV SSBmb3IgdGhlIHJlc3BlY3RpdmUgY29udHJvbC4KICAgICAgICAgICovCiAg ICAgICAgIHZhbGlkYXRlOiBmdW5jdGlvbigpIHsKLSAgICAgICAgICB2YXIg bXNnID0gdW5kZWZpbmVkOworICAgICAgICAgIHZhciBtc2cgPSB1bmRlZmlu ZWQsCisgICAgICAgICAgICAgIG1pbmltdW0gPSB0aGlzLmdldCgnbWluaW11 bScpLAorICAgICAgICAgICAgICBtYXhpbXVtID0gdGhpcy5nZXQoJ21heGlt dW0nKTsKKyAgICAgICAgICAgICAgc3RhcnQgPSB0aGlzLmdldCgnc3RhcnQn KTsKICAgICAgICAgICAvLyBDbGVhciBhbnkgZXhpc3RpbmcgZXJyb3IgbXNn LgotICAgICAgICAgIHRoaXMuZXJyb3JNb2RlbC51bnNldCgnbmFtZScpOwot ICAgICAgICAgIHRoaXMuZXJyb3JNb2RlbC51bnNldCgnc2Vxb3duZXInKTsK LSAgICAgICAgICB0aGlzLmVycm9yTW9kZWwudW5zZXQoJ3NjaGVtYScpOwor ICAgICAgICAgIHRoaXMuZXJyb3JNb2RlbC5jbGVhcigpOwoKICAgICAgICAg ICBpZiAoXy5pc1VuZGVmaW5lZCh0aGlzLmdldCgnbmFtZScpKQogICAgICAg ICAgICAgICB8fCBTdHJpbmcodGhpcy5nZXQoJ25hbWUnKSkucmVwbGFjZSgv XlxzK3xccyskL2csICcnKSA9PSAnJykgewpAQCAtMjE5LDYgKzIyMiwyNiBA QCBmdW5jdGlvbigkLCBfLCBTLCBwZ0FkbWluLCBwZ0Jyb3dzZXIsIGFsZXJ0 aWZ5KSB7CiAgICAgICAgICAgICB0aGlzLmVycm9yTW9kZWwuc2V0KCdzY2hl bWEnLCBtc2cpOwogICAgICAgICAgICAgcmV0dXJuIG1zZzsKICAgICAgICAg ICB9CisKKyAgICAgICAgICB2YXIgbWluX2x0ID0gJ3t7IF8oJ21pbmltdW0g dmFsdWUgbXVzdCBiZSBsZXNzIHRoYW4gbWF4aW11bSB2YWx1ZS4nKSB9fScs CisgICAgICAgICAgICAgIHN0YXJ0X2x0ID0gJ3t7IF8oJ3N0YXJ0IHZhbHVl IGNhbm5vdCBiZSBsZXNzIHRoYW4gbWluaW11bSB2YWx1ZS4nKSB9fScsCisg ICAgICAgICAgICAgIHN0YXJ0X2d0ID0gJ3t7IF8oJ3N0YXJ0IHZhbHVlIGNh bm5vdCBiZSBncmVhdGVyIHRoYW4gbWF4aW11bSB2YWx1ZS4nKSB9fSc7Cisg ICAgICAgICAgaWYgKChtaW5pbXVtID09IDAgJiYgbWF4aW11bSA9PSAwKSB8 fAorICAgICAgICAgICAgICAocGFyc2VJbnQobWluaW11bSwgMTApID49IHBh cnNlSW50KG1heGltdW0sIDEwKSkpIHsKKyAgICAgICAgICAgIG1zZyA9IG1p bl9sdAorICAgICAgICAgICAgdGhpcy5lcnJvck1vZGVsLnNldCgnbWluaW11 bScsIG1zZyk7CisgICAgICAgICAgICByZXR1cm4gbXNnOworICAgICAgICAg IH0KKyAgICAgICAgICBlbHNlIGlmIChzdGFydCA8IG1pbmltdW0pIHsKKyAg ICAgICAgICAgIG1zZyA9IHN0YXJ0X2x0CisgICAgICAgICAgICB0aGlzLmVy cm9yTW9kZWwuc2V0KCdzdGFydCcsIG1zZyk7CisgICAgICAgICAgICByZXR1 cm4gbXNnOworICAgICAgICAgIH0KKyAgICAgICAgICBlbHNlIGlmIChzdGFy dCA+IG1heGltdW0pIHsKKyAgICAgICAgICAgIG1zZyA9IHN0YXJ0X2d0Cisg ICAgICAgICAgICB0aGlzLmVycm9yTW9kZWwuc2V0KCdzdGFydCcsIG1zZyk7 CisgICAgICAgICAgICByZXR1cm4gbXNnOworICAgICAgICAgIH0KICAgICAg ICAgICByZXR1cm4gbnVsbDsKICAgICAgICAgfQogICAgICAgfSkKZGlmZiAt LWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2 ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3NlcXVlbmNlcy90ZW1wbGF0ZXMvc2Vx dWVuY2Uvc3FsLzkuMV9wbHVzL2NyZWF0ZS5zcWwgYi93ZWIvcGdhZG1pbi9i cm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1h cy9zZXF1ZW5jZXMvdGVtcGxhdGVzL3NlcXVlbmNlL3NxbC85LjFfcGx1cy9j cmVhdGUuc3FsCmluZGV4IDIzYWMxZjMuLjA0NDRhMGQgMTAwNjQ0Ci0tLSBh L3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2Rh dGFiYXNlcy9zY2hlbWFzL3NlcXVlbmNlcy90ZW1wbGF0ZXMvc2VxdWVuY2Uv c3FsLzkuMV9wbHVzL2NyZWF0ZS5zcWwKKysrIGIvd2ViL3BnYWRtaW4vYnJv d3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMv c2VxdWVuY2VzL3RlbXBsYXRlcy9zZXF1ZW5jZS9zcWwvOS4xX3BsdXMvY3Jl YXRlLnNxbApAQCAtMywxNCArMywxNiBAQCBDUkVBVEUgU0VRVUVOQ0Uge3sg Y29ubnxxdElkZW50KGRhdGEuc2NoZW1hKSB9fS57eyBjb25ufHF0SWRlbnQo ZGF0YS5uYW1lKSB9fQogeyUgaWYgZGF0YS5jeWNsZWQgYW5kIGRhdGEuY3lj bGVkID09IFRydWUgJX0KICAgICBDWUNMRQogeyUgZW5kaWYgJX0KLXslIGlm IGRhdGEuaW5jcmVtZW50ICV9Cit7JSBpZiBkYXRhLmluY3JlbWVudCBpcyBk ZWZpbmVkICV9CiAgICAgSU5DUkVNRU5UIHt7ZGF0YS5pbmNyZW1lbnR9fQot eyUgZW5kaWYgJX17JSBpZiBkYXRhLnN0YXJ0ICV9Cit7JSBlbmRpZiAlfXsl IGlmIGRhdGEuc3RhcnQgaXMgZGVmaW5lZCAlfQogICAgIFNUQVJUIHt7ZGF0 YS5zdGFydH19Ci17JSBlbmRpZiAlfXslIGlmIGRhdGEubWluaW11bSAlfQor eyUgZWxpZiBkYXRhLmN1cnJlbnRfdmFsdWUgaXMgZGVmaW5lZCAlfQorICAg IFNUQVJUIHt7ZGF0YS5jdXJyZW50X3ZhbHVlfX0KK3slIGVuZGlmICV9eyUg aWYgZGF0YS5taW5pbXVtIGlzIGRlZmluZWQgJX0KICAgICBNSU5WQUxVRSB7 e2RhdGEubWluaW11bX19Ci17JSBlbmRpZiAlfXslIGlmIGRhdGEubWF4aW11 bSAlfQoreyUgZW5kaWYgJX17JSBpZiBkYXRhLm1heGltdW0gaXMgZGVmaW5l ZCAlfQogICAgIE1BWFZBTFVFIHt7ZGF0YS5tYXhpbXVtfX0KLXslIGVuZGlm ICV9eyUgaWYgZGF0YS5jYWNoZSAlfQoreyUgZW5kaWYgJX17JSBpZiBkYXRh LmNhY2hlIGlzIGRlZmluZWQgJX0KICAgICBDQUNIRSB7e2RhdGEuY2FjaGV9 fXslIGVuZGlmICV9OwoteyUgZW5kaWYgJX0KXCBObyBuZXdsaW5lIGF0IGVu ZCBvZiBmaWxlCit7JSBlbmRpZiAlfQo= --001a114b65dc76b4b705398b7c05 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a114b65dc76b4b705398b7c05--