Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l95MB-00069B-00 for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Feb 2021 12:09:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l95M7-0005ch-7I for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Feb 2021 12:09:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l95M7-0005cO-0P for pgadmin-hackers@lists.postgresql.org; Mon, 08 Feb 2021 12:09:27 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l95Ly-0003n9-6S for pgadmin-hackers@postgresql.org; Mon, 08 Feb 2021 12:09:25 +0000 Received: by mail-lj1-x230.google.com with SMTP id c18so16628623ljd.9 for ; Mon, 08 Feb 2021 04:09:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s1kSzYOJILQDukOmPpXpzNcSKL3PHiJu3wK/pI3pCHg=; b=MP2XlKPADLjJS9KF1Y7z7cn6XxkElUKRkKihe8vjsd2OvbQcX5dZfo5K9tAU5Ia7Oy wTI16t5Cb1EKJ/URi5H76fLKE/8ChOZ+FL46elhFQQ/GotM3KoeG6azvPQJvN2WQuj1/ buBDrPquyEYJIEc4qdLxUsSzUZF7QcBn8RahI0QemFUlnKbXhGttnKGz7ra5AHwaSCrQ HZAMAf3OeQuJfoHhJuQbRi9moqkf6m2518QH+pfUszrCeTWTkIdZJB8ZII6nkVuC7Ot2 pMNKNueQEgW6Tf4JwYkNrGJKXYFGwsN3vsUQibRtLEftAHNU843pvh0jsSXmxzuLVCSy iTUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s1kSzYOJILQDukOmPpXpzNcSKL3PHiJu3wK/pI3pCHg=; b=dL/ZvNpELsF3GszRLgtZKh4g7dBr5rBrsh30bPc6U85GlCKfgLx0ghyhDsloQ3EY63 ECEioxwxRyVMi2j5hwhdXdQcY3xr1W23tBjl1nrokqsH0QFPrm0O40bW5lPiCwmiI3pj fegygJn+YNOobiMcn01xiz3ImzkkEW8fS0iWId9cr2OAyxxifihK47naRCk5RX87+Q7S DndVEDV2OI0adqpAb/UmCIRZaf8/FrQx0gn8Rt1OFJCqdBQQRkpQnIGI/6PYEuwNg6TQ okMWR1+kYeJi535cm3/zy29jrlPyNXnzFr0VPP7wlE7iXSM9TQpR8OmtGZNRJa9SI1an hNOg== X-Gm-Message-State: AOAM533gCQ2gY4RNlF0DUldvb4r56kBc95PpDGj6zHvNUAloNzg2jGaS ucIQXU1J9ny3IVnyW+g1kRjG/QgGuAJlXD3shsffKGqOjHFm5+2mOgDjK7CX3Is9hGdpryh9TKw pZ4XzYAlwroALxfbnN8uIu3JwqxNtJQqtI/E+QSxLcsCZbmXgzKpm94eEDgZ4cGjvfUHBFiI7S4 w8+OPfTYEV6Nu5Ae+c7lKzf8qFdXXMuBAGbZGoM1Stu1AGcMnwzIenE4IuaA== X-Google-Smtp-Source: ABdhPJxd45ZcsO+Q7ZXZILtxwGsOJiMMPoptRRDkVXjgF3gNCYPbb0WdAZ+0vVk+PXlnIeuKZEkLpSoS/u8B20HCusU= X-Received: by 2002:a2e:9c8e:: with SMTP id x14mr9235343lji.83.1612786156887; Mon, 08 Feb 2021 04:09:16 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Mon, 8 Feb 2021 17:38:40 +0530 Message-ID: Subject: Re: [pgAdmin][RM5091] Option to hide Statistics, Dependencies, Dependants tab To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000fb208205bad209b9" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000fb208205bad209b9 Content-Type: multipart/alternative; boundary="000000000000fb208005bad209b7" --000000000000fb208005bad209b7 Content-Type: text/plain; charset="UTF-8" Hi, The changes for not calling the ajax until the panel is focused were missed in the last patch. Please review the attached. On Wed, Feb 3, 2021 at 1:00 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Feb 2, 2021 at 5:44 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached patch will allow closing Statistics, Dependencies, Dependants >> tabs. The tabs can be added back by right clicking on the tab strip and >> selecting "Add panel", similar to that of Dashboard. >> Changes are also made to make sure statistics, dependencies, dependants >> are fetched only when they're visible, to avoid unnecessary ajax calls. >> >> Please review. >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --000000000000fb208005bad209b7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

The changes for not calling the ajax until the panel i= s focused were missed in the last patch. Please review the attached.
<= /div>
O= n Wed, Feb 3, 2021 at 1:00 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
=
Thanks, = patch applied.

On Tue, Feb 2, 2021 at 5:44 PM Aditya Toshniwal <aditya.to= shniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch will al= low closing=C2=A0Statistics, Dependencies, Dependants tabs. The tabs can be= added back=C2=A0by right clicking on the tab strip and selecting "Add= panel", similar to that of Dashboard.
Changes are also made to make sure statistics, dependencies, depen= dants are fetched only when they're visible, to avoid unnecessary ajax call= s.

=
Please review.=

--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2= =A0| S= r. Software Engineer | edbpostgr= es.com
<= font face=3D"arial, sans-serif">"Don't Complain about Heat, Plant = a TREE"
<= /div>


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Softwa= re Engineer | edbpostgres.com<= /font>
"Don't Complain about Heat, Plant a TREE&qu= ot;
--000000000000fb208005bad209b7-- --000000000000fb208205bad209b9 Content-Type: application/octet-stream; name="RM5091.part2.patch" Content-Disposition: attachment; filename="RM5091.part2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kkwj7o5y0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL3BhbmVsLmpzIGIvd2Vi L3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvanMvcGFuZWwuanMKaW5kZXggZGE3Y2IyYWRiLi5iZjll ODc0Y2UgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL3BhbmVsLmpz CisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL3BhbmVsLmpzCkBAIC0yMDAsOSAr MjAwLDkgQEAgZGVmaW5lKAogCiAgICAgICAgIGlmIChldmVudE5hbWUgPT0gJ3BhbmVsQ2xvc2Vk JykgewogICAgICAgICAgIC8qIFBhc3MgdGhlIGNsb3NlZCBmbGFnIGFsc28gKi8KLSAgICAgICAg ICBtb2R1bGUudG9nZ2xlVmlzaWJpbGl0eS5jYWxsKG1vZHVsZSwgW2ZhbHNlLCB0cnVlXSk7Cisg ICAgICAgICAgbW9kdWxlLnRvZ2dsZVZpc2liaWxpdHkuY2FsbChtb2R1bGUsIGZhbHNlLCB0cnVl KTsKICAgICAgICAgfSBlbHNlIGlmIChldmVudE5hbWUgPT0gJ3BhbmVsVmlzaWJpbGl0eUNoYW5n ZWQnKSB7Ci0gICAgICAgICAgbW9kdWxlLnRvZ2dsZVZpc2liaWxpdHkuY2FsbChtb2R1bGUsIFtw Z0Jyb3dzZXIuZG9ja2VyLmZpbmRQYW5lbHModGhpcy5fdHlwZSlbMF0uaXNWaXNpYmxlKCldKTsK KyAgICAgICAgICBtb2R1bGUudG9nZ2xlVmlzaWJpbGl0eS5jYWxsKG1vZHVsZSwgcGdCcm93c2Vy LmRvY2tlci5maW5kUGFuZWxzKHRoaXMuX3R5cGUpWzBdLmlzVmlzaWJsZSgpLCBmYWxzZSk7CiAg ICAgICAgIH0KICAgICAgIH0sCiAK --000000000000fb208205bad209b9--