Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbiex-0001eY-1j for pgadmin-hackers@arkaria.postgresql.org; Fri, 14 Jun 2019 09:38:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hbiev-0007JR-T5 for pgadmin-hackers@arkaria.postgresql.org; Fri, 14 Jun 2019 09:38:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbiev-0007JK-HT for pgadmin-hackers@lists.postgresql.org; Fri, 14 Jun 2019 09:38:09 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbies-0001ly-2q for pgadmin-hackers@postgresql.org; Fri, 14 Jun 2019 09:38:08 +0000 Received: by mail-lj1-x243.google.com with SMTP id s21so1686418lji.8 for ; Fri, 14 Jun 2019 02:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Arm2k2QMd7fXTxQCRUg7MsuoWEVD40O66xCaluIIh2I=; b=MB1lQIsddEMSk9rGUDCi6KnkSJEjyd/0JqbQWLDe00ViBQixLrJILQlm+HdI5PWVHM Tro8w8AEI9OL2+trWVhdaaWSq5tvNNirTUBvyvRMJBGFbS/csikohtai9ol0LMNpLCO2 c7qlZG66QyPWHaFMtL1JWu+Xw65BcCqsHvvGfDglr7DdIhpkuMXA6c+cH60LirAKwLKM sGhxccSAKcfdGfX9rC59/4hMYHVa7TZWTgzvyhjsXfM0VQXLOAH8qvuQtbMhS4GxCA3B tzKxtiPcXUl+udXiApFCrSNFPrm1avi+SFe4tpTeMfPhiPUWYIuLP2LMJb7fcdB8Bw+5 PmvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Arm2k2QMd7fXTxQCRUg7MsuoWEVD40O66xCaluIIh2I=; b=p/Q3TnhQRAsOqQekAa8DuzZGOCEx3oQTGFD/6P43m94KSagfj/r8BXHA6HIGTzwgG2 kGUbD7KGnG7EGDEqmYMwABuWV830E8Y2OE3jdOJoxZQgLVS0d6IvhRJjy7FfZ9QbG38N VvDmSMJC7ub3kbUHs/PFC7Y/9GOHmNvDMTd2F2c+pB0SU0DRHN98OyE0Jxw+I7ujzRTn ahHGy+fqlCRYpnAPjgpc0oXR/Xj5jQkpCZ9srpXj/1TyIQayYaERZE/3fnwvpOa25Rid ZG/bpir1GyKdmEJZ6lsckGMSBg6U3EbJRiUSa3hiCtu/u4CcrDbNzNokQg2QlNFryEqm nJtw== X-Gm-Message-State: APjAAAWUpGD05XE3bo8hLlzfBdJbZNvwS8pcLv591zRjWWsL1hHOyc4h PyjvSt437ROFGfqy8GeFN5WMlavUdc7sKqO/jrHkUaY0 X-Google-Smtp-Source: APXvYqyYodz0OkilsGFLXLl8dnhFmwpXD2sRLMuWB1uzXQ/OqAmf6i83AXfJliyhK8y2aXfHS5aV9P21Fh82X6gip1M= X-Received: by 2002:a2e:9d4e:: with SMTP id y14mr22015862ljj.199.1560505084597; Fri, 14 Jun 2019 02:38:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Fri, 14 Jun 2019 15:07:28 +0530 Message-ID: Subject: Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000003d0863058b4567a6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000003d0863058b4567a6 Content-Type: multipart/alternative; boundary="0000000000003d0860058b4567a4" --0000000000003d0860058b4567a4 Content-Type: text/plain; charset="UTF-8" Hi Hackers, I have missed a line while implementing this. Attached is the patch to fix that. Although it has not caused any trouble, but still it should be changed. Kindly review. On Mon, Jun 10, 2019 at 7:28 PM Dave Page wrote: > Thanks, patch applied. > > On Mon, Jun 10, 2019 at 1:58 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the updated patch with fixes. >> >> On Mon, Jun 10, 2019 at 12:58 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> Following are the review comments: >>> >>> - "Set breakpoint" option not working, when click it throws an error. >>> >>> Fixed. >> >>> >>> - Create an empty function and try to debug that. It should show >>> proper error message. >>> >>> This seems to be a bug in the debugger itself. I'll raise a bug with >> simulation steps if it is. But, not sure where to raise. >> >>> >>> - Got the following backend error when closing the connection, >>> please fix this: >>> - File >>> "E:\Projects\pgadmin4\web\pgadmin\tools\debugger\__init__.py", line 2053, >>> in close_debugger_session >>> conn_id=dbg_obj['exe_conn_id']) >>> >>> Fixed. >> >>> >>> On Fri, Jun 7, 2019 at 12:21 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the patch for debugger improvements. The changes include: >>>> 1) Change the way debug info is stored in session. Removed redundant >>>> session related code in debugger code. All the session related handling >>>> done at one place. >>>> 2) Fixed a bug where debugger was not opening for EPAS package function. >>>> 3) If a package is defined without body and we try to debug a >>>> proc/func, the debugger opened a blank window. Changes made so that it will >>>> throw error as "XYZ is not defined in package body." >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --0000000000003d0860058b4567a4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

I have missed a line while implementing this. = Attached is the patch to fix that.
Although it has not caused any trouble,= but still it should be changed.
Kindly review.

On Mon, Jun 10, 2019= at 7:28 PM Dave Page <dpage@pgadmi= n.org> wrote:
Thanks, patch applied.

On Mon, Jun 10, 2019 at 1:58 PM= Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the updated patch with fixes.
=
On Mon= , Jun 10, 2019 at 12:58 PM Akshay Joshi <akshay.joshi@enterprisedb.com> w= rote:
Hi=C2=A0Aditya

Following are the review comment= s:
  • "Set breakpoint" option not working, when cl= ick it throws an error.
Fixed.= =C2=A0
  • Create an empty function and try to debug that. It should = show proper error message.
This seems to= be a bug in the debugger itself. I'll raise a bug with simulation step= s if it is. But, not sure where to raise.
  • Got the foll= owing backend error when closing the connection, please fix this:
      • <= li>=C2=A0 =C2=A0 File "E:\Projects\pgadmin4\web\pgadmin\tools\debugger= \__init__.py", line 2053, in close_debugger_session
      =C2=A0 =C2=A0 c= onn_id=3Ddbg_obj['exe_conn_id'])
Fixed.=C2=A0

= On Fri, Jun 7, 2019 at 12:21 PM Aditya Toshniwal <aditya.toshniwal@enterpris= edb.com> wrote:
Hi Ha= ckers,

Attached is the patch for debugger i= mprovements. The changes include:
1) Change the way debug info is stored in session. Removed redund= ant session related code in debugger code. All the session related handling= done at one place.
2) F= ixed a bug where debugger was not opening for EPAS package function.
<= div>3) If a package is defined without b= ody and we try to debug a proc/func, the debugger opened a blank window. Ch= anges made so that it will throw error as "XYZ is not defined in packa= ge body."

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards=
Akshay Jos= hi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mob= ile: +91 976-788-8246


--
Thanks and Regards= ,
Aditya Toshniwal
Software E= ngineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a= TREE"


--
Dave Page
Blog: http://pgsnake.blog= spot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company


--
Adi= tya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"
--0000000000003d0860058b4567a4-- --0000000000003d0863058b4567a6 Content-Type: application/octet-stream; name="RM4329_v2.part2.patch" Content-Disposition: attachment; filename="RM4329_v2.part2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwvwedyv0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2RlYnVnZ2VyL19faW5pdF9fLnB5IGIvd2Vi L3BnYWRtaW4vdG9vbHMvZGVidWdnZXIvX19pbml0X18ucHkKaW5kZXggYmFiZDFlZmEuLjlhMDFh YzMyIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi90b29scy9kZWJ1Z2dlci9fX2luaXRfXy5weQor KysgYi93ZWIvcGdhZG1pbi90b29scy9kZWJ1Z2dlci9fX2luaXRfXy5weQpAQCAtNTY4LDcgKzU2 OCw3IEBAIGRlZiBkaXJlY3RfbmV3KHRyYW5zX2lkKToKICAgICB1c2VyX2FnZW50ID0gVXNlckFn ZW50KHJlcXVlc3QuaGVhZGVycy5nZXQoJ1VzZXItQWdlbnQnKSkKIAogICAgIGZ1bmN0aW9uX2Fy Z3VtZW50cyA9ICcoJwotICAgIGlmICdmdW5jdGlvbkRhdGEnIGluIHNlc3Npb246CisgICAgaWYg ZGVfaW5zdC5mdW5jdGlvbl9kYXRhIGlzIG5vdCBOb25lOgogICAgICAgICBpZiAnYXJnc19uYW1l JyBpbiBkZV9pbnN0LmZ1bmN0aW9uX2RhdGEgYW5kIFwKICAgICAgICAgICAgIGRlX2luc3QuZnVu Y3Rpb25fZGF0YVsnYXJnc19uYW1lJ10gaXMgbm90IE5vbmUgYW5kIFwKICAgICAgICAgICAgICAg ICBkZV9pbnN0LmZ1bmN0aW9uX2RhdGFbJ2FyZ3NfbmFtZSddICE9ICcnOgo= --0000000000003d0863058b4567a6--