Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqZw4-00078w-I6 for pgadmin-hackers@arkaria.postgresql.org; Mon, 04 Feb 2019 08:49:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gqZw1-0005sS-Gc for pgadmin-hackers@arkaria.postgresql.org; Mon, 04 Feb 2019 08:48:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqZw1-0005sL-9s for pgadmin-hackers@lists.postgresql.org; Mon, 04 Feb 2019 08:48:57 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqZvv-0004bt-95 for pgadmin-hackers@postgresql.org; Mon, 04 Feb 2019 08:48:56 +0000 Received: by mail-lj1-x241.google.com with SMTP id u89-v6so10912343lje.1 for ; Mon, 04 Feb 2019 00:48:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wsEd4vdFoilR9qnJG7Sn2YrPtOhNpERJ05KG027zI1Q=; b=wKVszbOT9tGI+Wd42vG9yE//UJ1nPET8gEaZhsP4fy+ZcyUhaqPiXuIgT5rvcvjmvh Dfo2sVDxV1LCl1Nb9XUBOcd7JOCBbh8DnDiq5yNvQEu1Gj+yIfHiUYXSNpEXvcwbTr3e +1nJVGIYGX2akTVZe0VjNmyu9FFlKeerwGoSA1aiQdg7cWqb/BcKa5ZbNSrBzZ8nD7IL rQVhAXxVmhWCJRH1pYzA0OnflLprUtTejsg1cjGdx6j0RcLiLiCm3xmuHxqU0dXpYGpY o1DB5grMOfN51EZYqnOr5MlsgpNN63EnWY7+IIJf4XHlVyjlGIFFyhaL12tWyRIo6Czk czTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wsEd4vdFoilR9qnJG7Sn2YrPtOhNpERJ05KG027zI1Q=; b=YwCkbjOkn8nRvtWkQLPbGUvt/qmIWTuXG96Fwn5t9I981EF9w6gutWHnOKCcq1hcIo ZPEclVrfAxwHLesoby9IE7pVL4tGfdSAXQ4e/xDl2PEifKXhtyjTlNRkmER60xYLepq3 Cwg+myGCrfnXcWmfrlEz3ncZIdIM6cQ+j/IEFwPpK5/bP2YuJDI5M69RIQB6qJj9QNkc rx2akG0GDJsxahvUnax1rIZvQ7w/ZGbOj+JnQaz5K3f0irI/2MJ8s1AkMIlTh5fr3oS4 VLrtEfrjd/YduGQ1GHipnVDiNRzxTfuLUP9rBMGLyoS71neNZmejlXkRX0LRbRZtqSHh chGg== X-Gm-Message-State: AJcUukddXaVBPQsGBL9X27/uFJJZSsTN7eOHPtUd0hYHnr9dBGkMttrL HNFHla0+epH/jYbhgUMLqwkpgjQTNSdsQaUfFr9mQQ== X-Google-Smtp-Source: ALg8bN54jO+Jxl1IxX0mZR7hK0QcLj5Ap6Tzw9SjnQK1ccupD9gv3RS3an4bKVXEs8oQ532NpPV/IAsJ5McrZzJpwv4= X-Received: by 2002:a2e:9d17:: with SMTP id t23-v6mr31321664lji.57.1549270129607; Mon, 04 Feb 2019 00:48:49 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Mon, 4 Feb 2019 14:18:37 +0530 Message-ID: Subject: Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000bcbb8305810d8fba" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000bcbb8305810d8fba Content-Type: text/plain; charset="UTF-8" Hi Akshay, I tried to simulate, but no luck. It works on my system :( On Wed, Jan 30, 2019 at 7:15 PM Akshay Joshi wrote: > Hi Aditya > > I have applied your patch but following test cases are failing > consistently: > > - CopySelectedQueryResultsFeatureTest > - QueryToolAutoCompleteFeatureTest > > I have verified your patch on Mac OSX and Ubuntu. Chrome Version > 71.0.3578.98 > > On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> >> >> On Tue, 29 Jan 2019, 19:09 Dave Page > >>> Akshay, can you look at this please? >>> >> >> Sure. >> >>> >>> On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal >>> wrote: >>> > >>> > Hi Hackers, >>> > >>> > Attached is the updated patch. I have changed fill_input_by_field_name >>> function to use javascript to set values of text boxes and the selector is >>> changed from xpath to CSS with a :not(:disabled) clause. With this, test >>> case will fail if tried to set the value of a disabled input. >>> > >>> > Kindly review. >>> > >>> > >>> > On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >> >>> >> >>> >> >>> >> On Mon, Jan 28, 2019 at 5:39 PM Dave Page wrote: >>> >>> >>> >>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal >>> >>> wrote: >>> >>> > >>> >>> > Hi Dave, >>> >>> > >>> >>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page >>> wrote: >>> >>> >> >>> >>> >> Hi >>> >>> >> >>> >>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal >>> >>> >> wrote: >>> >>> >> > >>> >>> >> > Hi Hackers, >>> >>> >> > >>> >>> >> > Attached is the patch to fix failing SQL editor related feature >>> tests. >>> >>> >> > The failure is occurring mostly because of send_keys function >>> of selenium which sometimes does not input the complete text. The change >>> will use Codemirror javascript object to set the text. >>> >>> >> > >>> >>> >> > I have also added new args flag "--modules" which can be used >>> after --pkg where you can test a specific module file under the pkg. This >>> is not so useful for build but definitely helpful for the developers. >>> >>> >> >>> >>> >> One of the most common failures I see is failure to fill in the >>> >>> >> details on the Add Server dialogue (it might type half of an >>> entry, >>> >>> >> then just hang). Should we get rid of all uses of send_keys? >>> >>> > >>> >>> > Setting the text using javascript executor can be done. send_keys >>> simulate an actual person, so if you try to set a disabled text box using >>> send_keys, it won't. Places where disabled fields doesn't matter, send_keys >>> can be removed. >>> >>> >>> >>> Can't we just do something like: >>> >>> >>> >>> if input.disabled == false: >>> >>> input.value = 'Foo'; >>> >>> else: >>> >>> raise exception .... >>> >> >>> >> I'll check if this can be done. Will get back. >>> >>> >>> >>> >>> >>> -- >>> >>> Dave Page >>> >>> Blog: http://pgsnake.blogspot.com >>> >>> Twitter: @pgsnake >>> >>> >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> >>> The Enterprise PostgreSQL Company >>> >> >>> >> >>> >> >>> >> -- >>> >> Thanks and Regards, >>> >> Aditya Toshniwal >>> >> Software Engineer | EnterpriseDB Software Solutions | Pune >>> >> "Don't Complain about Heat, Plant a tree" >>> > >>> > >>> > >>> > -- >>> > Thanks and Regards, >>> > Aditya Toshniwal >>> > Software Engineer | EnterpriseDB Software Solutions | Pune >>> > "Don't Complain about Heat, Plant a tree" >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" --000000000000bcbb8305810d8fba Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,

I tried to simulate, but no luck. It works on m= y system :(

On Wed, Jan 30, 2019 at 7:15 PM Akshay Joshi <akshay.joshi@enterprisedb.com= > wrote:
Hi=C2=A0Aditya

I have applied your patch but following test cases are failing consis= tently:
  • CopySelectedQueryResultsFeatureTest
  • Query= ToolAutoCompleteFeatureTest
I have verified your patch on Mac = OSX and Ubuntu. Chrome=C2=A0Version 71.0.3578.98

On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi <akshay.joshi@enter= prisedb.com> wrote:


On Tue, 29 Jan 2019, 19:09 Dave Page <dpage@pgadmin.org wrote:
Akshay, can you look at this p= lease?

=C2=A0 =C2=A0 Sure.

On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal
<aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the updated patch. I have changed fill_input_by_field_name= function to use javascript to set values of text boxes and the selector is= changed from xpath to CSS with a :not(:disabled) clause. With this, test c= ase will fail if tried to set the value of a disabled input.
>
> Kindly review.
>
>
> On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal <ad= itya.toshniwal@enterprisedb.com> wrote:
>>
>>
>>
>> On Mon, Jan 28, 2019 at 5:39 PM Dave Page <dpage@pgadmin.org= > wrote:
>>>
>>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal
>>> <aditya.toshniwal@enterprisedb.com>= wrote:
>>> >
>>> > Hi Dave,
>>> >
>>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page <dpage@pgadmi= n.org> wrote:
>>> >>
>>> >> Hi
>>> >>
>>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal
>>> >> <aditya.toshniwal@enterprisedb.com<= /a>> wrote:
>>> >> >
>>> >> > Hi Hackers,
>>> >> >
>>> >> > Attached is the patch to fix failing SQL editor = related feature tests.
>>> >> > The failure is occurring mostly because of send_= keys function of selenium which sometimes does not input the complete text.= The change will use Codemirror javascript object to set the text.
>>> >> >
>>> >> > I have also added new args flag "--modules&= quot; which can be used after --pkg where you can test a specific module fi= le under the pkg. This is not so useful for build but definitely helpful fo= r the developers.
>>> >>
>>> >> One of the most common failures I see is failure to f= ill in the
>>> >> details on the Add Server dialogue (it might type hal= f of an entry,
>>> >> then just hang). Should we get rid of all uses of sen= d_keys?
>>> >
>>> > Setting the text using javascript executor can be done. s= end_keys simulate an actual person,=C2=A0 so if you try to set a disabled t= ext box using send_keys, it won't. Places where disabled fields doesn&#= 39;t matter, send_keys can be removed.
>>>
>>> Can't we just do something like:
>>>
>>> if input.disabled =3D=3D false:
>>>=C2=A0 =C2=A0input.value =3D 'Foo';
>>> else:
>>>=C2=A0 =C2=A0raise exception ....
>>
>> I'll check if this can be done. Will get back.
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Akshay Joshi
Sr. Software Architect
<= div>

Phone: +91 20-3058-9517
Mobi= le: +91 976-788-8246


--
Thanks and Rega= rds,
Aditya Toshniwa= l
Softw= are Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
&q= uot;Don't Complain about Heat, Plant a tree"
--000000000000bcbb8305810d8fba--