Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gfMFq-0004Hm-Dx for pgadmin-hackers@arkaria.postgresql.org; Fri, 04 Jan 2019 09:59:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gfMFp-0001L8-5q for pgadmin-hackers@arkaria.postgresql.org; Fri, 04 Jan 2019 09:59:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gfMFp-0001L1-0B for pgadmin-hackers@lists.postgresql.org; Fri, 04 Jan 2019 09:59:01 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gfMFl-00081K-Se for pgadmin-hackers@lists.postgresql.org; Fri, 04 Jan 2019 09:59:00 +0000 Received: by mail-lj1-x243.google.com with SMTP id t18-v6so31995293ljd.4 for ; Fri, 04 Jan 2019 01:58:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CIDpf/pzPggp00nMYsurICj9aMo0xP2S8NMJyixAMWg=; b=EsbQt/vmSyM1CEsj3Ed3MmGmAOa2HmMrsuFsQ3rjeAihhCEr30+cY2fyYZOqd6C3AC 4pOw8DNrOO7xhXjRNetnTIfIMenSbT49TU+icLWEVP/ZG/+mJ4Ia1G2ZeJ+v/dstKsJO NVCIW6O0Z78v9l5DoztGtdk+P1kwhw7ndqn8dS3jLtZOjv9aIoBuH3cGZFPwyTawSYAw Tgv6jIV/uoc9lTF2a60icYyD9GZyPJEsk7vAS8XJrKHYTBrTBJpNz24ED3NCIX3Eo+qV P+x1J/Y9J7iQder3ut5J12b7itUIb3TQsaLqyQIcBc43wOTqvfgGlOaKad3VJbYtbNQL QO1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CIDpf/pzPggp00nMYsurICj9aMo0xP2S8NMJyixAMWg=; b=I4Zuh36OaGOpBv/y79UzzZjpNMsb7D9VD1+1VDbir6xDb7zOEuRNrHd+GpTa8UE4mI /eMQiqtNPODDmSz8ocs2k/Z336YF8D50rvWQ5/XsaTUzxqL/TJ9eEnfRX9yCUdRzGFgA XPrN02dynCoVgjJg+hTdpLammvPQepAnd0gjPLapC/BQAkAkr5ph7gsIYAQ2mGTTAt/6 33LyaBMG5ubUG1x++hVOk29FhoPgJFwovCzmkx9aD2q0k5cCLTm8eDXPdKMYTWiWLTp/ fFH7fEZchAi7ZPeTAdPzJFUUiScgJn39BWdqeKIeqk4yDgPXiP0xe1S79pI8dRpp0H7e UfVg== X-Gm-Message-State: AJcUukeM3Mo+bLxOaUn6WcN/pX/0H40KY/8Uw1j+mKy5BxemTjWU7T9h uQ58G7u4ni+wDVnNASZaaABQjf1pi/nGzUT7zo28yQ== X-Google-Smtp-Source: AFSGD/WowCo8EYqXAYo1VMjJ5DOysN6oO247uFM6HgEEIlx2+1fxvL4kr8qpxSXi0GB2f+lRyQCgjfKj9GcOllMY79s= X-Received: by 2002:a2e:b04f:: with SMTP id d15-v6mr31738258ljl.3.1546595936302; Fri, 04 Jan 2019 01:58:56 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Fri, 4 Jan 2019 15:28:45 +0530 Message-ID: Subject: Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000065326a057e9eedd0" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000065326a057e9eedd0 Content-Type: text/plain; charset="UTF-8" Hi, On Fri, Jan 4, 2019 at 2:53 PM Dave Page wrote: > Hi > > On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Thu, Jan 3, 2019 at 8:39 PM Dave Page wrote: >> >>> >>> A few other things that I noticed (or have been bugging me): >>> >>> - The menu bar seems a little cramped. Taking pg-navbar from 32 to 40px >>> and setting the font-weight to normal on the menu options (but not the >>> product name) seems much better to me (and adjusting everything else as >>> required of course). >>> >> Giving too much space for the navbar will reduce the usable space for >> other things. It is good enough(32) to be used easily, and is equal to all >> the other headers in app (including tabs) giving a feel of native desktop >> application. You'll find even smaller menu heights in native desktop >> application. We can make font weight to normal and may be slightly >> increase horizontal spacing between the menu links. >> > > 8 pixels isn't going to make a noticeable difference to the workspace for > users, and would leave the bar smaller than the 50px it's been for the last > couple of years (iirc). I think it needs it to avoid looking cramped - > please make the change. > Will do. One more doubt regarding bold headers, should I remove bold headers in dashboard graph header, subnode headers (eg.table->columns), properties tab accrordian headers ? > > >> >>> - In the file dialogue, the column headers don't line up with the >>> columns in the rows. >>> >> I could not see this on my machine (screenshot attached). Could you >> please share the screenshot. >> > > Attached - thanks! This is Chrome 70.0.3538.102 on MacOS. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" --00000000000065326a057e9eedd0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

=
On Fri, Jan 4, 2019 at 2:53 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

=
On Fri, Jan 4, 2019 at 4:51 AM = Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
=
Hi Dave,
=
On Thu, Jan 3, 2019 at 8:39= PM Dave Page <dp= age@pgadmin.org> wrote:

<= div>A few other things that I noticed (or have been bugging me):
=
- The menu bar seems a little cramped. Taking pg-navbar from= 32 to 40px and setting the font-weight to normal on the menu options (but = not the product name) seems much better to me (and adjusting everything els= e as required of course).
Giving too much sp= ace for the navbar will reduce the usable space for other things. It is goo= d enough(32) to be used easily, and is equal to all the other headers in ap= p (including tabs) giving a feel of native desktop application. You'll = find even smaller menu heights in native desktop application.=C2=A0<= span class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">We ca= n make font weight to normal and may be slightly increase horizontal spacin= g between the menu links.

8 pixels isn't going to make a noticeable difference to the wor= kspace for users, and would leave the bar smaller than the 50px it's be= en for the last couple of years (iirc). I think it needs it to avoid lookin= g cramped - please make the change.
Will do.=
One more doubt regarding bold headers, should I remove bold h= eaders in dashboard graph header, subnode headers (eg.table->columns), p= roperties tab accrordian headers ?
=C2= =A0

- In the= file dialogue, the column headers don't line up with the columns in th= e rows.
I could not see this on my machine (= screenshot attached). Could you please share the screenshot.=C2=A0

Attached - thanks! This is= Chrome=C2=A070.0.3538.102 on MacOS.
=C2= =A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnak= e

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compa= ny


--
Thanks and Rega= rds,
Aditya Toshniwa= l
Softw= are Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
&q= uot;Don't Complain about Heat, Plant a tree"
--00000000000065326a057e9eedd0--