Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldtj8-0003Qi-Qj for pgadmin-hackers@arkaria.postgresql.org; Tue, 04 May 2021 12:00:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ldtj7-0007rZ-Pa for pgadmin-hackers@arkaria.postgresql.org; Tue, 04 May 2021 12:00:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldtj7-0007rS-FT for pgadmin-hackers@lists.postgresql.org; Tue, 04 May 2021 12:00:33 +0000 Received: from mail-vk1-xa2c.google.com ([2607:f8b0:4864:20::a2c]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ldtj4-000510-Hp for pgadmin-hackers@postgresql.org; Tue, 04 May 2021 12:00:32 +0000 Received: by mail-vk1-xa2c.google.com with SMTP id x4so1928472vkx.5 for ; Tue, 04 May 2021 05:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OiMfgB8Otx3MynDP3/xX9NDDsXuwmQFZUmXa0pO4aQM=; b=rmWUiYL3cBGDqB70TVJAinRW+IG26n3+SpXRjx6r6pX6l+MnuW9e1BF8/yR5BAW7nQ p7Waq7dW7yB/1LlDWiLzYMDN2zGxfME38TxCjSbYGq85V4ShDdx+LOnVN+s/Xmc09Z8c 1O3WF+qedlLGkJliNMM871mACSVo/XvUm8vkqGNaNYdDaGOCPHTBZaQwBeSjm80hO2nw Wij8pAss3D0OQuT+r+5BWtXbq3aGiKQnvgTUGrq5Ik9lAXfZ+FcJSIv1GghyrsOU2QE1 uSrsJSb4VfUy8tdwqNJ0blCBjfSDG7HAfqTrXjUJF5kTRr36wlQmER6xLaiTF5jB/wb/ /pVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OiMfgB8Otx3MynDP3/xX9NDDsXuwmQFZUmXa0pO4aQM=; b=kFeWGOD+yxE/HkKPDgcVZlLxBkG4Kvo5bnmo+a6ESTdcVL3ztAyElsBJZLJgv8Dmqk QVUkprgwc0RFWY91klyp9jv2p4rYOQo35myl39hmVUUwfGlJQwoqvytCnat4qSEjxBaW +AdX7YNN9BxP7NXkpIaRsUPRvl804Z/ARZtti4DslZDdqCnVtswcJD5EIVCJnOowGkfH ul3VMtqfMwJD78DUoqWa13kuo1SRMV4uioWfeE1n9poyNn66q9gXwuJ7Mq6KZ1mJpQl0 gQT4YVwfqUgyuh/uoAowKLr/AT5ybOYToaNER9hP8qmJ4HrJGO/2WmqIHGdwu8Lk26HQ TEWg== X-Gm-Message-State: AOAM532ybaoHcX7B+BucS5yg4TN/Hej81UHe9HF2DXhexqkPWtN/IpiN CcHb2W6BjmDbm2w3vWNnMGGIpAI8jHzIDpNjopz3u3EOZ2RWjluZh9p0Z/Tm5WAMucnlFKMSDUC EUN408DDm/Bk3N16UWlqALKT2M3az8T1ibjp7VWU0544nwFDZpjpzv+EqM8VFQFhjYrYwvBS1Lv VXVL64ZyflOVxTD0ZvF2bF47pyAbHNEYMopBMmonNpB/HLnxl2bvhi5+HNvA== X-Google-Smtp-Source: ABdhPJw2Si2bVnvbemqTM0piDUMV/7k/rJBwZbSsaGH5Zf1tza62xWJTRZekj29TROUsD/xXmUhTyPs68+/sDF35pxk= X-Received: by 2002:a1f:978e:: with SMTP id z136mr4293793vkd.17.1620129628766; Tue, 04 May 2021 05:00:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Tue, 4 May 2021 17:29:52 +0530 Message-ID: Subject: Re: [pgAdmin4] Update require.js library to latest version To: Akshay Joshi Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000035cf205c17fd309" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000035cf205c17fd309 Content-Type: text/plain; charset="UTF-8" Hi Akshay, Since we're using it from the vendor directory, please yarn remove requirejs to remove it from the package.json file. Other than that, the patch looks good to me. On Tue, May 4, 2021 at 5:08 PM Akshay Joshi wrote: > Hi Aditya, > > Can you please review it? > > On Tue, May 4, 2021 at 2:07 PM Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to update the require.js library to the latest version. >> >> -- >> Regards, >> Murtuza Zabuawala >> *EDB* >> *POWER TO POSTGRES* >> https://www.edbpostgres.com >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --000000000000035cf205c17fd309 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,

Since we're using it from = the vendor directory, please yarn remove re= quirejs=C2=A0to remove it from th= e package.json file.
Other than that, the patch looks good to me.

On Tue, May 4, 2021 at 5:08 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi A= ditya,

Can you please review it?

On Tue, May 4, 202= 1 at 2:07 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> = wrote:
Hi,

PF= A patch to update the require.js library to the latest version.

=
--<= /font>
Re= gards,
Murtuza Zabuawala
EDB
POWER TO POSTGRES
=


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Softwa= re Engineer | edbpostgres.com<= /font>
"Don't Complain about Heat, Plant a TREE&qu= ot;
--000000000000035cf205c17fd309--