Re: Regarding feature #642 - Aditya Toshniwal

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: Nikhil Mohite <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Khushboo Vashi <[email protected]>
Subject: Re: Regarding feature #642
Date: Wed, 13 Sep 2023 11:24:09 +0530
Message-ID: <CAM9w-_=CiAwW=4jJ5EeqbXDY==QA3neiXuM+9CNLPdLQwdBtRg@mail.gmail.com> (raw)
In-Reply-To: <CAOBg0AOGLy8N3vJ6djoTbx-un1=bkLE2Mxky=CcS+4ngRbxDrg@mail.gmail.com>
References: <CAOBg0AOydmU39TRpsFXettfYDTRw8Nug_wYc6wEx7gTKO62PFg@mail.gmail.com>
	<CAFOhELdw008jGZO+3tfVFYuh2LZcY=fe08A328t-UH4Nbfu+bA@mail.gmail.com>
	<CAOBg0AOGLy8N3vJ6djoTbx-un1=bkLE2Mxky=CcS+4ngRbxDrg@mail.gmail.com>

Hi Nikhil,

It looks good to me. I have few suggestions here:
1. Can we remove the grey background for selected nodes?
2. Can/Should we add a label next to collections like - Tables (Selected:
3), d1 (Selected: 8), and when schema is selected then d1 (Selected:
schema)?
3. We can have a three state checkbox for schema level checkbox. - empty,
partial (select all child nodes) and full (schema selected).

Let me know what you think.

On Wed, Sep 13, 2023 at 11:06 AM Nikhil Mohite <
[email protected]> wrote:

> Hi Hackers,
>
> I have implemented feature #642 as follows.
> 1. If the user selects the schema node from the tree, it will use
> *--schema* to take a backup of that schema. (This is only when the user
> selects the schema node)
> [image: image.png]
> 2. If a user selects a few nodes from the tree, like tables it will
> partially select the schema node and it will use the *--table* to take a
> backup of the selected nodes.
> [image: image.png]
> 3. If the user selects all children of a schema but not the schema node
> then it will partially select the schema node and will use the *--table *to
> take a backup of the selected nodes.
> [image: image.png]
>
>
> Please let me know if you have any questions/ suggestions.
>
>
> On Tue, Jul 4, 2023 at 10:30 AM Khushboo Vashi <
> [email protected]> wrote:
>
>>
>>
>> On Mon, Jul 3, 2023 at 6:16 PM Nikhil Mohite <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> I am currently working on #642
>>> <https://github.com/pgadmin-org/pgadmin4/issues/642; to allow to
>>> selection/deselect of objects under the object backup operation.
>>>
>>> This will be only applicable to the database and its sub-nodes(Not for
>>> Backup Global and Backup server)
>>>
>>> Details:
>>>
>>>    1. Added a new tab in the backup dialog '*Objects*'
>>>    2. On the '*Objects*' tab it will list down all the schemas and
>>>    tables under the selected database.
>>>    3. [image: image.png]
>>>
>>> The second tab name (Data/Objects) should be changed because the last
>> tab is named Objects.
>>
>>>
>>>    1.
>>>    2. If the user selects the specific Schema then it will list down
>>>    only tables under the selected schema.
>>>    3. [image: Screenshot 2023-07-03 at 4.38.26 PM copy.png]
>>>    4. By default, all the nodes from the tree will be selected and the
>>>    user can deselect them if required.
>>>
>>> +1
>>
>>>
>>>    1. If the user de-selects all the nodes and took a backup it will
>>>    take a normal backup and all other nodes will get included in the backup.
>>>
>>> Then, selecting all the tree objects by default will make no sense.
>>
>>> Questions:
>>>
>>>    1. pgAdmin III use to support taking backup of tables only from the
>>>    UI, a user was not able to select views, materialized views, foreign
>>>    tables, and sequences from the backup dialog. (If the user selects all from
>>>    the checkbox on the UI then other database objects are included implicitly
>>>    in the backup)
>>>    2. Should we continue with the above behavior or should we now allow
>>>    the user to select these database objects in the backup dialog?
>>>
>>>
>>> Please let me know your suggestions/thoughts.
>>>
>>>
>>> --
>>> *Thanks & Regards,*
>>> *Nikhil Mohite*
>>> *Senior Software Engineer.*
>>> *EDB Postgres* <https://www.enterprisedb.com/;
>>> *Mob.No: +91-7798364578.*
>>>
>>
>  Regards,
> Nikhil Mohite
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [image/png] image.png (104.0K, 3-image.png)
  download | view image

  [image/png] Screenshot 2023-07-03 at 4.38.26 PM copy.png (90.1K, 4-Screenshot%202023-07-03%20at%204.38.26%20PM%20copy.png)
  download | view image

  [image/png] image.png (157.2K, 5-image.png)
  download | view image

  [image/png] image.png (154.6K, 6-image.png)
  download | view image

  [image/png] image.png (156.6K, 7-image.png)
  download | view image

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Regarding feature #642
  In-Reply-To: <CAM9w-_=CiAwW=4jJ5EeqbXDY==QA3neiXuM+9CNLPdLQwdBtRg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox