Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hgM4v-0002a2-Iz for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Jun 2019 04:32:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hgM4s-0001qq-NR for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Jun 2019 04:32:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hgM4s-0001qi-DP for pgadmin-hackers@lists.postgresql.org; Thu, 27 Jun 2019 04:32:06 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hgM4p-0000kK-D2 for pgadmin-hackers@postgresql.org; Thu, 27 Jun 2019 04:32:04 +0000 Received: by mail-lj1-x241.google.com with SMTP id a21so836078ljh.7 for ; Wed, 26 Jun 2019 21:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C6LCN+h3pjXVDC8tcagNAmbE0TvG7MMKkr4lb4PySVk=; b=zNF/Gk4ZV5wm8tF04abK4LD2pObrTDyplz1vGydfPRgjxxQcow4I5OLPUvpansl7bX HC3ZesNZGvFHZ0VcEQ2TeP9sAxzbOG8T3poAdiHrjgclva4jMJBuZqPmMl576imMFB8A IuvfssJhg/TyF8ebGfgSBJk6aE+wAhMUIPrOk0s8PfEIebnYNkTnl84hRFwb1nvC6EFL ae7NVuk8YRnU9KvFD6hdQT9ttndY4GkAPoOnr0ntyqlmo0ATjt1QQ3JaEKiBT0Iv+QKC u1F2uiPKJ4j9MBj56/OHVCwb7kgV5mawnAQXlIR4N9V5gkAFJYedV3+oHhhAWMfo2vim UxvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C6LCN+h3pjXVDC8tcagNAmbE0TvG7MMKkr4lb4PySVk=; b=NJusGYsWTvdYLZ+3EepQnHUoWCZPopIMw8sTlIoX/2PLUZOVnlWqyDSun7VzR5yA4s RX1lAzWOmW2gRTSdUTnSol2a4Sf9rb2qUgevyZeaCPK0x7w3u+OrtTsa8tIa36ikfjZa FmY5A6dHylwMqDcR3/iXiQYSEKrZx/IrlttDn+3ii0Te2cfL02NGN2wZ/nwZ6K2CP9q1 MNxbVbDFu7d53TrDjmSNmq7VWcEhdmr2K97Qo9MQCr/dPobwLnS0g3h0GAHhdvoczIHz Qp/DylrDmGw+jT9d1iBJfPJ7jC6Ep3iTWCS6YuyubA4ZiacFXOAVPtpcCvHIrkEKKcoa 1YRA== X-Gm-Message-State: APjAAAVLwWdj9qYLCIkcAQezE0o/jSI/pWUaardTwvxGWwVyh1TS+Omp U6lJD8i2sgTtoquwLGylE8X11p4B71DKlAXqilyMSQ== X-Google-Smtp-Source: APXvYqw5BxY3Onm1ILbVsQVgMt9RPow0e5sU3OKVvz2nsxaApXlKlObNx6iFnVMnZlzdt5kr9NlI8w+gwmPrT+OuPSo= X-Received: by 2002:a2e:970d:: with SMTP id r13mr1153829lji.126.1561609920992; Wed, 26 Jun 2019 21:32:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Thu, 27 Jun 2019 10:01:24 +0530 Message-ID: Subject: Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000009e6e51058c46a44a" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009e6e51058c46a44a Content-Type: text/plain; charset="UTF-8" Hi, On Wed, Jun 26, 2019 at 8:22 PM Dave Page wrote: > Hi > > Something isn't working correctly - I turned on the summary option, and > this is the query that was run when I hit the EXPLAIN button: > > EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING > False,SUMMARY False,BUFFERS False) select * from pg_tables > > Aside from the formatting (s/True/true, s/False/false, missing spaces > etc), shouldn't it say SUMMARY true? I've cleared the browser and bundle > caches, rebundled etc. > I think I misunderstood the documents - https://www.postgresql.org/docs/12/sql-explain.html. Few of the parameters are applicable only to EXPLAIN ANALYSE and not to EXPLAIN. Will make the changes, along with formatting to existing codes as well. > > Shouldn't there also be documentation updates? > Yeah. (I always miss that :/) > > On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to add support for SETTINGS(v12+) and SUMMARY(v10+) >> explain options. These options will be visible only if version is supported. >> >> I have also created and fixed RM4395. The explain options changed on one >> query tool should not change explain options on other query tools or >> preferences. The initial values will be taken from preferences are usual. >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --0000000000009e6e51058c46a44a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

=
On Wed, Jun 26, 2019 at 8:22 PM Dave = Page <dpage@pgadmin.org> wro= te:
Hi

Something isn't working correctly - I turned= on the summary option, and this is the query that was run when I hit the E= XPLAIN button:

EXPLAIN (FORMAT JSON,ANALYZE False,= VERBOSE False,COSTS False,TIMING False,SUMMARY False,BUFFERS False) select = * from pg_tables

Aside from = the formatting (s/True/true, s/False/false, missing spaces etc), shouldn= 9;t it say SUMMARY true? I've cleared the browser and bundle caches, re= bundled etc.
I think I misunderstood the documents= -=C2=A0https://www.postgresql.org/docs/12/sql-explain.html. Few of the paramet= ers are applicable only to EXPLAIN ANALYSE and not to EXPLAIN. Will make th= e changes, along with formatting to existing codes as well.=C2=A0
=
Shouldn't there also be documentation updates?
Yeah. (I always miss that :/)=C2=A0

On Wed, Jun 26, 2019 at 7:59 AM Aditya Tos= hniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to add support for SETTINGS(v12+)= and SUMMARY(v10+) explain options. These options will be visible only if v= ersion is supported.
I have also created an= d fixed RM4395. The explain options changed on one query tool should not ch= ange explain options on other query tools or preferences. The initial value= s will be taken from preferences are usual.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0En= terpriseDB India |=C2=A0Pune=
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogs= pot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
= The Enterprise PostgreSQL Company


--
Adi= tya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"
--0000000000009e6e51058c46a44a--