Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiHTp-0003Um-1K for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 12:01:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hiHTn-0005gm-Is for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 12:01:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiHTn-0005ge-3u for pgadmin-hackers@lists.postgresql.org; Tue, 02 Jul 2019 12:01:47 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiHTf-0001lO-NQ for pgadmin-hackers@postgresql.org; Tue, 02 Jul 2019 12:01:45 +0000 Received: by mail-lj1-x244.google.com with SMTP id k18so16572453ljc.11 for ; Tue, 02 Jul 2019 05:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x+J5OZZlB66yt3XV4bPxXHvheiTmoXQg/l8kcLSzAZY=; b=x2Dg0VydJ9gFRJaQUn56lp3OqR23/Z96KPoxR0PdoZoUJXW1D1+TxKvkPcVHwsGY+v t0efdz19Svzd4D5qipQq4GAQ8zktFIdtYOssC5AEHiBZIbgn5XI1ilxEpi7H9xY2RX6k jyTNnaA7iCDJxFHFn4CRWZwF7vtJYLc9ImKlU1rztPqLy52QS/FMNczF59HRfc6D5MBI ba6JunxbZiO26H9o1PKXy3+lCnVbqJEbfUtcdZq4YLzoCbFGtUfckly+WVAomFpuljdP QGpU6OcsN0SDvhifX4QamC0SjMwnHqTuPidQx8GihudBZ40ZvpqUNT3Ez5GYDd4kihHR hIdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x+J5OZZlB66yt3XV4bPxXHvheiTmoXQg/l8kcLSzAZY=; b=JQOsTKblEEi01rbfCuAiPMSTxyI6TCY7GOvqkWF2j0fU2BciT39mSB78ywQ/7X2alL B+G/4get3+NnhX7BZ5EnBii9CBS/xX3OeeXw23cnPz87aC6nIcggdht/IB0/quTEkLjI Hu3XGwAUURqd8JykINRZ6QeqaHk+n4rtYzLbmQtZjBolJR08DV//wsaOK+zJLqye3LpX dOBCJVBBd/pVD1VmrEJo+RIXXZxK05BbfrxVyAHcZ7bmlXVgK0JZ6oQfGLZTX3o2+T1Z Qrht3wZAh1nC5JNcj44/dOa5RR4klG3FU1bInsE6RcldUJzenDh6AqNzfM6QIZXD4j84 iZtQ== X-Gm-Message-State: APjAAAVQ+rmk/kHg3fCqsogtM3ZSfb8Lu82F6E6mJsn3fVo7gsiMp8wB 6JCwxNrS3Sg0+EhWwo596Kr+in7WTojpm+zf4VJKdA== X-Google-Smtp-Source: APXvYqwwIVhJCsaSvUJvBdsLbycDOZFNPjCo1o96bMnsR/ExOGcGcN7aCRUiRezjzU2OMYJhXXOvgtHoglo0BKjN2XA= X-Received: by 2002:a2e:b003:: with SMTP id y3mr17424077ljk.72.1562068897783; Tue, 02 Jul 2019 05:01:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Tue, 2 Jul 2019 17:31:01 +0530 Message-ID: Subject: Re: pgAdmin4 v4.10 candidate builds To: Akshay Joshi Cc: Fahar Abbas , pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000c49577058cb1812f" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c49577058cb1812f Content-Type: multipart/alternative; boundary="000000000000c49575058cb1812d" --000000000000c49575058cb1812d Content-Type: text/plain; charset="UTF-8" Hi, The issue still persists. I have checked the code and found that CompareVersions(Version, '{#MyAppFullVersion}') = -1, this should be 1 and not -1. Attached is the patch. Sorry for trouble to build again. :/ On Tue, Jul 2, 2019 at 4:39 PM Akshay Joshi wrote: > Hi Fahar > > We have fixed RM #4421. Candidate builds and source can be found at > https://developer.pgadmin.org/builds/2019-07-02-1/ . > There is some problem with the wheel packages, will check that. Meanwhile > can you please test the builds for upgrade issue. > > On Tue, Jul 2, 2019 at 10:55 AM Fahar Abbas > wrote: > >> Hi, >> >> Here is the showstopper issue for pgadmin4 4.10: >> >> https://redmine.postgresql.org/issues/4421 >> >> Kind Regards, >> >> On Fri, Jun 28, 2019 at 8:21 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi All, >>> >>> Due to an showstopper issue found in pgAdmin v4.9, we will have to >>> release pgAdmin4 v4.10 early. Candidate builds and source can be found >>> at https://developer.pgadmin.org/builds/2019-06-28-1/ >>> >>> Fahar, can you please verify it for release on Tuesday (2nd July). >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Fahar Abbas >> QMG >> EnterpriseDB Corporation >> Phone Office: +92-51-835-8874 >> Phone Direct: +92-51-8466803 >> Mobile: +92-333-5409707 >> Skype ID: *live:fahar.abbas* >> Website: www.enterprisedb.com >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --000000000000c49575058cb1812d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

The issue stil= l persists. I have checked the code and found that CompareVersions(Version,= '{#MyAppFullVersion}') =3D -1, this should be 1 and not -1.<= span class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">
Attached is the patch.

Sorry for trouble to build again. :/=


On Tue, Jul 2, 2019 at 4:39 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wro= te:
Hi Fahar

We have fixed RM #4421. Candidate=C2=A0builds=C2=A0and source can be found at=C2=A0https://developer.pgadmin.org/builds/2019-07-02-1/=C2=A0.
T= here is some problem with the wheel packages, will check that. Meanwhile ca= n you please test the builds for upgrade issue.

On Tue, Jul 2, 2019 = at 10:55 AM Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi,

Here is the showstopper issue for pgadmin4 4.10:
=


On Fri, Jun 28, 2019 at 8:21 PM= Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All,
=
Due to an showstopper issue found in pgAdmin v4.9, we will h= ave to release pgAdmin4 v4.10 early. Candidate=C2=A0builds= =C2=A0and source can be found at=C2=A0https://developer.pgadmin.org/b= uilds/2019-06-28-1/

Fahar, can you please verify it for release on Tuesday (2nd July).
--
Thanks &am= p; Regards
Akshay Joshi
Sr. Software Architect
=
EnterpriseDB Software India Private L= imited
Mobile: +91 976-788-8246


--
Fahar Abbas
QMG
EnterpriseDB Corporation
Phone Office: +92-51-835-8= 874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID:= live:fahar.abbas
Website: www.enterprisedb.com


--
<= div>Thanks & Rega= rds
Akshay Joshi
Sr. Software Architect
=
EnterpriseDB Software India Private Limited<= /b>
Mobile: +91 976-788-8246
=


--
Adi= tya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"
--000000000000c49575058cb1812d-- --000000000000c49577058cb1812f Content-Type: application/octet-stream; name="win.ver_compare_v3.patch" Content-Disposition: attachment; filename="win.ver_compare_v3.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxlrgq5k0 ZGlmZiAtLWdpdCBhL3BrZy93aW4zMi9pbnN0YWxsZXIuaXNzLmluIGIvcGtnL3dpbjMyL2luc3Rh bGxlci5pc3MuaW4KaW5kZXggN2ZkYTViMGQuLjdkZWI5MjVmIDEwMDY0NAotLS0gYS9wa2cvd2lu MzIvaW5zdGFsbGVyLmlzcy5pbgorKysgYi9wa2cvd2luMzIvaW5zdGFsbGVyLmlzcy5pbgpAQCAt MTc5LDcgKzE3OSw3IEBAIGJlZ2luCiAgIGJlZ2luCiAJVXBncmFkZU1vZGUgOj0gVHJ1ZTsKICAg ICBSZWdRdWVyeVN0cmluZ1ZhbHVlKEhLRVlfTE9DQUxfTUFDSElORSwnU29mdHdhcmVceyNNeUFw cE5hbWV9XHsjTXlBcHBWZXJzaW9ufScsICdWZXJzaW9uJywgVmVyc2lvbik7Ci0gICAgaWYgQ29t cGFyZVZlcnNpb25zKFZlcnNpb24sICd7I015QXBwRnVsbFZlcnNpb259JykgPSAtMSB0aGVuCisg ICAgaWYgQ29tcGFyZVZlcnNpb25zKFZlcnNpb24sICd7I015QXBwRnVsbFZlcnNpb259JykgPSAx IHRoZW4KICAgICBiZWdpbgogICAgICAgTXNnQm94KEV4cGFuZENvbnN0YW50KCd7Y206TmV3ZXJW ZXJzaW9uRXhpc3RzfScgKyAnKHYnICsgVmVyc2lvbiArICcpIGlzIGFscmVhZHkgaW5zdGFsbGVk JyApLCBtYkluZm9ybWF0aW9uLCBNQl9PSyk7CiAgICAgICBSZXN1bHQgOj0gRmFsc2U7Cg== --000000000000c49577058cb1812f--