Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIqgx-00053W-La for pgadmin-hackers@arkaria.postgresql.org; Thu, 17 Sep 2020 09:59:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kIqgw-0001um-B0 for pgadmin-hackers@arkaria.postgresql.org; Thu, 17 Sep 2020 09:59:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIqgw-0001s8-1P for pgadmin-hackers@lists.postgresql.org; Thu, 17 Sep 2020 09:59:02 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kIqgs-0001EZ-8K for pgadmin-hackers@postgresql.org; Thu, 17 Sep 2020 09:59:01 +0000 Received: by mail-ej1-x634.google.com with SMTP id p9so2411574ejf.6 for ; Thu, 17 Sep 2020 02:58:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=ZP83GMF1ifIlKCwfhHhCR1+co4xB8nz4I6jXPDOf4w8=; b=W9SjFFDSNQkQuHqeddzKcJCQxeXTZv62KhJfEUyA8SoDPmIzWQW2TkbHtb4ztQ9qjX Nn47SNp6ubEBZlDQmhkUYQqAwo4E3JPE8HtRwDZirPmWsZ+vXTqmigmhrQiTa4S1C+lt fUihl2IDoZZC2a0ZilePWqABbJAS11G/fKN2eZpkivYLVKLKJ8xAxMUnyi5RGckk5K1i YHvkfrDRlTMjtizE1O3BXPX2ovlEHGw7fU3Q9fAfMONBokHlqVwPPZXyCExQDAyRdGgV 2Tnz/2/RXwSNUs4ksLKOU7EcaMd0LZBzunuvJuOKqVosckWdYCx+ebG4TCZ9QpY/eTYn R3dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ZP83GMF1ifIlKCwfhHhCR1+co4xB8nz4I6jXPDOf4w8=; b=i+NsHSWVFNM69xYbrURh+6Yg9fc5T+zwPuMqJLxDGr5sBYXMePdw4plSuml1zuEeDK vvssjIAXdyvu8AfcSIEIjAj7kwifONpo97y3o8yLmtVNaoSsHIdG/DJNCCYxtlg7VE+g XL8agu/4+PBh4Nu0CxtfLebgBbWUHmlTGHvjjX8JMUnh9a55q0DhJD4Ae38emF9CCo5E wWKALPPrsB4uU5ONSg5bMvR/m6uY+OMkK3HvMCQHEDFenqIlkNQJiDfz4P+LjI/r31xO v6ZRC7MGwS2QPXzvZIW5rsufS241bAKjtukPg7mVCOvzpV5jSn30cWJUjhlXQlp1i/K3 HLIQ== X-Gm-Message-State: AOAM533wxHHqjkqX0A3xdNcwrm2i18+XL8Rn1fIMg/blfsfZaVUE/qfX c7m+9fam4/fCDlh2hUSdGzxsD5LOd251tZWqU1UBJaQzgMVoVfnN5WN8USLkeeRDTGiNE0J0k7A Gk0N/u87Cc3JDDoM/AQ1z1JGLS5w08n3Us4ZNzd5Wzb/ubjQPLsXoMKu23eygPhQOq9gCSjOJc9 P2dFaPdPRPiYZ1B2blZceXaHb6V2bilLdTmNLg4MUnZBXIBW1uv9XaKmdRRwgKTHXM7A== X-Google-Smtp-Source: ABdhPJwm5KMMlp5awKt6cG95bs925I0EtEXVyTSUFiQ5b3A8Jsy2BMH4/EZAfqKv7pGvqbtp+0s6BsHoTCNc6WuBAWo= X-Received: by 2002:a17:906:a101:: with SMTP id t1mr29226600ejy.203.1600336736390; Thu, 17 Sep 2020 02:58:56 -0700 (PDT) MIME-Version: 1.0 From: Aditya Toshniwal Date: Thu, 17 Sep 2020 15:28:20 +0530 Message-ID: Subject: [pgAdmin][RM5807] Removed columns use modified name in generated script To: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000b2cd6905af7f6ef2" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b2cd6905af7f6ef2 Content-Type: multipart/alternative; boundary="000000000000b2cd6605af7f6ef0" --000000000000b2cd6605af7f6ef0 Content-Type: text/plain; charset="UTF-8" Hi Hackers, If a column is renamed and then removed, then drop SQL query takes the renamed column and not the original one. Attached is the patch to fix this issue. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --000000000000b2cd6605af7f6ef0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

If a column is renamed and then removed, then = drop SQL query takes the renamed column and not the original one.
Attached = is the patch to fix this issue.

--
Thanks,
Aditya Toshniwal=
=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
"Don't Co= mplain about Heat, Plant a TREE"
=
--000000000000b2cd6605af7f6ef0-- --000000000000b2cd6905af7f6ef2 Content-Type: application/octet-stream; name="RM5807.patch" Content-Disposition: attachment; filename="RM5807.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kf6n5cdb0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL2RhdGFtb2RlbC5qcyBi L3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL2RhdGFtb2RlbC5qcwppbmRleCBjZDc0OTgy ZWMuLmNlMWE0NzA2YSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvanMv ZGF0YW1vZGVsLmpzCisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL2RhdGFtb2Rl bC5qcwpAQCAtMzg2LDggKzM4Niw4IEBAIGRlZmluZShbCiAgICAgICAgIH0KIAogICAgICAgICBz ZWxmLnRyaWdnZXIoJ3BnYWRtaW4tc2Vzc2lvbjpzZXQnLCBzZWxmLCBhdHRycyk7Ci0gICAgICAg IGlmICghb3B0aW9ucyB8fCAhb3B0aW9ucy5zaWxlbnQpIHsKLSAgICAgICAgICBzZWxmLnRyaWdn ZXIoJ2NoYW5nZScsIHNlbGYsIG9wdGlvbnMpOworICAgICAgICBpZiAoIW9wdHMgfHwgIW9wdHMu c2lsZW50KSB7CisgICAgICAgICAgc2VsZi50cmlnZ2VyKCdjaGFuZ2UnLCBzZWxmLCBvcHRzKTsK ICAgICAgICAgfQogCiAgICAgICAgIC8vIFBlcmZvcm0gZGVmYXVsdCB2YWxpZGF0aW9ucy4KQEAg LTExMzIsNyArMTEzMiw4IEBAIGRlZmluZShbCiAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAg ICAgIChzZWxmLmhhbmRsZXIgfHwgc2VsZikudHJpZ2dlcigncGdhZG1pbi1zZXNzaW9uOnJlbW92 ZWQnLCBzZWxmLCBjb3B5KTsKICAgICAgICAgICB9Ci0KKyAgICAgICAgICAvKiBXaGVuIHJlbW92 aW5nIHRoZSBvYmplY3QgdXNlIHRoZSBvcmlnaW5hbCBzZXNzaW9uIGF0dHJzIGFuZCBub3QgdGhl IGNoYW5nZWQgb25lcyAqLworICAgICAgICAgIG9iai5zZXQob2JqLm9yaWdTZXNzQXR0cnMsIHtz aWxlbnQ6IHRydWV9KTsKICAgICAgICAgICBzZWxmLnNlc3NBdHRyc1snZGVsZXRlZCddLnB1c2go b2JqKTsKIAogICAgICAgICAgIHNlbGYuY2hlY2tEdXBsaWNhdGVXaXRoTW9kZWwob2JqKTsK --000000000000b2cd6905af7f6ef2--