Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mclBo-0000hl-LL for pgadmin-hackers@arkaria.postgresql.org; Tue, 19 Oct 2021 09:13:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mclBn-0000v8-Cw for pgadmin-hackers@arkaria.postgresql.org; Tue, 19 Oct 2021 09:13:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mclBm-0000uz-Se for pgadmin-hackers@lists.postgresql.org; Tue, 19 Oct 2021 09:13:43 +0000 Received: from mail-ua1-x92c.google.com ([2607:f8b0:4864:20::92c]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mclBi-0000g8-NR for pgadmin-hackers@postgresql.org; Tue, 19 Oct 2021 09:13:42 +0000 Received: by mail-ua1-x92c.google.com with SMTP id h19so7313507uax.5 for ; Tue, 19 Oct 2021 02:13:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=c10onpNqjlU3q6R71niM/JEzkRHAs1SEt4RDLM609tc=; b=WWpIPQ5u74VlC2GLYAofrNkkbQsudvEtfcIXhLdzvWkE7N6XhUhxe/KzM4a8kzBJR/ VRi6vB026Gv0R5gZzg+zDTzaTrRpMKSVZ/mHVZD7ncKSVj2wRl16F7UqKBDjynaLyvMi qbUbEsg9TvrNjJ+QjjeTgxr+kfLsLaV+mATp0sMksGk2QV8mEryuhglRFj3eNBTLmwEb bpMju2bWs3lj4T7gXeCF7vbVhZSIr3znOI6KLDa7O7qJXZmuh5fam8At4FEIBQvqjF6h eER+DQEns/+wuKjFdsK/pnkOjmfAJkaE1QsHL7+yroD6UPdBYbkdeTzOquYQuCtLb2d3 WCfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=c10onpNqjlU3q6R71niM/JEzkRHAs1SEt4RDLM609tc=; b=RZ1GQZ9Dl4YhQo9+JOnEmgO01g+qQTdEdPLz1pNzb/geF1BDdpPObJTHu4hU/gYiWn r4umFG4iuosA3B/WGC6c3833O6qIXjLprS1MksAXgZfChBAJjo6RScfRR93C6feW1UDs 0bubWesRKugvdLj9W0daoE0Yx7WS4zsI/Y6LfIlD4EmSF4wcP3RRFRXJoi5dM39RVdYH ox+Tmk4dVct0ALTtFxNPcD2n8xKetho8m2p6jmb4JvDsV0nP3Hb6u8TIvD9Lkcare1PL 29TNcj6FsBapKkGLb0rDVafhI0QVMPnzRBrJvUYimM0wN4TWEfzS8vpoKXWoRGsDamQK mRVA== X-Gm-Message-State: AOAM531le+YfkYEp8L7XrhwXh/TIZ1wd5ORAy4w4nna8h8l6/Jj/xpJ5 YJIwMlo+RNEp8OFfVcoeeQUge+dtHPBqylKoMya3deQ8JO9lHGtW7AVY+mYjA8YQYHMXuxy9fcg oAFcNshMgpy8V/kHHCFmNlJCbcLP54zRJjGPUsXuq8zKTt0X33b9LHW28KB7WTKe2q0xQ65/5jc iaJDknLZS0MBvcLloX3VwY0QRvG/zHuwD/cXkCGzCA+WSoWTQb+Yfo3vH/3FHj140= X-Google-Smtp-Source: ABdhPJzJsiTsWJpNv1YWayQ9cUPuVS06lDMFvPHjMSOyybjROtMEOTHPjHmNhUHqfMLcuzeSnW14yp5OQZX0yAFfZE0= X-Received: by 2002:ab0:70d6:: with SMTP id r22mr31479824ual.139.1634634815993; Tue, 19 Oct 2021 02:13:35 -0700 (PDT) MIME-Version: 1.0 From: Aditya Toshniwal Date: Tue, 19 Oct 2021 14:43:00 +0530 Message-ID: Subject: [pgAdmin][RM6935] Wrong SQL generated when modifying existing table in table dialog To: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000008ba67805ceb113b4" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000008ba67805ceb113b4 Content-Type: multipart/alternative; boundary="0000000000008ba67705ceb113b2" --0000000000008ba67705ceb113b2 Content-Type: text/plain; charset="UTF-8" Hi Hackers, Attached patch fixes the issue where wrong SQL is generated when deleting and renaming table columns together. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --0000000000008ba67705ceb113b2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

Attached=C2=A0patch fixes the issue where wron= g SQL is generated when deleting and renaming table columns together.
=
Pleas= e review.

--
<= div dir=3D"ltr">
Thanks,
Aditya Toshniwal
pgAdmin Hacker= =C2=A0| Software Architect=C2=A0| edb= postgres.com
"Don't Complain about Heat= , Plant a TREE"
--0000000000008ba67705ceb113b2-- --0000000000008ba67805ceb113b4 Content-Type: application/octet-stream; name="RM6935.patch" Content-Disposition: attachment; filename="RM6935.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kuxvca470 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9TY2hlbWFWaWV3L2luZGV4LmpzeCBi L3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9TY2hlbWFWaWV3L2luZGV4LmpzeAppbmRleCAxZjMyNmYw ZGEuLjVmMzgzM2Q1NCAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL2pzL1NjaGVtYVZp ZXcvaW5kZXguanN4CisrKyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9TY2hlbWFWaWV3L2luZGV4 LmpzeApAQCAtMTc2LDcgKzE3Niw3IEBAIGZ1bmN0aW9uIGdldENoYW5nZWREYXRhKHRvcFNjaGVt YSwgdmlld0hlbHBlclByb3BzLCBzZXNzRGF0YSwgc3RyaW5naWZ5PWZhbHNlLCBpCiAKICAgICAg ICAgICAgICAgICAvKiBJZiB0aGUgaWQgYXR0ciB2YWx1ZSBpcyBwcmVzZW50LCB0aGVuIG9ubHkg Y2hhbmdlZCBrZXlzIGNhbiBiZSBwYXNzZWQuCiAgICAgICAgICAgICAgICAgT3RoZXJ3aXNlLCBw YXNzaW5nIGFsbCB0aGUga2V5cyBpcyB1c2VmdWwgKi8KLSAgICAgICAgICAgICAgICBsZXQgaWRB dHRyVmFsdWUgPSBfLmdldChvcmlnVmFsLCBbZmllbGQuaWQsIHJvd0luZHgsIGZpZWxkLnNjaGVt YS5pZEF0dHJpYnV0ZV0pOworICAgICAgICAgICAgICAgIGxldCBpZEF0dHJWYWx1ZSA9IF8uZ2V0 KHNlc3NWYWwsIFtmaWVsZC5pZCwgcm93SW5keCwgZmllbGQuc2NoZW1hLmlkQXR0cmlidXRlXSk7 CiAgICAgICAgICAgICAgICAgaWYoXy5pc1VuZGVmaW5lZChpZEF0dHJWYWx1ZSkpIHsKICAgICAg ICAgICAgICAgICAgIGNoYW5nZVsnY2hhbmdlZCddLnB1c2goewogICAgICAgICAgICAgICAgICAg ICAuLi5jaGFuZ2VkUm93LAo= --0000000000008ba67805ceb113b4--