Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lvBCA-0004v5-1d for pgadmin-hackers@arkaria.postgresql.org; Mon, 21 Jun 2021 04:05:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lvBC8-0002cy-NY for pgadmin-hackers@arkaria.postgresql.org; Mon, 21 Jun 2021 04:05:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lvBC8-0002cp-EF for pgadmin-hackers@lists.postgresql.org; Mon, 21 Jun 2021 04:05:56 +0000 Received: from mail-vs1-xe31.google.com ([2607:f8b0:4864:20::e31]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lvBC4-0005lb-Kf for pgadmin-hackers@postgresql.org; Mon, 21 Jun 2021 04:05:55 +0000 Received: by mail-vs1-xe31.google.com with SMTP id z7so8472143vso.3 for ; Sun, 20 Jun 2021 21:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ABapXrlZvgJIeuFt3u0/U1KHc0wBcIUXcJjpVtvDDXQ=; b=nOXWHoxbCDaVXhDY+Y+CiopY5TVcwkDod8f9f0N7qgzlGLJDirOf6R0z0JRoK9IA8O GL3LZWieuG6/Ua/Gm2uJzxtns53qFi5mLvlJY0yDVgIzIMDBUVvB4CMnIOc0WBCEPw94 B1eCStr8Jzb4e1E6ZsPQ1VaVfjS6oy7Z8L3XCFZD1FVYMesQCLaEGHDsmfHdSXZrFF/P 2gfsg3SyEKn2IRRXUw6Ha5ZWri28VDDxMmTjprswhNso0+4Wb7rHRCuzrx1/lnv/5iVo rsdA2NMtgRo8ZTcUzUqEz3nzULSOg+rRoY4cSZeXf6VL8Ery51CXEX46vqDvyDcNn3v7 hMeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ABapXrlZvgJIeuFt3u0/U1KHc0wBcIUXcJjpVtvDDXQ=; b=cizqB2kcTvyXO888eCCCpnpMyWyZBgW4F98hzrhENTj5wVMzfjEHETYKU1o9tAR3oG l61FABvU5ycUYMAOPj40BCDRCWLgmMnfVpJBRPQSrlpzkJc34QP2eRpnEIs8z/ScGrQL DYcwxQu2H/nf+Nom4H5VbzXpqrTwj3qeV//NI+WEp5a1mdsTApWrohqP4O8jzAiuG34U d2knUB54WqIyNILN0T6EmKz3+25peIjzaht8GIvXLoIB2WsdyX9h5UPupgVV+/OtKcdh IzOuum8RFYZui6MBHzQMx+/dx71c09ytGIJXRZTjewXDxJO4V35ILg2muhQHf2UQKq2f 19sg== X-Gm-Message-State: AOAM533sccke+tJaQGKl5v5cJzXEsq1c31cbKpIChSQW4pMUWN69AoLE kCqVf8CwtRPDcrpUtGrjXjjkq/OSD8cOm0iVCyd7Ca/Yp+R4QS+WOwDdpPyBelSnGu1aDjSR1c5 MHYuM27Xv3NnytulrM/GJkyW4/nF0WDep/ieTs+w55yBI6Pz6wjI/fSjrYjzG5CKZtiLT+gy5gb 8XQ5emEHyx1Hos8AjBwVdpfnWrCBlOzjy0n0fZ05GBCmPZew2nl1igQ3/knjicT3g= X-Google-Smtp-Source: ABdhPJzDa8niVbfvA+NXLaq27DeoZJZdhA/zJP+uj+Hl0RJ6LHfM0F+glzngQlSYqmkktDf7KprdAtor3Nl6OZOdRbw= X-Received: by 2002:a67:f954:: with SMTP id u20mr10506534vsq.58.1624248349861; Sun, 20 Jun 2021 21:05:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Mon, 21 Jun 2021 09:35:13 +0530 Message-ID: Subject: Re: [pgAdmin][RM6130] React based framework for properties dialog and port Server Group, Server and Database dialogs To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ebbd6f05c53ec9f7" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000ebbd6f05c53ec9f7 Content-Type: text/plain; charset="UTF-8" Hi Dave, On Thu, Jun 17, 2021 at 7:26 PM Dave Page wrote: > Hi > > On Thu, Jun 17, 2021 at 11:01 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached patch marks the beginning of migrating properties dialog/tab to >> React based code, which is easy to maintain, performant and testable using >> automation. >> Patch includes: >> - Framework for creating React based dynamic form view out of a >> pre-defined UI schema. Previously, it was based on Backform/Backbone. >> - The new framework and components will use MaterialUI as base. >> Previously, Bootstrap/Backform/jQuery components were used. >> - The new code uses JSS instead of CSS since material ui and most modern >> React libraries also use JSS. In future, this will allow us to change >> the theme in real-time without refresh. >> - 90% code covered by 80-85 new jasmine test cases. >> - Server group node UI Schema migration to new, with schema test cases. >> - Server node UI Schema migration to new, with schema test cases. >> - Database node UI Schema migration to new, with schema test cases. >> - Few other UI changes. >> > > Nice! > > >> >> PS: Until all the nodes are migrated, this will not go in the main branch. >> > > Yeah, how are we going to manage this? I agree with building it out in a > branch until we have full coverage of the dialogues, but I'm concerned that > it'll become a merge nightmare. Though, I guess we aren't touching the > dialogues much for other things right now, so maybe not. > We'll right now work only on the dialogs. So merging should be manageable. BTW, the patch can be merged in the main branch as well. It is backward compatible, and it will work fine. Only the UI components would look slightly different from the non-migrated dialogs. > > -- > Dave Page > Blog: https://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: https://www.enterprisedb.com > > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --000000000000ebbd6f05c53ec9f7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

On Thu, Jun 17, 2021 at 7:26 PM = Dave Page <dpage@pgadmin.org>= ; wrote:
Hi

On Thu, Jun 17, 2021 at 11:01 AM Aditya Toshniwal <aditya.t= oshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch mar= ks the beginning=C2=A0of migrating properties dialog/tab to React based cod= e, which is easy to maintain, performant and testable using automation.
Patch includes:
<= div style=3D"font-family:verdana,sans-serif">- Framework for creating=C2=A0= React based dynamic form view out of a pre-defined UI schema. Previously, = it was based on Backform/Backbone.
- The new framework and components will use MaterialUI as base. = Previously, Bootstrap/Backform/jQuery components were used.
- The new code uses JSS instead of = CSS since material ui and most modern React libraries also use JSS. In futu= re, this will=C2=A0allow us to change the=C2=A0theme in real-time without r= efresh.
- 90% code cover= ed by 80-85 new jasmine test cases.
- Server gr= oup node UI Schema migration to new, with schema test cases.
- Server node UI Schema migration to n= ew, with schema test cases.
- Database node UI Schema migration to new, with schema test cases.=
- Few other UI changes.=

Nice!
=C2=A0

PS: Until=C2=A0all the nodes are migrated, this= will not go in the main branch.

Yeah, how are we going to manage this? I agree with building it out= in a branch until we have full coverage of the dialogues, but I'm conc= erned that it'll become a merge nightmare. Though, I guess we aren'= t touching the dialogues much for other things right now, so maybe not.
We'll right now work only on the dialogs. S= o merging should be manageable.
BTW, the patch can be merged i= n the main branch as well. It is backward compatible, and it will work fine= . Only the UI components would look slightly different from the non-migrate= d dialogs.
=C2=A0
--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitt= er: @pgsnake

EDB: https://www.enterprisedb.com



--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Softwa= re Engineer | edbpostgres.com<= /font>
"Don't Complain about Heat, Plant a TREE&qu= ot;
--000000000000ebbd6f05c53ec9f7--