Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kvEVi-0006fN-3z for pgadmin-hackers@arkaria.postgresql.org; Fri, 01 Jan 2021 07:06:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kvEVf-0007p7-DA for pgadmin-hackers@arkaria.postgresql.org; Fri, 01 Jan 2021 07:06:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kvEVf-0007p0-1p for pgadmin-hackers@lists.postgresql.org; Fri, 01 Jan 2021 07:06:03 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kvEVc-0005yS-6N for pgadmin-hackers@postgresql.org; Fri, 01 Jan 2021 07:06:02 +0000 Received: by mail-lf1-x131.google.com with SMTP id o17so47894080lfg.4 for ; Thu, 31 Dec 2020 23:05:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AtBmMp2RWYtkZCYycXsQBF9hTbf/zSN48AN/FMk6f88=; b=zKeZ5pvsc9J7hz/gaf1eVCylXy5OM1SJrDY/tR3IOuFBWNbBckP18FArn2sAxhn4Ko XPpOi0tMrJiekK3P5xBS1H9TEqLNNLkbvNwGBFIV0z9Z4gzEUClJfeo3yUVWDSWC2FtC ghMaEaMmnjWqIEeMa+x+fUURz066PdkTmF9wxze7OSYHOIbAphGQ+/2QImdnZUw9W+Ve lQFQ74u2O0QA2I0otOgz6ftL4U/s+lcrhTEMjicHU706GuHcKVq1AdqhiBAHAYcip9Eb en7cB/yr/DZIGvpGqOHiCjS+tksF5Z+S99xOmYvZEqRDeZZdFtK9Mk+52DKLQ2MmZcuA ZYtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AtBmMp2RWYtkZCYycXsQBF9hTbf/zSN48AN/FMk6f88=; b=XVKazKcSwIUgzmvWvRwoOu0RFqtAvyFyDe2QYtaWtbcPcJrojp0BdfX6UGJXRFSwxZ qBvCz/o7a77h2f4YocVRcOPU1gXMrErrmquJp8myZhd8BVpQGI6VoOKMxzICEsp3uaDP h3xLCUS0aRN2A5GxaxH7fnHRZeXsXgtqu62HEhDX3GU3lfvCaduuoPpfnEDbK7Xhbhr5 1qmwfiXcbaaDlXbNUa+oNKWQFfEcoTBnU4JcVX/or+vcKU01gChNYV7KCQL6WGZomlqe k3uRjHr7fgND4evYohrB/VR4DzBYYTSAr1QhHeryhFgSU36RgrlR/2Hu9rfaOoBqWDxy HvGA== X-Gm-Message-State: AOAM532btp3nBylgA6SnKoy0jMh2Ah4ekUu4HBWbQ6tBReeI1ct852be lOvCaF6zTu4PFDLeEcfFniMnNYmKrb9+MV3JU30xOsE2G/I54RlvtK7dt4D5w0oV0jBTV0R2ABG afSh9HV6ddU/h+qAAYZibGu/eJbB64vekUvcmkzObELZ2nVfTO3q+1Wk95CetNSk9YaukTRziNF BF+nOh/oQ8vZskIK0WEsWXUABsrX/iofflSr4R4vW4T8qHPkpnankrNNakeXnb0e3+lQ== X-Google-Smtp-Source: ABdhPJwvtjDk/VjsGgupoMFEyjgxJ3ilwr25JWMo0IVLzPz2lu4gT0QFALHyf9pZ68/nZ1dFoGCNyuu2J9wyJ4DFv8A= X-Received: by 2002:a05:651c:1355:: with SMTP id j21mr27526816ljb.441.1609484758419; Thu, 31 Dec 2020 23:05:58 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Fri, 1 Jan 2021 12:35:22 +0530 Message-ID: Subject: Re: [pgAdmin][RM5571] Expression in exclusion constraint is misinterpreted and quoted as column name by mistake To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000004c8d2005b7d15ffe" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000004c8d2005b7d15ffe Content-Type: multipart/alternative; boundary="0000000000004c8d1e05b7d15ffc" --0000000000004c8d1e05b7d15ffc Content-Type: text/plain; charset="UTF-8" Hi Hackers, The changes in CREATE TABLE sql were missed. Attached patch adds the changes. On Thu, Dec 24, 2020 at 3:02 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Dec 24, 2020 at 1:46 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi, >> >> Attached patch fixes the failing RESQL test cases. >> >> On Thu, Dec 24, 2020 at 1:15 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Wed, Dec 23, 2020 at 6:10 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the patch to add support for expressions in exclusion >>>> constraints. This also fixes the SQL generated for existing expression >>>> based constraints also. >>>> Docs updated and test cases enhanced. >>>> >>>> Please review. >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>> >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --0000000000004c8d1e05b7d15ffc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

The changes in CREATE TABLE sql were missed. A= ttached=C2=A0patch adds the changes.

On Thu, Dec 24, 2020 at 3:02 PM A= kshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied= .

On Thu, Dec 24, 2020 at 1:46 PM Aditya Toshniwal <aditya.toshniwal@enterpri= sedb.com> wrote:
Hi,

Attached patch fixes the failing RESQL test ca= ses.

On Thu, Dec 24, 2020 at 1:15 PM Akshay Joshi <akshay.joshi@enterprised= b.com> wrote:
Thanks, patch applied.

On Wed, Dec 23, 2020 at 6:10 PM= Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,<= /div>
=
Attached is the patch to add support for expressions in exclusion cons= traints. This also fixes the SQL generated for existing expression based co= nstraints also.
Docs updated and test cases enhanced.

Please review.<= /div>

--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Software Engineer | edb= postgres.com
"Don't Complain about Heat= , Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"
--0000000000004c8d1e05b7d15ffc-- --0000000000004c8d2005b7d15ffe Content-Type: application/x-patch; name="RM5571.table.patch" Content-Disposition: attachment; filename="RM5571.table.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kjdwqfmx0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2Rh dGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0ZXMvdGFibGVzL3NxbC9tYWNyb3MvY29uc3Ry YWludHMubWFjcm8gYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9k YXRhYmFzZXMvc2NoZW1hcy90YWJsZXMvdGVtcGxhdGVzL3RhYmxlcy9zcWwvbWFjcm9zL2NvbnN0 cmFpbnRzLm1hY3JvCmluZGV4IDQzZGIzMGMxYy4uZTM1MjliZWQ3IDEwMDY0NAotLS0gYS93ZWIv cGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90 YWJsZXMvdGVtcGxhdGVzL3RhYmxlcy9zcWwvbWFjcm9zL2NvbnN0cmFpbnRzLm1hY3JvCisrKyBi L3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hl bWFzL3RhYmxlcy90ZW1wbGF0ZXMvdGFibGVzL3NxbC9tYWNyb3MvY29uc3RyYWludHMubWFjcm8K QEAgLTg0LDcgKzg0LDcgQEAKIAogICAgIHslIGlmIGRhdGEubmFtZSAlfUNPTlNUUkFJTlQge3sg Y29ubnxxdElkZW50KGRhdGEubmFtZSkgfX0geyUgZW5kaWYlfUVYQ0xVREUgeyUgaWYgZGF0YS5h bW5hbWUgYW5kIGRhdGEuYW1uYW1lICE9ICcnICV9VVNJTkcge3tkYXRhLmFtbmFtZX19eyUgZW5k aWYgJX0gKAogICAgICAgICB7JSBmb3IgY29sIGluIGRhdGEuY29sdW1ucyAlfXslIGlmIGxvb3Au aW5kZXggIT0gMSAlfSwKLSAgICAgICAgeyUgZW5kaWYgJX17eyBjb25ufHF0SWRlbnQoY29sLmNv bHVtbil9fXslIGlmIGNvbC5vcGVyX2NsYXNzIGFuZCBjb2wub3Blcl9jbGFzcyAhPSAnJyAlfSB7 e2NvbC5vcGVyX2NsYXNzfX17JSBlbmRpZiV9eyUgaWYgY29sLm9yZGVyIGlzIGRlZmluZWQgYW5k IGNvbC5pc19zb3J0X251bGxzX2FwcGxpY2FibGUgJX17JSBpZiBjb2wub3JkZXIgJX0gQVNDeyUg ZWxzZSAlfSBERVNDeyUgZW5kaWYgJX0gTlVMTFN7JSBlbmRpZiAlfSB7JSBpZiBjb2wubnVsbHNf b3JkZXIgaXMgZGVmaW5lZCBhbmQgY29sLmlzX3NvcnRfbnVsbHNfYXBwbGljYWJsZSAlfXslIGlm IGNvbC5udWxsc19vcmRlciAlfUZJUlNUIHslIGVsc2UgJX1MQVNUIHslIGVuZGlmICV9eyUgZW5k aWYgJX1XSVRIIHt7Y29sLm9wZXJhdG9yfX17JSBlbmRmb3IgJX0pCisgICAgICAgIHslIGVuZGlm ICV9eyUgaWYgY29sLmlzX2V4cCAlfXt7Y29sLmNvbHVtbn19eyUgZWxzZSAlfXt7IGNvbm58cXRJ ZGVudChjb2wuY29sdW1uKX19eyUgZW5kaWYgJX17JSBpZiBjb2wub3Blcl9jbGFzcyBhbmQgY29s Lm9wZXJfY2xhc3MgIT0gJycgJX0ge3tjb2wub3Blcl9jbGFzc319eyUgZW5kaWYlfXslIGlmIGNv bC5vcmRlciBpcyBkZWZpbmVkIGFuZCBjb2wuaXNfc29ydF9udWxsc19hcHBsaWNhYmxlICV9eyUg aWYgY29sLm9yZGVyICV9IEFTQ3slIGVsc2UgJX0gREVTQ3slIGVuZGlmICV9IE5VTExTeyUgZW5k aWYgJX0geyUgaWYgY29sLm51bGxzX29yZGVyIGlzIGRlZmluZWQgYW5kIGNvbC5pc19zb3J0X251 bGxzX2FwcGxpY2FibGUgJX17JSBpZiBjb2wubnVsbHNfb3JkZXIgJX1GSVJTVCB7JSBlbHNlICV9 TEFTVCB7JSBlbmRpZiAlfXslIGVuZGlmICV9V0lUSCB7e2NvbC5vcGVyYXRvcn19eyUgZW5kZm9y ICV9KQogeyUgaWYgZGF0YS5pbmNsdWRlfGxlbmd0aCA+IDAgJX0KICAgICAgICAgSU5DTFVERSh7 JSBmb3IgY29sIGluIGRhdGEuaW5jbHVkZSAlfXslIGlmIGxvb3AuaW5kZXggIT0gMSAlfSwgeyUg ZW5kaWYgJX17e2Nvbm58cXRJZGVudChjb2wpfX17JSBlbmRmb3IgJX0pCiB7JSBlbmRpZiAlfXsl IGlmIGRhdGEuZmlsbGZhY3RvciAlfQpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vc3RhdGljL3Nj c3MvX2JhY2tncmlkLm92ZXJyaWRlcy5zY3NzIGIvd2ViL3BnYWRtaW4vc3RhdGljL3Njc3MvX2Jh Y2tncmlkLm92ZXJyaWRlcy5zY3NzCmluZGV4IDM1ODQwY2ZhZS4uOTA4YzNkMWI1IDEwMDY0NAot LS0gYS93ZWIvcGdhZG1pbi9zdGF0aWMvc2Nzcy9fYmFja2dyaWQub3ZlcnJpZGVzLnNjc3MKKysr IGIvd2ViL3BnYWRtaW4vc3RhdGljL3Njc3MvX2JhY2tncmlkLm92ZXJyaWRlcy5zY3NzCkBAIC02 LDcgKzYsNyBAQAogLmJhY2tncmlkIHRkIHsKICAgZm9udC13ZWlnaHQ6IG5vcm1hbCFpbXBvcnRh bnQ7CiAgICYuZWRpdGFibGUgewotICAgICYgLmRpc3BsYXktdGV4dCB7CisgICAgJiA+IC5kaXNw bGF5LXRleHQgewogICAgICAgb3ZlcmZsb3c6IGhpZGRlbjsKICAgICAgIHRleHQtb3ZlcmZsb3c6 IGVsbGlwc2lzOwogICAgICAgQGV4dGVuZCAuZm9ybS1jb250cm9sOwo= --0000000000004c8d2005b7d15ffe--