MIME-Version: 1.0
References: 
 <CADiZPH7qT7PVSrwduvL8Sa6N2W27NkP4EcsycmyygokYxXaFUQ@mail.gmail.com>
In-Reply-To: 
 <CADiZPH7qT7PVSrwduvL8Sa6N2W27NkP4EcsycmyygokYxXaFUQ@mail.gmail.com>
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Mon, 9 Dec 2019 15:24:58 +0530
Message-ID: 
 <CAM9w-_=KyZkcHFg9g1esMq7mSiAEYqaC1hWcFiqnj4W8MyPk0w@mail.gmail.com>
Subject: Re: Re : [BUG #4943]
To: Karan Takalkar <karan1533os@gmail.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000009903710599426512"
Precedence: bulk

--0000000000009903710599426512
Content-Type: text/plain; charset="UTF-8"

++pgadmin-hackers

Hi Karan,

It is good to know that you're contributing.
I would suggest {server name}/{db name} as name instead of did is better
for UX. You can get the db name from conn object and server name using the
sid (refer - web/pgadmin/browser/server_groups/servers/__init__.py)


On Mon, Dec 9, 2019 at 3:11 PM Karan Takalkar <karan1533os@gmail.com> wrote:

> Hi,
>
> I have been working on #4943 ("Database connected" success message itself
> is not enough) added by you on pgAdmin4 issues.
> I want to know what details of database should be included in success
> message.(i have added 'did')
>
> The success message can be modified by altering json response in the
> connect method in file
> PGADMIN_SRC/web/pgadmin/browser/server_groups/servers/databases/__init__.py.
> please have a look at the screenshots attached.
>
> original:
> info=_( "Database connected.")
> new:
> info=_("Postgres version/{0} Database connected.".format(did))
>
> Regards,
> Karan
>


-- 
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

--0000000000009903710599426512
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif">++pgadmin-hackers<br></div><div class=3D"gmail_default" style=
=3D"font-family:verdana,sans-serif"><br></div><div class=3D"gmail_default" =
style=3D"font-family:verdana,sans-serif">Hi Karan,</div><div class=3D"gmail=
_default" style=3D"font-family:verdana,sans-serif"><br></div><div class=3D"=
gmail_default" style=3D"font-family:verdana,sans-serif">It is good to know =
that you&#39;re contributing.</div><div class=3D"gmail_default" style=3D"fo=
nt-family:verdana,sans-serif">I would suggest {server name}/{db name} as na=
me instead of did is better for UX. You can get the db name from conn objec=
t and server name using the sid (refer -=C2=A0web/pgadmin/browser/server_gr=
oups/servers/__init__.py)</div><div class=3D"gmail_default" style=3D"font-f=
amily:verdana,sans-serif"><br></div></div><br><div class=3D"gmail_quote"><d=
iv dir=3D"ltr" class=3D"gmail_attr">On Mon, Dec 9, 2019 at 3:11 PM Karan Ta=
kalkar &lt;<a href=3D"mailto:karan1533os@gmail.com">karan1533os@gmail.com</=
a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p=
x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><d=
iv dir=3D"ltr"><div>Hi,</div><div><br></div><div>I have been working on #49=
43 (<span style=3D"font-weight:normal">&quot;Database connected&quot; succe=
ss message itself is not enough) added by you on pgAdmin4 issues.</span></d=
iv><div><span style=3D"font-weight:normal">I want to know what details of d=
atabase should be included in success message.(i have added &#39;did&#39;)<=
br></span></div><div><span style=3D"font-weight:normal"><br></span></div><d=
iv><span style=3D"font-weight:normal">The success message can be modified b=
y altering json response in the connect method in file PGADMIN_SRC/web/pgad=
min/browser/server_groups/servers/databases/__init__.py.</span></div><div><=
span style=3D"font-weight:normal">please have a look at the screenshots att=
ached.</span></div><div><span style=3D"font-weight:normal"><br></span></div=
><div><span style=3D"font-weight:normal"><span style=3D"font-weight:normal"=
>original:</span></span></div><div><span style=3D"font-weight:normal"><span=
 style=3D"font-weight:normal">info=3D_( &quot;Database connected.&quot;)</s=
pan></span></div><div><span style=3D"font-weight:normal"><span style=3D"fon=
t-weight:normal">new:</span></span></div><div><span style=3D"font-weight:no=
rmal"><span style=3D"font-weight:normal">info=3D_(&quot;Postgres version/{0=
} Database connected.&quot;.format(did))</span></span></div><div><span styl=
e=3D"font-weight:normal"><span style=3D"font-weight:normal"><br></span></sp=
an></div><div><span style=3D"font-weight:normal">Regards,</span></div><div>=
<span style=3D"font-weight:normal">Karan<br></span></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div=
 dir=3D"ltr"><div><div dir=3D"ltr"><font size=3D"2" color=3D"#000000" face=
=3D"verdana, sans-serif">Thanks and Regards,</font><div><span style=3D"back=
ground-color:rgb(255,255,255)"><font size=3D"2" color=3D"#000000" face=3D"v=
erdana, sans-serif">Aditya Toshniwal</font></span></div><div><font face=3D"=
verdana, sans-serif"><span style=3D"background-color:rgb(255,255,255)"><fon=
t size=3D"2" color=3D"#000000">Sr. Software Engineer |=C2=A0EnterpriseDB In=
dia |=C2=A0</font></span><span style=3D"color:rgb(0,0,0)">Pune</span></font=
></div><div><font color=3D"#38761d" face=3D"verdana, sans-serif" size=3D"1"=
>&quot;Don&#39;t Complain about Heat, Plant a TREE&quot;</font></div></div>=
</div></div></div></div></div></div></div>

--0000000000009903710599426512--