public inbox for [email protected]  

help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM - 3051 - ables > Properties > Columns tab is slow on tables with a lot of fields
Date: Tue, 22 Jan 2019 11:33:05 +0530
Message-ID: <CAM9w-_=RLYvwz4HJ5YrDPSdX80B7kLvt0Ti41F6r0_deAt-wHg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDc1q3KmpmO=SZw69J9on-TUUBVj-QoN7aYAtgYjP3HBsQ@mail.gmail.com>
References: <CAFOhELfosrL2Y_2_gwHyzef5JeSSzNSyicSNj6uv1B1286yKzg@mail.gmail.com>
	<CANxoLDc1q3KmpmO=SZw69J9on-TUUBVj-QoN7aYAtgYjP3HBsQ@mail.gmail.com>

Hi Khushboo,

I have few suggestions/review:
1) Do we need to add "editor" class to switch control in backgrid when
changing. For eg. in tables->columns if I change not null switch, it adds
editor class which makes hover background white. Plus, leaving the switch
does not remove editor class. I think we can skip adding editor, what
do you think?
2) In Login roles, Create trigger dialogs switch control colors are
different. Below is screenshot,
[image: Screenshot 2019-01-22 at 11.04.36 AM.png]
3) In Create cast dialog switch control is smaller and so clipping text.
Below is screenshot,
[image: Screenshot 2019-01-22 at 11.07.14 AM.png]
4) You've removed unnecessary switch control template codes at most places.
I would suggest doing the same for Backform.CustomSwitchControl in
trigger.js
5) Feature tests are still using bootstrap-switch classes and so failing.

Apart from above, everything looks good to me.


On Mon, Jan 21, 2019 at 4:42 PM Akshay Joshi <[email protected]>
wrote:

> Hi Aditya
>
> Can you please review it.
>
> On Mon, Jan 14, 2019 at 4:28 PM Khushboo Vashi <
> [email protected]> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix #3051 - Tables > Properties >
>> Columns tab is slow on tables with a lot of fields
>>
>> The root cause of the issue is bootstrap switch, which has been replaced
>> with bootstrap4-toggle application wide.
>>
>> Thanks,
>> Khushboo
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


Attachments:

  [image/png] Screenshot 2019-01-22 at 11.04.36 AM.png (107.2K, 3-Screenshot%202019-01-22%20at%2011.04.36%20AM.png)
  download | view image

  [image/png] Screenshot 2019-01-22 at 11.07.14 AM.png (49.9K, 4-Screenshot%202019-01-22%20at%2011.07.14%20AM.png)
  download | view image

view thread (19+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM - 3051 - ables > Properties > Columns tab is slow on tables with a lot of fields
  In-Reply-To: <CAM9w-_=RLYvwz4HJ5YrDPSdX80B7kLvt0Ti41F6r0_deAt-wHg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox