Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ieKbG-0002y1-QQ for pgadmin-hackers@arkaria.postgresql.org; Mon, 09 Dec 2019 15:05:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ieKbE-000701-NW for pgadmin-hackers@arkaria.postgresql.org; Mon, 09 Dec 2019 15:05:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ieKbE-0006zs-3r for pgadmin-hackers@lists.postgresql.org; Mon, 09 Dec 2019 15:05:24 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ieKb6-0006Yu-ST for pgadmin-hackers@postgresql.org; Mon, 09 Dec 2019 15:05:22 +0000 Received: by mail-ed1-x541.google.com with SMTP id cx19so12982760edb.1 for ; Mon, 09 Dec 2019 07:05:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aILSvnFBeEIfj/CP0H1CG7tNKyWgR9ZdgWLDP2jKI0M=; b=JxvaWDuz4ObaLmRlzsmRR3YNoSTdzk12Y0JhOdzQAtRbQLOM0wF/gi4SgMqpdxTjUW nHUV7G/J7B8/gQJqMuAPEEVyCEvLCrS7303pClJP6YesOt7HBxuiBWqIGc8fCy9gXfwy Xc8aYt+7fEuwIMD5DUCQk6H0+dd8dfWCMWztTfNv0orDXVPn6+tXq4qPvXvSDDYiUFB9 m3OOGxQ9NxC3gzPdiF9n5dIt9GkrI/YHpJmj6cxe6UAXLZ8YO2RCWfBFJ2FLBTBjwH75 obbRzsi4jfym2dTT6bv40UC2FvMCG59LA1OjiRGlzIInS8XTD3F6JQBxY8QZpl1StWhO zDKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aILSvnFBeEIfj/CP0H1CG7tNKyWgR9ZdgWLDP2jKI0M=; b=HzixyW4zULQCuEWigTY4tRtNFgnu+CuCUTrvJREx5IcnCc1qIrJsd+/YoynTUoxtLg N7zRDpvvM9RfAPmuh7CHOxZoKFSqAMnPl0D49A0kImAeibTnTK1y3vvMRHXxB6YFs00T RrnhltjRyswZ52CEVUpgRPhlJ3lnjntFWKEJv0272shohCXMN9DSsktJowzHXeK48GT6 CokISvMST7EuwhzyW0aQ9gyXDYg+E5iuoiICT5a0b0K/NMGM20D2/+zY5gKEqznA6cX0 5tfRqZtzhr7mmUQ9KqVYcgwtI70FCtbpYqGOawn3cPPSt4QRHEAc03neMjEnq4yvibIY TV+g== X-Gm-Message-State: APjAAAXjG+k9Ojk3/xRPYxJZYnouiTtzjBA1mZDkZdHtHr2zKtRuNTcC /bh7foWMvgSYpbNmcRISbk3VAM7/8qBWlBvx8zS+ADHgnpzhvStGfm0Fb01cgLl9sL211CYq8vZ m/0J+jQy1y54GoK2D5XUruQNk8eG29/R0A1W5RB4ccK14JPxJrC+72MqkVV/nusQYoNSmZjCgO8 3kNG02OrLUwmlG5OB/fozkoMc5+9ZjfBUNOepEQ/PSeby/EADQMWc= X-Google-Smtp-Source: APXvYqzeT57rwnbyMtsLuSb30XjjrhYlA0jUDf/Lxbb+ov6AEIbbseONEnWshqW3eYz26xBBJlstimbqIBgdpS93s6M= X-Received: by 2002:a17:906:828b:: with SMTP id h11mr31565917ejx.273.1575903915139; Mon, 09 Dec 2019 07:05:15 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Mon, 9 Dec 2019 20:35:03 +0530 Message-ID: Subject: Re: Re : [BUG #4943] To: Karan Takalkar Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000000ffd8d059946b983" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000000ffd8d059946b983 Content-Type: text/plain; charset="UTF-8" Hi Karan, Kindly add a hyphen between the message and names, create a patch to pgAdmin hackers(check cc). Kindly also run the test cases and pep8 before sending. On Mon, Dec 9, 2019, 20:17 Karan Takalkar wrote: > I have updated the success message. > Please check the screenshots attached. > Should i make a patch? > > Regards, > Karan > > On Mon, 9 Dec, 2019, 3:25 PM Aditya Toshniwal, < > aditya.toshniwal@enterprisedb.com> wrote: > >> ++pgadmin-hackers >> >> Hi Karan, >> >> It is good to know that you're contributing. >> I would suggest {server name}/{db name} as name instead of did is better >> for UX. You can get the db name from conn object and server name using the >> sid (refer - web/pgadmin/browser/server_groups/servers/__init__.py) >> >> >> On Mon, Dec 9, 2019 at 3:11 PM Karan Takalkar >> wrote: >> >>> Hi, >>> >>> I have been working on #4943 ("Database connected" success message >>> itself is not enough) added by you on pgAdmin4 issues. >>> I want to know what details of database should be included in success >>> message.(i have added 'did') >>> >>> The success message can be modified by altering json response in the >>> connect method in file >>> PGADMIN_SRC/web/pgadmin/browser/server_groups/servers/databases/__init__.py. >>> please have a look at the screenshots attached. >>> >>> original: >>> info=_( "Database connected.") >>> new: >>> info=_("Postgres version/{0} Database connected.".format(did)) >>> >>> Regards, >>> Karan >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > --0000000000000ffd8d059946b983 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Karan,

Ki= ndly add a hyphen between the message and names, create a patch to pgAdmin = hackers(check cc).
Kindly also run the test cases an= d pep8 before sending.

On Mon, Dec 9, 2019, 20:17 Karan Takalkar <= ;karan1533os@gmail.com> wro= te:
I have update= d the success message.=C2=A0
Please check the screenshots = attached.
Should i make a patch?

Regards,
Karan
=

= On Mon, 9 Dec, 2019, 3:25 PM Aditya Toshniwal, <aditya.toshniwal@enterprisedb.com> wrote:
++pgadmin-hackers

Hi Karan,

=
It is= good to know that you're contributing.
I would suggest {server name}/{= db name} as name instead of did is better for UX. You can get the db name f= rom conn object and server name using the sid (refer -=C2=A0web/pgadmin/bro= wser/server_groups/servers/__init__.py)


On Mon, Dec 9, 2019 at 3:= 11 PM Karan Takalkar <karan1533os@gmail.com= > wrote:
Hi,

I have been working on #4943= ("Database connected" success= message itself is not enough) added by you on pgAdmin4 issues.
I want to know what details of dat= abase should be included in success message.(i have added 'did')

The success message can be modified by = altering json response in the connect method in file PGADMIN_SRC/web/pgadmi= n/browser/server_groups/servers/databases/__init__.py.
please have a look at the screenshots attac= hed.

<= div>o= riginal:
info=3D_( "Database connected.")
new:
info=3D_("Postgres version/{0} = Database connected.".format(did))

Regards,
<= span style=3D"font-weight:normal">Karan


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"
--0000000000000ffd8d059946b983--