Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbHwu-00087G-B0 for pgadmin-hackers@arkaria.postgresql.org; Thu, 13 Jun 2019 05:06:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hbHwt-0000Cv-1r for pgadmin-hackers@arkaria.postgresql.org; Thu, 13 Jun 2019 05:06:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbHws-0000Cg-MT for pgadmin-hackers@lists.postgresql.org; Thu, 13 Jun 2019 05:06:54 +0000 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbHwn-0001CI-9N for pgadmin-hackers@postgresql.org; Thu, 13 Jun 2019 05:06:54 +0000 Received: by mail-lf1-x143.google.com with SMTP id 136so13967812lfa.8 for ; Wed, 12 Jun 2019 22:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ctTJfNMp2BwjrS4pbf596gh0dXjBZ63+7tdIgrXX1Ac=; b=amdVY28TYHC6H2B3ezM5EtKvCViZ4VTdHUUJx4UJ0iVmt0hfAaZP52Tn+0dmvbrkDt tLp4l95agApp1ccNxpt4ndfH+APVKTrovLxOg/NwIuMYqwKudoLHICnV52ZExam5ga4l BoX8Swv+82Eyvns4Npks7Xhc3myg/vafGq7BdhQfgr2/WeLnN2a5Jkj+2P/DsoMehxL4 atSoGF0pjFDfj2gGaoWLJDzvPCMLnpeuFxXSfLdqDmJNqtFBCa+qWndS2s73St+5rn1l 0K1EkZqQpacsA336VgyHWEB6e4gnsuXoRmBlJkGwRZ7BhbFZflsxIisiYYGSnAoSCtGb iDfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ctTJfNMp2BwjrS4pbf596gh0dXjBZ63+7tdIgrXX1Ac=; b=n1UIDZ52TjSkwu4SHNlOotyUrWUVmFfI0UzwRxVtt4UfXy0SSTO2D2/m4DHsEdhKbQ DF0jj6dt4fk2cuWjg4bt9ClimsrW/Od73jmQSwxbzM2j5O+fNWzFHQji5QWk8IPnIJHB E2yLSRf4nTQ6pp1kQublzrXoBj4dhN5+FrKHNuVQwLDnH2ZWL2p+o2xHhceSnxF4eRmO Mq3g+hOY4xzblwbKPZFHS0vuAEtMzr2VKgL1PCfAr5PLmupHDht8zNCw6UIMR/YMK01c N5wK9NYeBQgsjBRaB2Za6Hx/JDfnNLI8myphu9lDjZrjP1XDdjlaGYLzfXdjxVuQphjO Bdww== X-Gm-Message-State: APjAAAUPIcJfIEiy25Y909vmbCZIzVO/rUWZaH6L48QW7tX7+qbgKWMl 09K8/iI0yrHsME3TMSgKN6L+FlX8g3gVmOsgoKktMw== X-Google-Smtp-Source: APXvYqzhIXAla0GuqU7p6e+VqUH0OkK+Qasu2ihj+3wKGPrVMzC+s1+LGIzd2nycq/FU1iTu81qxIt1uTjYmy1hoSaU= X-Received: by 2002:ac2:558a:: with SMTP id v10mr44731279lfg.41.1560402407059; Wed, 12 Jun 2019 22:06:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Thu, 13 Jun 2019 10:36:11 +0530 Message-ID: Subject: Re: [pgAdmin][RM3782] Debugger title should show connection and object details To: "Strauch, Sheldon" Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000002e0d28058b2d7f8b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000002e0d28058b2d7f8b Content-Type: text/plain; charset="UTF-8" I have closed this RM (RM3782 ) and have added the proposed solution to RM4232 . On Wed, Jun 12, 2019 at 8:56 PM Strauch, Sheldon wrote: > FWIW: > > - +1 for INDEPENDENTLY configurable tab title AND tooltip > - I agree that in-place edit of tabs cost/benefit isn't there, unless > someone wants a personal free-time project > > > On Wed, Jun 12, 2019 at 4:44 AM Dave Page wrote: > >> Hi >> >> On Wed, Jun 12, 2019 at 10:02 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Wed, Jun 12, 2019 at 1:54 PM Dave Page wrote: >>> >>>> Hi >>>> >>>> On Wed, Jun 12, 2019 at 7:03 AM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch to add more information on connection details to >>>>> debugger panel title and content title similar to Query Tool and View/Edit >>>>> data. >>>>> Adding the object name with arguments is not a good idea for the panel >>>>> title, so I have kept to connection details similar to query tool. The >>>>> content title will have all the details. >>>>> >>>>> Kindly review. >>>>> >>>> >>>> I think not having the function name in there is a big limitation. >>>> >>>> With all this hacking going on, I think what we need to do is stop and >>>> make this configurable as has been both requested by users and suggested by >>>> us. >>>> >>>> I propose adding 2 preference options for each tab type. Each of these >>>> would be a string with placeholders, one for the tab title, and one for the >>>> tab tooltip. For example: >>>> >>>> - Query Tool >>>> * Placeholders: %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST% >>>> * Tab title default: %DATABASE% on %SERVER% >>>> * Tooltip title default: Query Tool: %DATABASE% on %USERNAME%@ >>>> %SERVER% >>>> >>>> - View Data >>>> * Placeholders: %TABLE%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%, >>>> %PORT%, %HOST% >>>> * Tab title default: %SCHEMA%.%TABLE% in %DATABASE% on %SERVER% >>>> * Tooltip title default: View/Edit Data: %SCHEMA%.%TABLE% >>>> in %DATABASE% on %USERNAME%@%SERVER% >>>> >>>> - Script >>>> * Placeholders: %ACTION%, %OBJECT%, %SCHEMA%, %DATABASE%, %SERVER%, >>>> %USERNAME%, %PORT%, %HOST% >>>> * Tab title default: %ACTION% %SCHEMA%.%OBJECT% in %DATABASE% on >>>> %SERVER% >>>> * Tooltip title default: %ACTION% Script: %SCHEMA%.%OBJECT% >>>> in %DATABASE% on %USERNAME%@%SERVER% >>>> >>>> - Debugger >>>> * Placeholders: %FUNCTION_ARGS%, %FUNCTION_NOARGS%, %SCHEMA%, >>>> %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST% >>>> * Tab title default: %FUNCTION_NOARGS%.%OBJECT% in %DATABASE% on >>>> %SERVER% >>>> * Tooltip title default: Debugger: %SCHEMA%.%FUNCTION_ARGS% >>>> in %DATABASE% on %USERNAME%@%SERVER% >>>> >>>> Or something like that. Thoughts? >>>> >>> Yes, this could be a nice feature. I think tooltip title customisation >>> is not needed, we can just set it as prefix + tab title. >>> >> >> I think having it be separate is useful - you can include full >> information there, but keep the tab minimal so as not to create huge tabs. >> For example, the debugger tab could just be set to %FUNCTION_NOARGS%, >> whilst the tooltip has the full string. >> >> >>> Some users asked for in-place rename of tab title. I'm not sure if it is >>> feasible to implement, but should we consider it also ? >>> >> >> No - I've only seen one request for that, and it seems like a lot of work >> for little gain. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> >> The Enterprise PostgreSQL Company >> > > > -- > > Look after your data, and your database will look after you. -- Simon Riggs > > Sheldon E. Strauch > *Data Architect, Data Services * > *O* 312-676-1556 > *M* 224-723-3878 > > *Enova International, Inc.* > *This transmission is confidential and may be privileged or proprietary. > If you are not the intended recipient, you are not authorized to use the > information in this transmission in any way. Please inform the sender > immediately if you have received this transmission in error and permanently > delete and destroy the original and any copies of the information.* > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --0000000000002e0d28058b2d7f8b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I have closed this RM (RM3782) and=C2=A0have added the proposed solution to RM4232.
=
On Wed= , Jun 12, 2019 at 8:56 PM Strauch, Sheldon <sstrauch@enova.com> wrote:
FWIW:
  • +1 for= INDEPENDENTLY configurable tab title AND tooltip
  • I agree that in-p= lace edit of tabs cost/benefit isn't there, unless someone wants a pers= onal free-time project

On Wed, Jun 12, 2019 at 4:44 AM Dave Page &= lt;dpage@pgadmin.org= > wrote:
=
Hi

On Wed, Jun 12, 2019 at 10:02 AM Aditya Toshniwal &= lt;a= ditya.toshniwal@enterprisedb.com> wrote:
Hi,

On Wed, Jun 12, 2019 at 1:54= PM Dave Page <dp= age@pgadmin.org> wrote:
Hi

On Wed, Jun 12, 2019 at 7:03 AM Adit= ya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to add more information on connection details to= debugger panel title and content title similar to Query Tool and View/Edit= data.
Adding the object= name with arguments is not a good=C2=A0idea for the panel title, so I have= kept to connection details similar to query tool. The content title will h= ave all the details.

Kindly review.
I think not having the function name in there is a big limitat= ion.

With all this hacking going on, I think what = we need to do is stop and make this configurable as has been both requested= by users and suggested by us.

I propose adding 2 = preference options for each tab type. Each of these would be a string with = placeholders, one for the tab title, and one for the tab tooltip. For examp= le:

- Query Tool
=C2=A0 * Placeholders: = %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST%
=C2=A0 * Tab tit= le default: %DATABASE% on %SERVER%
=C2=A0 * Tooltip title default= : Query Tool: %DATABASE% on %USERNAME%@%SERVER%

- = View Data
=C2=A0 * Placeholders: %TABLE%, %SCHEMA%, %DATABAS= E%, %SERVER%, %USERNAME%, %PORT%, %HOST%
=C2=A0 * Tab title defau= lt: %SCHEMA%.%TABLE% in %DATABASE% on %SERVER%
=C2=A0 * Tooltip t= itle default: View/Edit Data: %SCHEMA%.%TABLE% in=C2=A0%DATABASE% on %USERN= AME%@%SERVER%

- Script
=C2=A0= * Placeholders: %ACTION%, %OBJECT%, %SCHEMA%, %DATABASE%, %SERVER%, %USERN= AME%, %PORT%, %HOST%
=C2=A0 * Tab title default: %ACTION% %SCHEMA= %.%OBJECT% in %DATABASE% on %SERVER%
=C2=A0 * Tooltip title defau= lt: %ACTION% Script: %SCHEMA%.%OBJECT% in=C2=A0%DATABASE% on %USERNAME%@%SE= RVER%

- Debugger
=C2=A0 * Pla= ceholders: %FUNCTION_ARGS%, %FUNCTION_NOARGS%, %SCHEMA%, %DATABASE%, %SERVE= R%, %USERNAME%, %PORT%, %HOST%
=C2=A0 * Tab title default: %FUNCT= ION_NOARGS%.%OBJECT% in %DATABASE% on %SERVER%
=C2=A0 * Tooltip t= itle default: Debugger: %SCHEMA%.%FUNCTION_ARGS% in=C2=A0%DATABASE% on %USE= RNAME%@%SERVER%

Or something like that. Thou= ghts?
Yes, this could be a nice feature. I think t= ooltip title customisation is not needed, we can just set it as=C2=A0 prefi= x=C2=A0+ tab title.

I think having it be separate is useful - you can include full informati= on there, but keep the tab minimal so as not to create huge tabs. For examp= le, the debugger tab could just be set to %FUNCTION_NOARGS%, whilst the too= ltip has the full string.
=C2=A0
Some us= ers asked for in-place rename of tab title. I'm not sure if it is feasi= ble to implement, but should we consider it also ?
=

No - I've only seen one request for th= at, and it seems like a lot of work for little gain.
=C2=A0
=
--
Dave Page
Blog: http= ://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company


--

Look aft= er your data, and your database will look after you. -- Simon Riggs

<= span style=3D"font-weight:bold;font-size:11pt;font-family:Arial;color:rgb(1= 02,102,102)">Sheldon E. Strauch
Data Architect, Data Services=C2=A0
O=C2=A0312-676-1556
M=C2=A0224-723-3878

<= p><= /span>

= Enova International, Inc.
This transmission is confidential and may be privileged or proprietary. If you a= re not the intended recipient, you are not authorized to use the information i= n this transmission in any way. Please inform the sender immediately if you h= ave received this transmission in error and permanently delete and destroy the original and any copies of the information.=C2=A0 =C2=A0=C2=A0
<= /div>


--
Adi= tya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"
--0000000000002e0d28058b2d7f8b--