Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksLnw-0001BU-GS for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 Dec 2020 08:17:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ksLnv-0006Fv-7G for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 Dec 2020 08:16:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksLnu-0006Fo-Tp for pgadmin-hackers@lists.postgresql.org; Thu, 24 Dec 2020 08:16:59 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ksLnr-0005bd-5K for pgadmin-hackers@postgresql.org; Thu, 24 Dec 2020 08:16:57 +0000 Received: by mail-lf1-x129.google.com with SMTP id h22so3206721lfu.2 for ; Thu, 24 Dec 2020 00:16:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hKc/s0i0QbSoEnVXF5Wa0JScLlzMqrtN8soGe9PnPpc=; b=cDjTLB2rresuDjy3RMRcCnEnRF/gG9PcVMNk5qyi+psc+QI3tKf/JDkLHMSGa0D/AI FAUsWVt2HqP1oRgxGymK/L7vTbohlShUPkB0/baZvtfTZ/e0QUf7sY483nVYnM7Kf1k2 ZuP0oUVJT0EPYopfxgMJF0er/ApZarkWJeRiwecCRcW4T6mB6CH5xgCknYlpUduRMTd2 XK+aKjxeM5FKNkK+Gm4Ed6ie7SEntzCgqh5Qlr6AzR5XRZf+x2qQwakwK6uP78kny7bp bCxsAZFdh7zfJxcKUjmQqKHKTSffAA3HT/FJJigw/b4Mz7VOmf/N+y8sbLQifDgANH2L hnBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hKc/s0i0QbSoEnVXF5Wa0JScLlzMqrtN8soGe9PnPpc=; b=snSkqjEOmhUbVT8EHPL9lbCnU5puEENLOZ70mHHi0C2cjPU1p6BUq4vv2uVieCdB4J Rg5v4hoNJ0g/JxKBX5fhRdhqs0vI+Z/oJP3oioV7bGdjXQksebRIApaK6JlBCu5kdUpR 8fBPE2KCfLRvUaJzuKE4JKHG1bXG5M5RVk0zBnIIuR/nxmNHmYvnCSfaTKCDrUpGfzGV RQ4PEuJzrjve6S6pCuufQpwy6H9Vf4DBWonySoa3bNjKKVXOqQGPe45Ty0gDa8AlvZ3o 3mKdX1m8gWDQy+5hO5ndFe4WpYP3D4BhnGxaS4nOjrTvd42xhl6UggSlOXtkEQOZgQaZ +KRQ== X-Gm-Message-State: AOAM5332rdTkOeAOVBWtvpYu9/B00QwWNev65v6BZImRu0CNJPab2BaF 9DAZWFrwJfuQduI+u2iHXu8digZVZlHVjGuLzBs+n0vGl9jm65FqyCtZgtHznv7oaqYK6qCES0H 8j5ZWk/yERxlR0GkpJxTsWsgNpEt/E7Sh3cEmb1Oamm5/V3NfqrxmqcMgKBxnwh+teSghf8hZLq MSftg1vwHxhSFM6V2ZTRaxMWKY3s9XCxoajjnKjRj+Kdv3zl8FisWCe/NfAPjGikznkg== X-Google-Smtp-Source: ABdhPJzH8487tt1URawnzGbLoMmnC7ikF+G0HoIm9iwqkb/4ybS28RSDsLvpnedsf+jCTuJJ5092HFA7hfV5XYGoONo= X-Received: by 2002:a2e:8e98:: with SMTP id z24mr11811175ljk.83.1608797812185; Thu, 24 Dec 2020 00:16:52 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Thu, 24 Dec 2020 13:46:16 +0530 Message-ID: Subject: Re: [pgAdmin][RM5571] Expression in exclusion constraint is misinterpreted and quoted as column name by mistake To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000001cca0405b7316e30" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000001cca0405b7316e30 Content-Type: multipart/alternative; boundary="0000000000001cca0305b7316e2e" --0000000000001cca0305b7316e2e Content-Type: text/plain; charset="UTF-8" Hi, Attached patch fixes the failing RESQL test cases. On Thu, Dec 24, 2020 at 1:15 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Dec 23, 2020 at 6:10 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to add support for expressions in exclusion >> constraints. This also fixes the SQL generated for existing expression >> based constraints also. >> Docs updated and test cases enhanced. >> >> Please review. >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --0000000000001cca0305b7316e2e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Attached patch fixes the failing RESQL test cases.

On Thu, Dec 24, 2020 at 1:15 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Than= ks, patch applied.

On Wed, Dec 23, 2020 at 6:10 PM Aditya Toshniwal <aditya.t= oshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch= to add support for expressions in exclusion constraints. This also fixes t= he SQL generated for existing expression based constraints also.
Docs updat= ed and test cases enhanced.

Please review.

--
=
Thanks,
<= span style=3D"color:rgb(18,22,70)">Aditya = Toshniwal
pgAdmin hacker=C2=A0| Sr. Software Engine= er | edbpostgres.com


--


--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Softwa= re Engineer | edbpostgres.com<= /font>
"Don't Complain about Heat, Plant a TREE&qu= ot;
--0000000000001cca0305b7316e2e-- --0000000000001cca0405b7316e30 Content-Type: application/octet-stream; name="RM5571.testcase.patch" Content-Disposition: attachment; filename="RM5571.testcase.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kj2kk4ee0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2Rh dGFiYXNlcy9zY2hlbWFzL3RhYmxlcy9jb25zdHJhaW50cy9leGNsdXNpb25fY29uc3RyYWludC90 ZXN0cy8xMV9wbHVzL3Rlc3QuanNvbiBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy9jb25zdHJhaW50cy9leGNsdXNpb25f Y29uc3RyYWludC90ZXN0cy8xMV9wbHVzL3Rlc3QuanNvbgppbmRleCA1YmFjNjU2YTkuLjc1MmYy Nzg0NiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZl cnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVzL2NvbnN0cmFpbnRzL2V4Y2x1c2lvbl9jb25zdHJh aW50L3Rlc3RzLzExX3BsdXMvdGVzdC5qc29uCisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2Vy dmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy9jb25zdHJhaW50cy9l eGNsdXNpb25fY29uc3RyYWludC90ZXN0cy8xMV9wbHVzL3Rlc3QuanNvbgpAQCAtMTYsNyArMTYs NyBAQAogICAgICAgICAgICJjbHR5cGUiOiAidGV4dCIKICAgICAgICAgfSwgewogICAgICAgICAg ICJuYW1lIjogImNvbDMiLAotICAgICAgICAgICJjbHR5cGUiOiAiaW50ZWdlciIsCisgICAgICAg ICAgImNsdHlwZSI6ICJpbnRlZ2VyIgogICAgICAgICB9XSwKICAgICAgICAgImlzX3BhcnRpdGlv bmVkIjogZmFsc2UsCiAgICAgICAgICJzY2hlbWEiOiAidGVzdHNjaGVtYSIsCkBAIC04NSwxMCAr ODUsMTMgQEAKICAgICAgICJlbmRwb2ludCI6ICJOT0RFLWV4Y2x1c2lvbl9jb25zdHJhaW50Lm9i aiIsCiAgICAgICAic3FsX2VuZHBvaW50IjogIk5PREUtZXhjbHVzaW9uX2NvbnN0cmFpbnQuc3Fs X2lkIiwKICAgICAgICJkYXRhIjogewotICAgICAgICAibmFtZSI6ICJFeGNsdXNpb25fJCV7fVtd KCkmKl4hQFwiJ2BcXC8jXzEiLAorICAgICAgICAibmFtZSI6ICJFeGNsdXNpb25fJCV7fVtdKCkm Kl4hQFwiJ2BcXC8jIiwKICAgICAgICAgImNvbW1lbnQiOiAiQ29tbWVudCBmb3IgY3JlYXRlIiwK ICAgICAgICAgImZpbGxmYWN0b3IiOiAiMTIiLAogICAgICAgICAiYW1uYW1lIjogImdpc3QiLAor ICAgICAgICAiY29uZGVmZXJyYWJsZSI6IHRydWUsCisgICAgICAgICJjb25kZWZlcnJlZCI6IHRy dWUsCisgICAgICAgICJpbmRjb25zdHJhaW50IjogImNvbDEgPiAxIiwKICAgICAgICAgImNvbHVt bnMiOiBbCiAgICAgICAgICAgewogICAgICAgICAgICAgImNvbHVtbiI6ICJjb2wyIiwKZGlmZiAt LWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNl cy9zY2hlbWFzL3RhYmxlcy9jb25zdHJhaW50cy9leGNsdXNpb25fY29uc3RyYWludC90ZXN0cy9k ZWZhdWx0L3Rlc3QuanNvbiBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2 ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy9jb25zdHJhaW50cy9leGNsdXNpb25fY29uc3Ry YWludC90ZXN0cy9kZWZhdWx0L3Rlc3QuanNvbgppbmRleCBiMmM1ZTY5YTQuLmVkNGYwOTFkNyAx MDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0 YWJhc2VzL3NjaGVtYXMvdGFibGVzL2NvbnN0cmFpbnRzL2V4Y2x1c2lvbl9jb25zdHJhaW50L3Rl c3RzL2RlZmF1bHQvdGVzdC5qc29uCisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dy b3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy9jb25zdHJhaW50cy9leGNsdXNp b25fY29uc3RyYWludC90ZXN0cy9kZWZhdWx0L3Rlc3QuanNvbgpAQCAtMTYsNyArMTYsNyBAQAog ICAgICAgICAgICJjbHR5cGUiOiAidGV4dCIKICAgICAgICAgfSwgewogICAgICAgICAgICJuYW1l IjogImNvbDMiLAotICAgICAgICAgICJjbHR5cGUiOiAiaW50ZWdlciIsCisgICAgICAgICAgImNs dHlwZSI6ICJpbnRlZ2VyIgogICAgICAgICB9XSwKICAgICAgICAgImlzX3BhcnRpdGlvbmVkIjog ZmFsc2UsCiAgICAgICAgICJzY2hlbWEiOiAidGVzdHNjaGVtYSIsCkBAIC0xMjYsMTAgKzEyNiwx MyBAQAogICAgICAgImVuZHBvaW50IjogIk5PREUtZXhjbHVzaW9uX2NvbnN0cmFpbnQub2JqIiwK ICAgICAgICJzcWxfZW5kcG9pbnQiOiAiTk9ERS1leGNsdXNpb25fY29uc3RyYWludC5zcWxfaWQi LAogICAgICAgImRhdGEiOiB7Ci0gICAgICAgICJuYW1lIjogIkV4Y2x1c2lvbl8kJXt9W10oKSYq XiFAXCInYFxcLyNfMSIsCisgICAgICAgICJuYW1lIjogIkV4Y2x1c2lvbl8kJXt9W10oKSYqXiFA XCInYFxcLyMiLAogICAgICAgICAiY29tbWVudCI6ICJDb21tZW50IGZvciBjcmVhdGUiLAogICAg ICAgICAiZmlsbGZhY3RvciI6ICIxMiIsCiAgICAgICAgICJhbW5hbWUiOiAiZ2lzdCIsCisgICAg ICAgICJjb25kZWZlcnJhYmxlIjogdHJ1ZSwKKyAgICAgICAgImNvbmRlZmVycmVkIjogdHJ1ZSwK KyAgICAgICAgImluZGNvbnN0cmFpbnQiOiAiY29sMSA+IDEiLAogICAgICAgICAiY29sdW1ucyI6 IFsKICAgICAgICAgICB7CiAgICAgICAgICAgICAiY29sdW1uIjogImNvbDIiLAo= --0000000000001cca0405b7316e30--