public inbox for [email protected]  

help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][RM3840] File Dialog: Retain the File Format Combobox status when toggle the "Show hidden files" checkbox
Date: Mon, 21 Jan 2019 15:24:16 +0530
Message-ID: <CAM9w-_=Y99eNm+++StapNtZ95AWoWdGZ=vxi7w9woEckCGVZ8g@mail.gmail.com> (raw)

Hi Hackers,

Attached is a tiny patch to fix a bug where file format combo box value is
not retained when hidden files checkbox is toggled.

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


Attachments:

  [application/octet-stream] RM3840.patch (837B, 3-RM3840.patch)
  download | inline diff:
diff --git a/web/pgadmin/misc/file_manager/static/js/utility.js b/web/pgadmin/misc/file_manager/static/js/utility.js
index c714f154..93891fc7 100644
--- a/web/pgadmin/misc/file_manager/static/js/utility.js
+++ b/web/pgadmin/misc/file_manager/static/js/utility.js
@@ -1176,11 +1176,11 @@ define([
           };
 
           if (cb.checked) {
-            $('div.allowed_file_types select').val('*').trigger('change');
+            $('div.allowed_file_types select').trigger('change');
             data['is_checked'] = true;
           } else {
             // User wants to hide it again
-            $('div.allowed_file_types select').prop('selectedIndex', 0).trigger('change');
+            $('div.allowed_file_types select').trigger('change');
             data['is_checked'] = false;
           }
           // Save it in preference

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][RM3840] File Dialog: Retain the File Format Combobox status when toggle the "Show hidden files" checkbox
  In-Reply-To: <CAM9w-_=Y99eNm+++StapNtZ95AWoWdGZ=vxi7w9woEckCGVZ8g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox