public inbox for [email protected]  
help / color / mirror / Atom feed
From: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Regarding opening user management in a tab - #8574
Date: Fri, 21 Mar 2025 11:45:51 +0530
Message-ID: <CAM9w-_=d9mF7TACj315bE2=e=y+KAH5E6RFgyA903wTOKUP9xw@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcpe98e41n3V8f3FrjCL2vVEnLc4yc14JUxy9veJ-d=sQ@mail.gmail.com>
References: <CAM9w-_m95H0iNjF4_fQUsou0f9=D3hEc53eCQViP+fTxc0G3kw@mail.gmail.com>
	<CAM9w-_kC9waVxitTqvGSzdE2s_vQHKuJ5oH0xDT8kH6d4D3Xxw@mail.gmail.com>
	<CANxoLDcpe98e41n3V8f3FrjCL2vVEnLc4yc14JUxy9veJ-d=sQ@mail.gmail.com>

Hi Akshay,

On Fri, Mar 21, 2025 at 11:28 AM Akshay Joshi <[email protected]>
wrote:

> Hi Aditya,
>
> I like the new design but it has the following drawbacks over the old
> design:
>
>    - In the new design, users of pgAdmin cannot create multiple new users
>    with a single click of the "Save" button.
>
> While this allowed multiple operations, it had hit the UI performance.

>
>    - Errors such as "Username/Email already exists" will now appear only
>    after clicking the "Save" button, rather than being shown as the user types
>    the username or email address, as in the previous design.
>
> If another user logged in and added a user then the newly added user was
not visible to the current logged in user as the list becomes old. I've
moved the duplicate check to the backend - where it will always check on
the latest data. Currently, it will throw an integrity failed error.

>
>    - In the old design, there was an option to reset if the user was
>    mistakenly deleted by default.
>
> We have a confirmation dialog before deleting which I think should be
enough. We have similar logic for database objects delete.

>
> I know we need create user dialog as in future we are going to add custom
> role in that dialog. Apart from above it looks good to me.
>

>

>
> On Thu, Mar 20, 2025 at 6:12 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> To add to my previous email, the user edit will now open a pop-up instead
>> of current in-table edit. Few of the users have reported sluggish UI
>> editing when having many users. That will be fixed with single user edit.
>> [image: image.png]
>>
>> On Thu, Mar 20, 2025 at 6:04 PM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> I've been working on making the user management open in a tab instead of
>>> a dialog for better user UX. The new design looks like below. Please note,
>>> once we start working on permissions (RBAC) we will add sub tabs - Roles
>>> and Permissions.
>>>
>>> [image: image.png]
>>>
>>> Please let me know if we need to change anything in this or any
>>> questions.
>>>
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>> <https://www.enterprisedb.com/;
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>> <https://www.enterprisedb.com/;
>> "Don't Complain about Heat, Plant a TREE"
>>
>

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [image/png] image.png (130.0K, 3-image.png)
  download | view image

  [image/png] image.png (141.0K, 4-image.png)
  download | view image

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Regarding opening user management in a tab - #8574
  In-Reply-To: <CAM9w-_=d9mF7TACj315bE2=e=y+KAH5E6RFgyA903wTOKUP9xw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox