Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iU3hr-0007nZ-6p for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Nov 2019 07:01:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iU3hp-0007C2-N9 for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Nov 2019 07:01:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iU3hp-0007Bv-7J for pgadmin-hackers@lists.postgresql.org; Mon, 11 Nov 2019 07:01:45 +0000 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iU3hl-0005ZB-36 for pgadmin-hackers@postgresql.org; Mon, 11 Nov 2019 07:01:42 +0000 Received: by mail-oi1-x242.google.com with SMTP id i185so10592842oif.9 for ; Sun, 10 Nov 2019 23:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H5KhAQvKg4/Qf+nBu75hUleIXeBu3rzimh1WIhm+m6k=; b=fiOQIZpSXSVA+9XX23gJGq4+MWOXwT9E1Dxg2+eg9x79AkjG0HlDK6mryPCpbJC5Di 4ToAJaDxxMqMtFlWiH+O1C+8A8hLMp2U+PgJuQOSvu7HQ9CAeB1Hkh7jMcYmXGlcQLXA kAgQmeAdXlSEaMoqNdW6p66lG2V/xxDifwuQz3oeqDc+i3bVz4An/RoFNwuTz3ewvmMP 9Jb2VFfFx/UGi2G579XcToRurdLC8K6gu82ZI0i7d4S5UGufZFAzTt9SFXkAOhL+za9n ange5291fR3aQHYKXWJezqdDWMdTDcu1nIwXpWoH5vjXjFIejZGOK2CBlFBQ26qs0Yan zJVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H5KhAQvKg4/Qf+nBu75hUleIXeBu3rzimh1WIhm+m6k=; b=oyRNPqcW43KKkpG0VBBCqSpNgrK7T/TWDZ74kFgJk/5p6eH5eYsbmNjZ9S2MRDlPDW HRYi6wKI8usZw1V1Fej8Z1wDI60kxFyJ5aouFGJDlAWkMEM6TLDeQBukucQNo/9xSFTx IyTAVV6R/TTxEkSr9BisB9R7MpjwWxnqBZBfTV0t4xsX1eZfiUiLc80ekLTFUVHKuqbR qRM+WCWQOTS0kj8Lz3YWUl7FmkGi7/paPer7dfFK05Pdp33jkNXc8NV79IMiezQi/qoD 1CC2W0B9gaXIzP+KXrUz2IobFtk1v0Qz8I/rbv/3zfDXlS7ZOq9h4nRRUB+PkmFonLWI d7nQ== X-Gm-Message-State: APjAAAVbhgubKOg+DcDlcczVphxxFj1UA1xusw5pwYGN7zEzWNbVLGuz MSDyCRDZLPoq2OTUPc9i7nN/z7pLq/PBMNCuNv0A8Lnexez3wnEohH3L+/mYoytqS9tIIIphKp1 XG8m5/Pj3+hivD4QKpB/jm/XBQXKLz6d8Ld+yH8xPmb2Mza2dzB9j4K/CQaOYDOfNHLeGSy8+Tw Li5T9y3sQoBSkvrUXRwqek7sdrdQHTqwkycN4ZT0C1+hyLoncLF9A= X-Google-Smtp-Source: APXvYqxVYBhV9SzhAOOirwi5Lj2bYLxBm6zmFYfp+GX3PMwPSGLXqOW6XJ5QtBnt6NWGb6h0B8e924bGjtnWlP9rfGA= X-Received: by 2002:aca:5a83:: with SMTP id o125mr15797655oib.24.1573455700040; Sun, 10 Nov 2019 23:01:40 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Mon, 11 Nov 2019 12:31:03 +0530 Message-ID: Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000012597205970cb418" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000012597205970cb418 Content-Type: text/plain; charset="UTF-8" Hi Dave, On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote: > > > On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote: > >> >> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the updated patch with few more changes and corrections. >>>> Kindly review. >>>> >>> >> I've committed a couple of minor tweaks - one to remove a space, e.g. >> >> gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'), >> >> is now: >> >> gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'), >> >> And another change to fix the word wrapping in the README which was >> totally different from the rest of the file. >> >> Thanks! >> > > Oh, and do we need all the code in config.py? I really didn't even want a > config option in there to turn theming on or off (what's the point?), let > alone 20 new lines. > The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py. I'll reduce the code a bit. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --00000000000012597205970cb418 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM D= ave Page <dpage@pgadmin.org>= wrote:


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <= dpage@pgadmin.org> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi = <aksh= ay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

<= div class=3D"gmail_quote">
On Thu, Nov= 7, 2019 at 6:39 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com&= gt; wrote:
Hi Hackers,
=

Attached is the updated patch with few more chan= ges and corrections.
Kin= dly review.

= I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to r=
efresh the page now ?'),
is now:
gettext('A =
page refresh is required to apply the theme. Do you wish to refresh the pag=
e now?'),
And another change to fix the word wra= pping in the README which was totally different from the rest of the file.<= /div>

Thanks!

Oh, and do we need all the code in config.py? I really didn't e= ven want a config option in there to turn theming on or off (what's the= point?), let alone 20 new lines.
The code i= s added after the config_local and config_distro is loaded. So, user won= 9;t be able to disable it unless he directly changes the config.py. I'l= l reduce the code a bit.

--
Dave Pa= ge
Blog: http:= //pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterpris= edb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB In= dia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"
=
--00000000000012597205970cb418--