MIME-Version: 1.0
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Fri, 4 Dec 2020 15:26:10 +0530
Message-ID: 
 <CAM9w-_=gmiWOhSDegMScZV1SX8FhFs6n7CRHE4b4D10B7bBpgA@mail.gmail.com>
Subject: [pgAdmin[RM6062] Code coverage does not cover function or class
 definitions
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000008fb89405b5a07e27"
Precedence: bulk

--0000000000008fb89405b5a07e27
Content-Type: multipart/alternative; boundary="0000000000008fb89305b5a07e25"

--0000000000008fb89305b5a07e25
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

Attached code will remove the existing code coverage code and recommend to
use the "coverage" command line instead.
Existing coverage does not cover class and function declarations.

Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"

--0000000000008fb89305b5a07e25
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif">Hi Hackers,</div><div class=3D"gmail_default" style=3D"font-fam=
ily:verdana,sans-serif"><br></div><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif">Attached code will remove the existing code co=
verage code and recommend to use the &quot;coverage&quot; command line inst=
ead.</div><div class=3D"gmail_default" style=3D"font-family:verdana,sans-se=
rif">Existing coverage does not cover class and function declarations.</div=
><div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif"><br>=
</div><div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif"=
>Please review.</div><div><br></div>-- <br><div dir=3D"ltr" class=3D"gmail_=
signature" data-smartmail=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"=
ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div><font size=3D"=
2" color=3D"#000000" face=3D"arial, sans-serif">Thanks,</font><div><span st=
yle=3D"color:rgb(34,34,34)"><span style=3D"color:rgb(18,22,70)"><font face=
=3D"arial, sans-serif">Aditya Toshniwal</font></span></span><font size=3D"2=
" color=3D"#000000" face=3D"verdana, sans-serif"><br></font></div><div><spa=
n style=3D"color:rgb(18,22,70);font-family:Arial,sans-serif">pgAdmin hacker=
</span><font size=3D"2" color=3D"#000000" style=3D"font-family:verdana,sans=
-serif">=C2=A0| </font><font size=3D"2" color=3D"#000000" face=3D"arial, sa=
ns-serif">Sr. Software Engineer</font><font size=3D"2" color=3D"#000000"><f=
ont face=3D"verdana, sans-serif"> | </font><a href=3D"http://edbpostgres.co=
m" target=3D"_blank"><font face=3D"arial, sans-serif" color=3D"#000000"><b>=
edbpostgres.com</b></font></a></font></div><div><font color=3D"#38761d" siz=
e=3D"1"><font face=3D"arial, sans-serif">&quot;Don&#39;t Complain about Hea=
t, Plant a TREE&quot;</font></font></div></div></div></div></div></div></di=
v></div></div>

--0000000000008fb89305b5a07e25--

--0000000000008fb89405b5a07e27
Content-Type: application/octet-stream; name="RM6062.patch"
Content-Disposition: attachment; filename="RM6062.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_kia3ezk10>
X-Attachment-Id: f_kia3ezk10

ZGlmZiAtLWdpdCBhLy5naXRpZ25vcmUgYi8uZ2l0aWdub3JlCmluZGV4IDUwMjc0ZjRkOS4uMzFi
OGQ2NWE4IDEwMDY0NAotLS0gYS8uZ2l0aWdub3JlCisrKyBiLy5naXRpZ25vcmUKQEAgLTUxLDQg
KzUxLDggQEAgYXVkaXRqcy5odG1sCiBhdWRpdHB5LnR4dAogL3ZlbnYvCiAuc2Nhbm5lcndvcmsv
Ci13ZWIvY292ZXJhZ2UvClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQord2ViL2NvdmVyYWdl
Lword2ViLy5jb3ZlcmFnZQord2ViL3JlZ3Jlc3Npb24vLmNvdmVyYWdlCit3ZWIvcmVncmVzc2lv
bi9jb3ZodG1sLword2ViL3JlZ3Jlc3Npb24vaHRtbGNvdi8KZGlmZiAtLWdpdCBhL3dlYi9yZWdy
ZXNzaW9uL1JFQURNRSBiL3dlYi9yZWdyZXNzaW9uL1JFQURNRQppbmRleCBhMTdiZDk1NWQuLmM1
MmVmOTQ3OCAxMDA2NDQKLS0tIGEvd2ViL3JlZ3Jlc3Npb24vUkVBRE1FCisrKyBiL3dlYi9yZWdy
ZXNzaW9uL1JFQURNRQpAQCAtMjc5LDEzICsyNzksMTYgQEAgSG93IHRvIGdlbmVyYXRlIGNvZGUg
Y292ZXJhZ2UgcmVwb3J0IGZvciBBUEkgdGVzdC1zdWl0ZT8KIAogLSBSdW4gY292ZXJhZ2UKICAg
ICBXaXRoIGFsbCBtb2R1bGVzCi0gICAgICAgIHJ1biAncHl0aG9uIHJ1bnRlc3RzLnB5IC0tY292
ZXJhZ2UgLS1leGNsdWRlIGZlYXR1cmVfdGVzdHMnCisgICAgICAgIHJ1biBgY292ZXJhZ2UgcnVu
IC4vcnVudGVzdHMucHkgLS1leGNsdWRlIGZlYXR1cmVfdGVzdHNgCiAgICAgV2l0aCBzcGVjaWZp
YyBtb2R1bGUKLSAgICAgICAgcnVuICdweXRob24gcnVudGVzdHMucHkgLS1wa2cgYnJvd3Nlci5z
ZXJ2ZXJfZ3JvdXBzLnNlcnZlcnMudGVzdHMgLS1jb3ZlcmFnZScKLQotLSBBZnRlciBleGVjdXRp
b24gb2YgY292ZXJhZ2UsIHdlIHdpbGwgc2VlIGNvZGUgY292ZXJhZ2UgcmVwb3J0IG9uIGNvbnNv
bGUuCi0gIEZvciBhIG5pY2VyIHByZXNlbnRhdGlvbiwgJy9yZWdyZXNzaW9uL2Nvdmh0bWwnIGRp
cmVjdG9yeSBnZXRzIGNyZWF0ZWQuCi0gIE9wZW4gJ2luZGV4Lmh0bWwnIGZpbGUgaW4gYnJvd3Nl
ciBhbmQgeW91IHdpbGwgc2VlIGRldGFpbCBjb3ZlcmFnZSByZXBvcnQuCisgICAgICAgIHJ1biBg
Y292ZXJhZ2UgcnVuIC4vcnVudGVzdHMucHkgLS1leGNsdWRlIGZlYXR1cmVfdGVzdHMgLS1wa2cg
YnJvd3Nlci5zZXJ2ZXJfZ3JvdXBzLnNlcnZlcnMudGVzdHNgCisKKy0gQWZ0ZXIgZXhlY3V0aW9u
IG9mIGNvdmVyYWdlLCB5b3UgY2FuIHJ1biB0aGUgZm9sbG93aW5nIHRvIHNlZSB0aGUgY29kZSBj
b3ZlcmFnZSByZXBvcnQ6CisgICAgTm9ybWFsIHJlcG9ydDoKKyAgICAgICAgcnVuIGBjb3ZlcmFn
ZSByZXBvcnRgCisgICAgSFRNTCByZXBvcnQ6CisgICAgICAgIHJ1biBgY292ZXJhZ2UgaHRtbGAK
KyAgICAgICAgVGhpcyB3aWxsIGNyZWF0ZSBhIGRpcmVjdG9yeSAnaHRtbGNvdicuIE9wZW4gJ2lu
ZGV4Lmh0bWwnIGZpbGUgaW4gYnJvd3NlciBhbmQgeW91IHdpbGwgc2VlIGRldGFpbCBjb3ZlcmFn
ZSByZXBvcnQuCiAKIEphdmFzY3JpcHQgVGVzdHM6CiAKZGlmZiAtLWdpdCBhL3dlYi9yZWdyZXNz
aW9uL3J1bnRlc3RzLnB5IGIvd2ViL3JlZ3Jlc3Npb24vcnVudGVzdHMucHkKaW5kZXggNmIxZDMx
NzFlLi5hNjIzNThmYWMgMTAwNjQ0Ci0tLSBhL3dlYi9yZWdyZXNzaW9uL3J1bnRlc3RzLnB5Cisr
KyBiL3dlYi9yZWdyZXNzaW9uL3J1bnRlc3RzLnB5CkBAIC0xOSw3ICsxOSw2IEBAIGltcG9ydCBz
eXMKIGltcG9ydCB0cmFjZWJhY2sKIGltcG9ydCBqc29uCiBpbXBvcnQgcmFuZG9tCi1pbXBvcnQg
Y292ZXJhZ2UKIGltcG9ydCB0aHJlYWRpbmcKIGltcG9ydCB0aW1lCiBpbXBvcnQgdW5pdHRlc3QK
QEAgLTQ5LDggKzQ4LDYgQEAgaWYgc3lzLnBhdGhbMF0gIT0gcm9vdDoKIGZyb20gcGdhZG1pbiBp
bXBvcnQgY3JlYXRlX2FwcAogaW1wb3J0IGNvbmZpZwogCi1DT1ZFUkFHRV9DT05GSUdfRklMRSA9
IG9zLnBhdGguam9pbihDVVJSRU5UX1BBVEgsICIuY292ZXJhZ2VyYyIpCi0KIGlmIGNvbmZpZy5T
RVJWRVJfTU9ERSBpcyBUcnVlOgogICAgIGNvbmZpZy5TRUNVUklUWV9SRUNPVkVSQUJMRSA9IFRy
dWUKICAgICBjb25maWcuU0VDVVJJVFlfQ0hBTkdFQUJMRSA9IFRydWUKQEAgLTM1Nyw4ICszNTQs
NiBAQCBkZWYgYWRkX2FyZ3VtZW50cygpOgogICAgICAgICBoZWxwPSdTa2lwcyBleGVjdXRpb24g
b2YgdGhlIHRlc3QgY2FzZXMgb2YgcGFydGljdWxhciBwYWNrYWdlIGFuZCAnCiAgICAgICAgICAg
ICAgJ3N1Yi1wYWNrYWdlcycKICAgICApCi0gICAgcGFyc2VyLmFkZF9hcmd1bWVudCgnLS1jb3Zl
cmFnZScsIG5hcmdzPSc/JywgY29uc3Q9VHJ1ZSwgdHlwZT1ib29sLAotICAgICAgICAgICAgICAg
ICAgICAgICAgZGVmYXVsdD1GYWxzZSwgaGVscD0nRW5hYmxlIGNvZGUgY292ZXJhZ2UgZmVhdHVy
ZScpCiAgICAgcGFyc2VyLmFkZF9hcmd1bWVudCgKICAgICAgICAgJy0tZGVmYXVsdF9icm93c2Vy
JywKICAgICAgICAgaGVscD0nRXhlY3V0ZXMgdGhlIGZlYXR1cmUgdGVzdCBpbiBzcGVjaWZpYyBi
cm93c2VyJwpAQCAtNzc2LDExICs3NzEsNiBAQCBpZiBfX25hbWVfXyA9PSAnX19tYWluX18nOgog
ICAgIGlmIGFyZ3NbJ3BrZyddIGlzIG5vdCBOb25lOgogICAgICAgICBub2RlX25hbWUgPSBhcmdz
Wydwa2cnXS5zcGxpdCgnLicpWy0xXQogCi0gICAgIyBTdGFydCBjb3ZlcmFnZQotICAgIGlmIHRl
c3RfdXRpbHMuaXNfY292ZXJhZ2VfZW5hYmxlZChhcmdzKToKLSAgICAgICAgY292ID0gY292ZXJh
Z2UuQ292ZXJhZ2UoY29uZmlnX2ZpbGU9Q09WRVJBR0VfQ09ORklHX0ZJTEUpCi0gICAgICAgIGNv
di5zdGFydCgpCi0KICAgICAjIENoZWNrIGlmIGZlYXR1cmUgdGVzdHMgaW5jbHVkZWQgJiBwYXJh
bGxlbCB0ZXN0cyBzd2l0Y2ggcGFzc2VkCiAgICAgaWYgdGVzdF91dGlscy5pc19mZWF0dXJlX3Rl
c3RfaW5jbHVkZWQoYXJncykgYW5kIFwKICAgICAgICAgICAgIHRlc3RfdXRpbHMuaXNfcGFyYWxs
ZWxfdWlfdGVzdHMoYXJncyk6CkBAIC04ODcsMTUgKzg3Nyw2IEBAIGlmIF9fbmFtZV9fID09ICdf
X21haW5fXyc6CiAgICAgICAgICAgICByYWlzZQogICAgICAgICBwcmludF90ZXN0X3Jlc3VsdHMo
KQogCi0gICAgIyBTdG9wIGNvZGUgY292ZXJhZ2UKLSAgICBpZiB0ZXN0X3V0aWxzLmlzX2NvdmVy
YWdlX2VuYWJsZWQoYXJncyk6Ci0gICAgICAgIGNvdi5zdG9wKCkKLSAgICAgICAgY292LnNhdmUo
KQotCi0gICAgIyBQcmludCBjb3ZlcmFnZSBvbmx5IGlmIGNvdmVyYWdlIGFyZ3MgZ2l2ZW4gaW4g
Y29tbWFuZCBsaW5lCi0gICAgaWYgdGVzdF91dGlscy5pc19jb3ZlcmFnZV9lbmFibGVkKGFyZ3Mp
OgotICAgICAgICB0ZXN0X3V0aWxzLnByaW50X2FuZF9zdG9yZV9jb3ZlcmFnZV9yZXBvcnQoY292
KQotCiAgICAgcHJpbnQoIlBsZWFzZSBjaGVjayBvdXRwdXQgaW4gZmlsZTogJXMvcmVncmVzc2lv
bi5sb2dcbiIgJSBDVVJSRU5UX1BBVEgpCiAKICAgICAjIFVuc2V0IGVudmlyb25tZW50IHZhcmlh
YmxlCg==
--0000000000008fb89405b5a07e27--