Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goSxr-0003MP-SV for pgadmin-hackers@arkaria.postgresql.org; Tue, 29 Jan 2019 12:58:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1goSxq-0006Tz-F8 for pgadmin-hackers@arkaria.postgresql.org; Tue, 29 Jan 2019 12:58:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goSxq-0006I4-3g for pgadmin-hackers@lists.postgresql.org; Tue, 29 Jan 2019 12:58:06 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goSxl-0003Wy-0w for pgadmin-hackers@postgresql.org; Tue, 29 Jan 2019 12:58:05 +0000 Received: by mail-lj1-x243.google.com with SMTP id v1-v6so17428661ljd.0 for ; Tue, 29 Jan 2019 04:58:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IOPlwAtXGglfoX+cHn+hX0tUOps3gdqEIpA/+vsU5eU=; b=kDjDBNuZUYS1wTyVOdnrlanohfunDXwq64Y7Nyubdxfo+RTobdIToTyV4MphfGmn06 wl+ZmO5aj1N45kEuamtZNfKm3IJhW0lRPAzEbJ6/g4+cxIFVvhBo6HimiMCnulmpjoi/ yK6hAc5fG9thQzRqRmoBJsyPLkO80wOW/btTkKUwb0ShAoD+1d9py3DkmNEF8nVPC7dA kS7jmDjdnbOhelwk0Uel5Uz7v7ORypzv5D8+tDQvWIMOQzLwabkSkyL1XeYGIv1KErq7 cxD1gsex9GJaj0fZQ+fE4w+433F8k22aOjoSs36GywlhRA+h/lWRPPGz9F0rMvQGqXuu lBnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IOPlwAtXGglfoX+cHn+hX0tUOps3gdqEIpA/+vsU5eU=; b=CuX45VlvWfvoiE/f8QBD2+cZlN+ftHjqTlMqmCibrwmAfg9ZjY8rjJcOjTyL8iVpL1 v/O235cSMkUcU154Qi1VEfs33Xy/V8AgklpgohTA8Vum8cjgwPVq02GintGVyVquFZBE gQE3DRZuGu/qv3DdZOsCxFEdN7KDY6GP+x+N+7cjSpsG1toOFKXh0SSCmMy7U0ZKhYMI A1wUhiV4O4Asy7Sg6YvxZa+E6MB7XWlZJT1ngMxp9Q5FeHMXj0ARS2VZiIPEKy30Ci99 oFGCtRawboMLbQE78oPGuHi+sRzbaoe/c7ISmzMe0amXFg76h5KnSHOE2OABXNgpOqsW Fa4Q== X-Gm-Message-State: AJcUukcdYt52gvAhZ+1ys8qqtvzeCccnROD8HQw7CBlrcVF8NqntZPMR Fgbr6QAxgevWbuj41jFmuetN/weY1G7NWLq9Rsve5A== X-Google-Smtp-Source: ALg8bN45n+V1ObyEitxpMb7R/AsqPyeSd+EP+Djjmrk19nefe0kyv8T3HvHCVUoogEMmmgA9xqLQlXwsDikG6hUhxcA= X-Received: by 2002:a2e:4784:: with SMTP id u126-v6mr20657883lja.124.1548766679382; Tue, 29 Jan 2019 04:57:59 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Tue, 29 Jan 2019 18:27:48 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c3d7350580985721" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c3d7350580985721 Content-Type: text/plain; charset="UTF-8" Hi Akshay, The patch looks good to me. On Tue, Jan 29, 2019 at 4:54 PM Dave Page wrote: > Aditya, can you review this please? Once you're happy, Akshay can commit. > > On Tue, Jan 29, 2019 at 9:35 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix RM 3697 Detached Data Output Tab (Windows) >> does not show Select output. Please review it. >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" --000000000000c3d7350580985721 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,

The patch looks=C2=A0good to me.
On Tue, J= an 29, 2019 at 4:54 PM Dave Page <d= page@pgadmin.org> wrote:
Aditya, can you review this please? Once y= ou're happy, Akshay can commit.

On Tue, Jan 2= 9, 2019 at 9:35 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
<= div dir=3D"ltr">Hi Hackers,

Attached is the patch to fix= =C2=A0RM 3697 Detached Data Output Tab (Windows) does not show Select outpu= t. Please review it.

--
= Akshay Joshi
Sr. Software = Architect

<= /font>

=
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blog= spot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company


--
Thanks and Rega= rds,
Aditya Toshniwa= l
Softw= are Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
&q= uot;Don't Complain about Heat, Plant a tree"
--000000000000c3d7350580985721--