Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jEUVy-0000jq-Gr for pgadmin-hackers@arkaria.postgresql.org; Wed, 18 Mar 2020 08:57:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jEUVx-0005Cy-8r for pgadmin-hackers@arkaria.postgresql.org; Wed, 18 Mar 2020 08:57:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jEUVx-0005Cq-01 for pgadmin-hackers@lists.postgresql.org; Wed, 18 Mar 2020 08:57:25 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jEUVv-0007c4-Bx for pgadmin-hackers@postgresql.org; Wed, 18 Mar 2020 08:57:24 +0000 Received: by mail-ed1-x52d.google.com with SMTP id b23so29991836edx.4 for ; Wed, 18 Mar 2020 01:57:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YSD0/BjVItSQ9+YToisaaHvN83ge7rK5B3Kw3iAJBfc=; b=mmNkkYlJ3Bi8q1f7frnjbsKoU76mvBCBs4Xap+ElomfbzSEWNAcHxEl6atVb68zjpw mlcBpdkuAnpzYwxDy4c3340XE91JknuFu9md0X7BBQD8lPjBVC4l/jaAduCe3V5F/TnD ZVXPOnAY7yxeJxLV0HH1GTDX85NYcKrF+bN9ybTiY3R9ZV7qaqdKsg12eth7X0dmfNcX sUEq4VbYTFkD28Ljdd2A1YnUkLbpXv22rCOA1fpJ2cK1W1gNhZmxDSKwzIZZlwJ50YPd dyEvQ/Qg/qR0FLpfzNBgssUxxq/hTWRwLaJ9mH+y6jqmja9F1zbBVtMHCoxlwDIvUWu3 PZcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YSD0/BjVItSQ9+YToisaaHvN83ge7rK5B3Kw3iAJBfc=; b=QL76abcDxM84kAEiE3VLkWtbKbuePlw9BObcw5R2fAzDI3m2/ossCC60KL8XgU0VrI 2xrYYJkiDxSmYak+Sr5/R6zLlMnv+Qal5uYTWyzFGYQjOZfGjtIMF/0yp38FSdKkyqiw yASNF0NCZJyapcQScO+IP9r+EeKiVGL7OiQkSz9jbNRPATJY29alEpxmuvMHucfiJ4Zx /PRvI57cePVdu8JU9V3TL7UfgNDkprbfbU1H1egb8QjURQOc9NL9OUcs1uIWNP1m0tGb SKRJnC+Y+6JbSHVmPQTZmULpr1hDtMS6k3lfVItAKbr0ECn2dxo0MQ4nE2MJoRy1QCFl k+Tw== X-Gm-Message-State: ANhLgQ2K4/mULYk2NScPcxKe9n7HvyWXyRdGUa8+tkZ1tU5wsw4UbKp6 uECWFCZPwxVjMQKx+hiQYNz1Pxc11dGSUBeU8XXHFKxMNjPxnOA91d2yDkh+9s4goWftPX67dc0 GxikY5ZUbw6npZtJMMNdiuUNMt3i0zTencJxZySh+Q3LXjcHNrfUN/ouU8s0yHHeAvcIJyruk2e QnmBBUDli18evSqd/42dTeRGuWYaSNiFOHAJ8b2H7WUDx81I9SJQ4axQ== X-Google-Smtp-Source: ADFU+vsjKs+Lm42P6e2r0tEj9ecGHFfPxvNYRqptYtMYJoAW7YfU35C2Ki5R9Fn+jWrnopu5pjrVLGBQ1x/yeFP3S+Y= X-Received: by 2002:a05:6402:19a7:: with SMTP id o7mr2850227edz.106.1584521841061; Wed, 18 Mar 2020 01:57:21 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Wed, 18 Mar 2020 14:26:44 +0530 Message-ID: Subject: Re: [pgAdmin4][RM 5271] To change the switch control colors To: Chethana Kumar Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000079ca5a05a11d3d28" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000079ca5a05a11d3d28 Content-Type: text/plain; charset="UTF-8" Hi Murtuza/Chethana, Irrespective of what color you suggest, there is no need to add new variables for switch buttons. It should use success for on and ternary for off. Having a separate green color for each and every control is absurd. If the green changes, it should change for all. On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar < chethana.kumar@enterprisedb.com> wrote: > Let us discuss on a call for better clarity and the conclusion part we can > put it on mail. > > --- > Chethana kumar > > On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hi Chethana, >> >> No it is not, As per current dark theme implementation we have used >> primary color '#1a522b' for switch but the color you suggested is '#43A047' >> for both theme. >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> >> On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar < >> chethana.kumar@enterprisedb.com> wrote: >> >>> Hi Murtuza, >>> >>> The changes are already incorporated so no worries :) >>> >>> Thanks, >>> >>> --- >>> Chethana kumar >>> >>> On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Hello, >>>> >>>> As per discussion with Chethana, We need to make switch box color >>>> change for light and dark theme, Color details provided by Chethana is >>>> updated on ticket. >>>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>> >>> -- >>> Chethana Kumar >>> Principal UI/UX Designer >>> EnterpriseDB Corporation >>> >>> The Postgres Database Company >>> >>> P: +91 86981 57146 >>> www.enterprisedb.com >>> >> > > -- > Chethana Kumar > Principal UI/UX Designer > EnterpriseDB Corporation > > The Postgres Database Company > > P: +91 86981 57146 > www.enterprisedb.com > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --00000000000079ca5a05a11d3d28 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Murtuza/Chethana,

Irrespective of what color you sugges= t, there is no need to add new variables for switch buttons. It should use = success for on and ternary for off.
Having a separate green color for each = and every control is absurd. If the green changes, it should change for all= .

On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar <chethana.kumar@enterprisedb.com> w= rote:
Let us discuss on a call for better clarity and the conclusion par= t we can put it on mail.

---
Chethana kumar

On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala <murtuza.zabuawala@ent= erprisedb.com> wrote:
Hi Chethana,

No it = is not, As per current dark theme implementation=C2=A0we have used primary = color '#1a522b' for switch but the color you suggested is '#43A047' for bo= th theme.


--
Regards,
Murtuza Zabuawala
Enterprise= DB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany


<= /div>

On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar <chethana.kumar@ente= rprisedb.com> wrote:
Hi Murtuza,

The changes are= already incorporated so no worries :)

Thanks,

---
Chethana kumar

On Wed, Mar 18, 202= 0 at 12:43 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>= wrote:
= Hello,

As per discussion with Chethana, We need to make swit= ch box color change for light and dark theme, Color details provided by Che= thana is updated on ticket.
=C2=A0

--
Regards,
Murtuza Za= buawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The En= terprise PostgreSQL Company
=
<= /div>


--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation

The Postgres Database Company

P: +91 86981= 57146
=


--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation

The Postgres Database Company

P: +91 86981= 57146
=


--
Thanks and Regards,Aditya Toshniwal
pgAdmin Hacker | Sr. S= oftware Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat= , Plant a TREE"
=
--00000000000079ca5a05a11d3d28--