Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kohJ5-00080G-QN for pgadmin-hackers@arkaria.postgresql.org; Mon, 14 Dec 2020 06:26:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kohJ4-0001gs-Jb for pgadmin-hackers@arkaria.postgresql.org; Mon, 14 Dec 2020 06:26:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kohJ4-0001gD-5o for pgadmin-hackers@lists.postgresql.org; Mon, 14 Dec 2020 06:26:02 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kohJ1-0006A2-5m for pgadmin-hackers@postgresql.org; Mon, 14 Dec 2020 06:26:01 +0000 Received: by mail-lf1-x144.google.com with SMTP id o19so1651556lfo.1 for ; Sun, 13 Dec 2020 22:25:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8TBRzIRcVH3N76+0ggQWUXQHrhIeyoeQO4NH60FxMwk=; b=yJDP9ucZN5KQWI2HP2+Vmn1qrkIDHyA4q7X02a7I/L3Hes+b2gmE9/ih0bDVqVKsyI 6FHbqCsUrIJ4cFGOQ+PBSZTHbReEUAbahVuJsv+4z/OaOZCqDkVW14Lutg7oVCvgsGiC c44csZH4RDaoSFG6SM7OMOhNtZiMd/iCcPpYsHXPseWRZwNjbytlVTMUzkkiJjF64NE9 c+gY49yKLRT3ZC6i/zCmWKprYcqKM3ok3HQKUOIq0wlMcer0bJTKoxLWnGDv1ShUUPe7 9nLVbm+Q2az+xk0yggzJ+pEf0Cvo+T6RZfIsy0z1SVupxI370tQLslWS9PBIlGdtdfYG kU3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8TBRzIRcVH3N76+0ggQWUXQHrhIeyoeQO4NH60FxMwk=; b=alHfSEz/NA0kFnA+NkiJqG1VDKRJjQ2YWJV3Xy0xDmoxxanjrZht5GstrQzED67xKS gwzUWfGYToZQyNRNDNeVhgbOA5NkwJNTI3tv+N5UAdVx4h98kJd+fVynCDIUBRMwCh8p nyHhB00dr9K+wNv7KE5f0W1LZdyTNffncXaL9pbrX+uJtdqVhZljVeraJWPRW6Oj0/6s pdc/TyZxVt/8IkvW9wE6t2UQ8LSV92+s9LlTRtVCulcRDFrQ5rKoKOq9se2xCb+HeukV hzHg0iK//clyfQP4lBkJCLU7iI0GBsO8xPTaclDYVtllv+22/Duugs0Lm0ZjmuPIDbfJ vTXQ== X-Gm-Message-State: AOAM530BGlPOArr6u6Pd+YeBYk0Hxe+8jiiEveTUbSPPcuBevKmrx09/ lvZZ2lou2sQFwCf/Vi3AmeYKsBtNfFxHnDEvaV6+ZI2rcZuyUulMsX54dAoIDrXdFTx+E/S1uoY dNCbbaD4usXcRd4Ew5mhjbr/1dWrGvbjuouL8ZVgL/+xfzz50ip/vAU6fE775mfhOd563o9k3SF n2NmgNpGCN3PtmVkdJUq4QxDLU/TFn7FUZ+7NauadYJR/O7CUl/WAGTRlVCg== X-Google-Smtp-Source: ABdhPJwuuPBBreTlq4T94VTcQyOLVgGQ+Ez5otzhRX5KnaVSejfzhM1sr/ZF57gZrGUjt+SpHdF8/atjxQaGWTyrN2U= X-Received: by 2002:a2e:b548:: with SMTP id a8mr9754600ljn.83.1607927157338; Sun, 13 Dec 2020 22:25:57 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Mon, 14 Dec 2020 11:55:21 +0530 Message-ID: Subject: Re: [pgAdmin4] RM5965 Couldn't download file of Marcos query results To: Rahul Shirsat Cc: pgadmin-hackers , Akshay Joshi Content-Type: multipart/alternative; boundary="00000000000009cda105b666b78a" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000009cda105b666b78a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Rahul, The file in the patch - *web/regression/javascript/sqleditor/query_tool_preferences.js* is a copy of *web/pgadmin/static/js/sqleditor/query_tool_preferences.js* and is not a test case file. @committer - Please remove the file *web/regression/javascript/sqleditor/query_tool_preferences.js* before committing. Apart from this, the patch looks good to me. On Thu, Dec 10, 2020 at 6:55 PM Rahul Shirsat < rahul.shirsat@enterprisedb.com> wrote: > Hi Aditya/Akshay, > > On Wed, Dec 9, 2020 at 2:59 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hello Rahul, >> >> Found below issues: >> 1) The data grid is not fetching more than 1000 records now, gives a >> console error: >> sqleditor.js:1264 Uncaught TypeError: self.enable_disable_download_btn i= s >> not a function >> at child.fetch_next (sqleditor.js:1264) >> > *Fixed* > >> >> 2) The sqleditor test cases are failing. >> > *This has been taken care of, and added more test cases. * > >> 3) Fix pep8 issues. >> 4) Fix linter issues. >> > *Sorry for these issues, last minute code changes* =F0=9F=98=A3 > >> 5) Please check the doc changes again, it's not clear to me. >> > *This has been corrected now.* > >> >> I didn't check but make sure the GUI tests for the sqleditor runs fine >> since the behaviour has changed now. >> > *These are fixed now.* > >> >> On Wed, Dec 9, 2020 at 1:53 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> Can you please review this patch? >>> >>> On Mon, Dec 7, 2020 at 3:10 PM Rahul Shirsat < >>> rahul.shirsat@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Please find the updated patch below. >>>> >>>> On Mon, Dec 7, 2020 at 2:55 PM Rahul Shirsat < >>>> rahul.shirsat@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Please find the attached patch which resolves the issue of macros >>>>> query results download, have used async cursor to achieve this >>>>> functionality, where for downloading the results, cursor is scrolled = back >>>>> to 0 and end of the records, and reset again while user scrolling on = Data >>>>> Output table. >>>>> >>>>> QA/Reviewer needs to observe below issues if it occurs: >>>>> >>>>> 1. If records are more like 5000 or 10000, try to fetch records by >>>>> scrolling at least (2000), now save the results by clicking the do= wnload >>>>> button, it should save the file, and now try scrolling again, the = data >>>>> should be shown continuously and not any abrupt end or unexpected = records >>>>> order. >>>>> 2. Also, the download button is now "Save results to CSV/TXT" >>>>> where it will only get enabled when there are valid records in the= Data >>>>> Output. >>>>> >>>>> >>>>> Also a minor fix of the add folder icon issue is also added into this >>>>> patch. >>>>> >>>>> -- >>>>> *Rahul Shirsat* >>>>> Senior Software Engineer | EnterpriseDB Corporation. >>>>> >>>> >>>> >>>> -- >>>> *Rahul Shirsat* >>>> Software Engineer | EnterpriseDB Corporation. >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > --=20 Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --00000000000009cda105b666b78a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Rahul,

The file= in = the patch - web/regression/javascript/sqleditor/query_tool_prefer= ences.js is a copy of web/pgadmin/static/js/sqleditor/query_tool_pre= ferences.js and is not a test case file.

@committer - Please rem= ove the file web/regression/javascript/sqleditor/query_tool_preferences.= js before committing.
= Apar= t from this, the patch looks good to me.

<= /div>

On Thu, Dec 10, 2020 at 6:55 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Aditya/Akshay,

<= div dir=3D"ltr" class=3D"gmail_attr">On Wed, Dec 9, 2020 at 2:59 PM Aditya = Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hello Rahul,

Found below issues:
1= ) The data grid is not fetching more than 1000 records now, gives a console= error:
sqleditor.js:126= 4 Uncaught TypeError: self.enable_disable_download_btn is not a function=C2=A0 =C2=A0 at child.fetch_next (sqleditor.js:1264)
=C2=A0Fixed
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">

2) The sqleditor test cases are failing.
=C2=A0This has been taken care of, and added more test case= s.=C2=A0
3) Fix pep8 issues.=
4) Fix linter issues.
=C2=A0Sorry for these issues, last minute co= de changes=C2=A0=F0=9F=98=A3=C2=A0
5) Please check the doc changes again, it's not clear to me.
=C2=A0This has been corrected now.=C2=A0

I didn't check but make sure the GUI tests for t= he sqleditor runs fine since the behaviour has changed now.
=C2=A0These are fixed now.=C2=A0

On Wed, Dec 9, 2020 at 1:53 PM Akshay Joshi &= lt;aksha= y.joshi@enterprisedb.com> wrote:
Hi Aditya

Can y= ou please review this patch?

On Mon, Dec 7, 2020 at 3:10 PM Rahul Shir= sat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

<= /div>
Please find the updated patch below.

On Mon, Dec 7, 2020 at = 2:55 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
Hi Hacker= s,

Please find the attached patch which resolves the iss= ue of macros query results download, have used async cursor to achieve this= functionality, where for downloading the results, cursor is scrolled back = to 0 and end of the records, and reset again while user scrolling on Data O= utput table.

QA/Reviewer needs to observe below is= sues if it occurs:
  1. If records are more like 5000 or 10000= , try to fetch records by scrolling at least=C2=A0(2000), now save the resu= lts by clicking the download button, it should save the file, and now try s= crolling again, the data should be shown continuously and not any abrupt en= d or unexpected records order.
  2. Also, the download button is now &qu= ot;Save results to CSV/TXT" where it will only get enabled when there = are valid records in the Data Output.

Al= so a minor fix of the add folder icon issue is also added into this patch.<= /div>

--
Rahul Shirsat<= br>
Senior Software Engineer=C2=A0|=C2=A0EnterpriseD= B=C2=A0Corporation.


--
Rahul Shirsat
Software Engineer=C2= =A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Rahul Shirsat
Software Engineer=C2= =A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Softwa= re Engineer | edbpostgres.com<= /font>
"Don't Complain about Heat, Plant a TREE&qu= ot;
--00000000000009cda105b666b78a--