Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ikist-0005pr-T4 for pgadmin-hackers@arkaria.postgresql.org; Fri, 27 Dec 2019 06:14:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ikisr-0004l9-E5 for pgadmin-hackers@arkaria.postgresql.org; Fri, 27 Dec 2019 06:14:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ikisq-0004l1-OQ for pgadmin-hackers@lists.postgresql.org; Fri, 27 Dec 2019 06:14:01 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ikisi-0007ii-VS for pgadmin-hackers@postgresql.org; Fri, 27 Dec 2019 06:13:59 +0000 Received: by mail-ed1-x543.google.com with SMTP id v28so24388061edw.12 for ; Thu, 26 Dec 2019 22:13:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=nrVevk0jNwzr/NyBedw5dms4TIA8QUzQePAy/DohZ4E=; b=Kmv+8fAIxNfR14oeJk5c5UOYEnajRmYpauDOk9qpIP4/HhbmXY0eydDLekksDZMxYR 2e2c9RcvF4Qm+S45u7rWXNJlvFCh8x4SvNwe2OhYlkG6Z5RkBMXZ1JVUsK3pIY9nGSWh tchhTwKE4jlt2k5Xf1KSbQFCRl5sgPAkEHu3w0fc6QcZHpMPujibm06BhHKFqmuPV7dy ykCosOjWCxRYtl/bp+sN0FVfDFT3JANSQr3ER+WRYT12GQVl4YsDlhmU6mI4iuZa8Xdm 21s6udy7VTgs0voPYio6+2BZGon/h0BktxfOk8joj6wdtQD9O2wxp8Qdz3pIswxBgOiq XpxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=nrVevk0jNwzr/NyBedw5dms4TIA8QUzQePAy/DohZ4E=; b=rw8wW1ulzewbN0IiTvg2eVlv8cma7ooiCZPE2x427F3fGH+93RsR6xmqtfl+6fCYz4 k/ZUi9B96pxAtS6U7kW8tIlcueyOYL//wwDab5V6ib86VlCKw/0EzGG+olg5fvrRh20p QY2eLGq3In2QnZVj7Dpfn72LoCakjsdBWitZDERnPYhtP7kJ/XWZYswKjEN8JBSNnGSd jX8t5HomLGSWf1zkulPyrk2igeThr8lGmRm8s15VhVPP0AeHfrx4QI9ljxOS6dfgMbA9 ijpJfgQ+oQcX5ebBt8LV9YFxEqtrALg/cxPwueLKcYPNmm4ttYCV06gb5HlQtu9Mwt2R kW6Q== X-Gm-Message-State: APjAAAVU/aCi461ahUL/NOz3/1oFsSqoWCSGIu3tN5Bo0WKZ4k44x7om zf41QW5Zl7gBxI5JVBAVMFk3NXkEWztm3wjP9d/EihPcVwhz3GxEDxItkSjwXugsoBDCnvMG3fV 6wjXcEcI7W51QM8wqKK4oCSFuIDpbFFMkd78Hi6B8GsqeVnyGdM3rDOLUsHOe6PwnAzbLf3Hg1U yu3mAdm7WjwABEEzyBF6uuc/fy6lPe/LpoDBUJdIU5JSZY97T+IHq9giSTUg0= X-Google-Smtp-Source: APXvYqzc5M4PNUdUXFaiOBCAZBnUlH0XdZeSuDpToUVMXUYp4mmdEkz1jjA0tPvAtpNEMXFxZwhoyJla1cEFO46tXvw= X-Received: by 2002:a50:eb04:: with SMTP id y4mr52863779edp.170.1577427229841; Thu, 26 Dec 2019 22:13:49 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Fri, 27 Dec 2019 11:43:13 +0530 Message-ID: Subject: Re: [pgAdmin][RM5017] Use cheroot as default production server To: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000b1bd01059aa9654b" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b1bd01059aa9654b Content-Type: text/plain; charset="UTF-8" Hi Hackers, Turned out my pip was of older version. Upgrading pip solved the jaraco.functools problem. pip downloaded the suitable version automatically. Kindly ignore the previous patch. On Tue, Dec 24, 2019 at 12:49 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > One of the dependencies of cheroot - jaraco.functools was released on > 20th Dec (v 3.0.0) which removed the support below Python 3.6. So while > installing cheroot (using pgAdmin wheel) on Python 3.5, it is failing. > cheroot works fine with its previous version of jaraco.functools==2.0.0. > I've raised the issue to cheroot - > https://github.com/cherrypy/cheroot/issues/258. > Please note, installers work fine as they are shipped with Python 3.7 > venv. Ref - > https://www.postgresql.org/ftp/pgadmin/pgadmin4/snapshots/2019-12-24/ > Attached is the patch to pin jaraco.functools to 2.0.0 in requirements so > that it does not fail below Python 3.6. > > On Fri, Dec 20, 2019 at 6:21 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Ashesh, >> >> I had tried with - https://newrelic.com/ API to check Flask app >> performance. To be honest, there was not a great difference in the >> performance. >> Per new relic, cheroot used slightly less CPU, with more RPM and, with >> less response time. >> Anyway, flask is still not recommended and cheroot looks a good option as >> it is pure python and supports almost all OS. >> >> On Fri, Dec 20, 2019 at 1:34 PM Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> Have you seen any improvements in performance? >>> >>> On Tue, 17 Dec 2019, 15:16 Aditya Toshniwal, < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the patch to use https://pypi.org/project/cheroot/ instead >>>> of current flask dev server. cheroot is a stable production ready server. >>>> Plus, flask dev server is not recommended for production. >>>> Code is changed to use cheroot only when DEBUG is False, otherwise you >>>> the default flask server. >>>> >>>> Kindly review. >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Sr. Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --000000000000b1bd01059aa9654b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

Turned out my pip was of older version. Upgrad= ing pip solved the jaraco.functools problem. pip downloaded the suitable ve= rsion automatically. Kindly ignore the previous patch.

On Tue, Dec 24,= 2019 at 12:49 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
=
Hi Hackers,
<= br>
On= e of the dependencies of cheroot -=C2=A0jaraco.functools was released on 20th Dec (v 3.0.0) which=C2=A0removed the= support below Python 3.6. So while installing cheroot (using pgAdmin wheel= ) on Python 3.5, it is failing. cheroot works fine with its previous versio= n of=C2=A0jaraco.functools=3D=3D2.0.0. I've raised the issue to = cheroot -=C2=A0https://github.com/cherrypy/cheroot/issues/258.=
Pleas= e note, installers work fine as they are shipped with Python 3.7 venv. Ref = -=C2=A0https://www.postgresql.org/ftp/pgadm= in/pgadmin4/snapshots/2019-12-24/
Attache= d is the patch to pin=C2=A0jarac= o.functools to 2.0.0 in requirements so that it does not fail below Python = 3.6.

On Fri, Dec 20, 2019 at 6:21 PM Aditya Toshniwal &l= t;ad= itya.toshniwal@enterprisedb.com> wrote:
Hi Ashesh,

I had trie= d with -=C2=A0https://newrelic.com/=C2=A0API = to check Flask app performance. To be=C2=A0honest, there was not a great di= fference in the performance.=C2=A0
Per new relic, cheroot used slightly le= ss CPU, with more RPM and, with less response time.
Anyway, flask is still = not recommended=C2=A0and cheroot looks a good option as it is pure python a= nd supports almost all OS.

On Fri, Dec 20, 2019 at 1:34 PM Ashesh Vash= i <as= hesh.vashi@enterprisedb.com> wrote:
Have you seen any improvements= in performance?=C2=A0

On Tue, 17 Dec 2019, 15:16 Aditya Toshniwal, <aditya.t= oshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch= to use=C2=A0https= ://pypi.org/project/cheroot/=C2=A0instead of current flask dev server. = cheroot is a stable production ready server. Plus, flask dev server is not = recommended for production.
Code is changed to use cheroot only when DEBUG = is False, otherwise=C2=A0you the default flask server.

=
= Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engin= eer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TRE= E"


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks and Regards,Aditya Toshniwal
pgAdmin Hacker | Sr. S= oftware Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat= , Plant a TREE"
=
--000000000000b1bd01059aa9654b--