public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin][RM4242] Server "Statistics" tab, broken sort
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin][RM4242] Server "Statistics" tab, broken sort
@ 2019-10-31 11:27 Aditya Toshniwal <[email protected]>
2019-11-01 12:05 ` Re: [pgAdmin][RM4242] Server "Statistics" tab, broken sort Dave Page <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Toshniwal @ 2019-10-31 11:27 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Attached is the patch to fix sorting in backgrid for columns with null
values.
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachments:
[application/octet-stream] RM4242.patch (506B, 3-RM4242.patch)
download | inline diff:
diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js
index 949c5ee0c..52bcbd9d9 100644
--- a/web/pgadmin/static/js/backgrid.pgadmin.js
+++ b/web/pgadmin/static/js/backgrid.pgadmin.js
@@ -161,6 +161,8 @@ define([
// compare as usual
if (l === r) return 0;
+ else if (l === null && r != null) return -1;
+ else if (l != null && r === null) return 1;
else if (l < r) return -1;
return 1;
}
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin][RM4242] Server "Statistics" tab, broken sort
2019-10-31 11:27 [pgAdmin][RM4242] Server "Statistics" tab, broken sort Aditya Toshniwal <[email protected]>
@ 2019-11-01 12:05 ` Dave Page <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2019-11-01 12:05 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Thu, Oct 31, 2019 at 11:28 AM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is the patch to fix sorting in backgrid for columns with null
> values.
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2019-11-01 12:05 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-10-31 11:27 [pgAdmin][RM4242] Server "Statistics" tab, broken sort Aditya Toshniwal <[email protected]>
2019-11-01 12:05 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox