Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r3eLs-004up7-Td for pgadmin-hackers@arkaria.postgresql.org; Thu, 16 Nov 2023 15:32:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r3eLr-007V9V-JE for pgadmin-hackers@arkaria.postgresql.org; Thu, 16 Nov 2023 15:32:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r3eLr-007V9L-Aw for pgadmin-hackers@lists.postgresql.org; Thu, 16 Nov 2023 15:32:19 +0000 Received: from mail-oo1-xc2a.google.com ([2607:f8b0:4864:20::c2a]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1r3eLo-006kyG-Br for pgadmin-hackers@postgresql.org; Thu, 16 Nov 2023 15:32:18 +0000 Received: by mail-oo1-xc2a.google.com with SMTP id 006d021491bc7-586940ee5a5so451150eaf.0 for ; Thu, 16 Nov 2023 07:32:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1700148734; x=1700753534; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TvwwqgW7bY5Ml06W5KtENz7Tpk9j2HlPzgJxe5YJPiE=; b=dgm4Uq+Dbe8kbjz2B7ajebHD1lpRKUXc1NcnFW0fJN0Ne78M15mhdiB2ntw4TEA51P C+EtLDC1OQLtui5Bmpf/YhN7GhwUwMZF5jonlOh/wK8PP5W/Zw6a8iVF39VmnwtN6wHD W5ThwX2WF3N595KeacoEXC+syChT+YeRklc1o95m/ZOEHB/V9J3PNccVe5KlSjyyKn5h Wdv4gjiNZSjXIeVcQiUfYIg2HA+oJLPVUF6HSPuJepBGofUfPxOniJc1s7CeQU2StF/A 39uQqfIRY9HDF8uZMyEE1ebIqI36gYnMqRDcUWM6q87a3plyvD08QrHbhL0Lz/GTVqmF zHRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700148734; x=1700753534; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TvwwqgW7bY5Ml06W5KtENz7Tpk9j2HlPzgJxe5YJPiE=; b=sQcrH5phO+KORALUXzvQi2wsyULmvwf1MNqcaAY8E4URr+hShXNbg2NQ9M7Q7Xg2uo EEnAtpwCJCUgrqPKJP9/jrVnONfVba+SzFBmA0taFBpHGWQJT17ylVZYUcHVEA/vW7c7 mOBn4GfFFFg/eeH8sdsvlSUNtEFdtFb1RYpjx8AGVhJymY1oStrHbJeCnHRPn3OC/sw9 OCiJFcMrjygm7mBnBcghGzlYhm+hBNbVd6Evn0oBfUn7K3esY0nPd8DcUQCOhbJz5tya KX1yqcW71mq8dFCE2koq0Cylu6FOD0oze3UuaGD7VOudMvplYMV/KGhW8Lyof8x9QE6V 6RyA== X-Gm-Message-State: AOJu0Yx/H+8le+wEUYYlLYxk4boQsRv+3aNdc9bS5rjZWxEsA9AsZk8p xIQS8FexcbQxwF0etB4hgS/qJXHN0B/zk3F/bH2smRiIx0/kdvaOccc= X-Google-Smtp-Source: AGHT+IEry6jo+u7qodd/Xu60HQZeYVe8VuIxnp5zOYldEl3yMk0H5cZ6ftdjpajnA63K3imHAVUJtZg52YeGJPsAFvM= X-Received: by 2002:a4a:6b1e:0:b0:583:fc94:c3f3 with SMTP id g30-20020a4a6b1e000000b00583fc94c3f3mr15208551ooc.9.1700148733994; Thu, 16 Nov 2023 07:32:13 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Thu, 16 Nov 2023 21:01:38 +0530 Message-ID: Subject: Re: Require suggestions on UI changes To: Pravesh Sharma Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="0000000000005b02ce060a46b971" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000005b02ce060a46b971 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Pravesh, I suggest we can move the "Custom return type?" switch above with default as false and change "return type" to dropdown or text based on the switch. No need for a "Custom return type" textbox. On Thu, Nov 16, 2023 at 5:58=E2=80=AFPM Pravesh Sharma < pravesh.sharma@enterprisedb.com> wrote: > Hi Team, > > I have made some UI changes for issue 6854 > . I have added a > switch *Custom return type? *if enabled, an input text box will be > visible in which the user can provide their desired return type, and when > this switch is enabled return type select box will be disabled. This cust= om > return type input and switch will be visible only when creating a new > function. > > Please provide your suggestions and feedback if these changes look okay t= o > you. > > > Regards, > Pravesh > -- > > > > Pravesh Sharma > > Software Engineer > > +91 9406461406 > > www.enterprisedb.com > > Power to Postgres > > > > > > --=20 Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* "Don't Complain about Heat, Plant a TREE" --0000000000005b02ce060a46b971 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Pravesh,

I suggest we can move the "Custom = return type?" switch above with default as false and change "retu= rn type" to dropdown or text based on the switch. No need for a "= Custom return type" textbox.

On Thu, Nov 16, 2023 at 5:58=E2=80= =AFPM Pravesh Sharma <pravesh.sharma@enterprisedb.com> wrote:
Hi Team,
=C2=A0<= /div>
I have made some UI changes for issue 6854. I have add= ed a switch Custom return type? if=C2=A0enabled, an input text box w= ill be visible=C2=A0in which the user can provide their desired return type= , and when this switch is enabled return type select box will be disabled. = This custom return type input and switch will be visible only when creating= a new function.

Please provide your suggestions a= nd feedback if these changes look okay to you.

Regards,
Pravesh
--

Pravesh Sharm= a

Software Engineer

=

<= font color=3D"#000000" face=3D"Arial">+91 9406461406

www.enterprisedb.com<= /p>

Power = to Postgres

=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0



--
Thanks,
Aditya Toshniwal
pgAdmin Hacker=C2=A0| Sr. Software Architect=C2=A0| enterprisedb.com