MIME-Version: 1.0
References: 
 <CAA3zdZo1V2-wNwQ6ghOmKrVT_sV-=hiiKiKFAnMMhuxnp3SXkg@mail.gmail.com>
In-Reply-To: 
 <CAA3zdZo1V2-wNwQ6ghOmKrVT_sV-=hiiKiKFAnMMhuxnp3SXkg@mail.gmail.com>
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Thu, 26 Mar 2020 10:23:23 +0530
Message-ID: 
 <CAM9w-_k2LJh7Cf2ycX+mOdn0kutea0Yy8EBLryza7HyepXkiZA@mail.gmail.com>
Subject: Re: [pgAdmin][RM5292] Alertify header buttons focus color issue
To: Nagesh Dhope <nagesh.dhope@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000e2025505a1bac5cb"
Precedence: bulk

--000000000000e2025505a1bac5cb
Content-Type: text/plain; charset="UTF-8"

Hi Nagesh,

I cannot see any change related to $active-border variable apart from
!default. Plus, $active-border should not be allowed to edit. It is a
structural variable and not a variable which affects theme change.
Please revert the $active-border change and send the patch.

On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope <nagesh.dhope@enterprisedb.com>
wrote:

> Hi Hackers,
>
> Please find a patch which includes
>
>    1. Use *btn-secondary* styles for all buttons in alertify dialog
>    header.
>    2. Added *!default *for $active-border variable, so that it can be
>    overridden if required.
>    3. Added entry for *.scss *in .editorconfig
>
> --
> Thanks,
> Nagesh
>


-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

--000000000000e2025505a1bac5cb
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif">Hi=C2=A0Nagesh,</div><div class=3D"gmail_default" style=3D"font=
-family:verdana,sans-serif"><br></div><div class=3D"gmail_default" style=3D=
"font-family:verdana,sans-serif">I cannot see any change related to $active=
-border variable apart from !default. Plus, $active-border=C2=A0should not =
be allowed to edit. It is a structural=C2=A0variable and not a variable whi=
ch affects theme change.<br></div><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif">Please revert the=C2=A0$active-border change a=
nd send the patch.</div></div><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope &lt;<=
a href=3D"mailto:nagesh.dhope@enterprisedb.com">nagesh.dhope@enterprisedb.c=
om</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margi=
n:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex=
"><div dir=3D"ltr">Hi Hackers,<div><br></div><div>Please find a patch which=
 includes</div><div><ol><li>Use <i>btn-secondary</i> styles for all buttons=
 in alertify dialog header.</li><li>Added <i>!default </i>for<i>=C2=A0</i>$=
active-border variable, so that it can be overridden if required.=C2=A0</li=
><li>Added entry for <i>.scss </i>in<i> </i>.editorconfig</li></ol>-- <br><=
div dir=3D"ltr"><div dir=3D"ltr">Thanks,<div>Nagesh</div></div></div></div>=
</div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div=
 dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><font size=3D"2" c=
olor=3D"#000000" face=3D"verdana, sans-serif">Thanks and Regards,</font><di=
v><span style=3D"background-color:rgb(255,255,255)"><font size=3D"2" color=
=3D"#000000" face=3D"verdana, sans-serif">Aditya Toshniwal</font></span></d=
iv><div><font face=3D"verdana, sans-serif"><span style=3D"background-color:=
rgb(255,255,255)"><font size=3D"2" color=3D"#000000">pgAdmin Hacker | Sr. S=
oftware Engineer |=C2=A0EnterpriseDB India |=C2=A0</font></span><span style=
=3D"color:rgb(0,0,0)">Pune</span></font></div><div><font color=3D"#38761d" =
face=3D"verdana, sans-serif" size=3D"1">&quot;Don&#39;t Complain about Heat=
, Plant a TREE&quot;</font></div></div></div></div></div></div></div></div>=
</div></div></div>

--000000000000e2025505a1bac5cb--