public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][RM3453] Incomplete SQL for Foreign tables in SQL tab
Date: Mon, 14 Jan 2019 14:27:50 +0530
Message-ID: <CAM9w-_k9KoZie=9by8oGTnBnqpZkRtJawvzYZET4UvS5DBV0nw@mail.gmail.com> (raw)
Hi Hackers,
Attached is the patch to fix incomplete SQL for Foreign tables in SQL tab.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Attachments:
[application/octet-stream] RM3453.patch (894B, 3-RM3453.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py
index ddb31e79..2d206bff 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py
@@ -1209,10 +1209,6 @@ class ForeignTableView(PGChildNodeView, DataTypeReader):
if db_variables is not None:
for row in db_variables:
var_name, var_value = row.split("=")
- # Because we save as boolean string in db so it needs
- # conversion
- if var_value == 'false' or var_value == 'off':
- var_value = False
var_dict = {'option': var_name, 'value': var_value}
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [pgAdmin4][RM3453] Incomplete SQL for Foreign tables in SQL tab
In-Reply-To: <CAM9w-_k9KoZie=9by8oGTnBnqpZkRtJawvzYZET4UvS5DBV0nw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox