Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maAvl-00073C-AU for pgadmin-hackers@arkaria.postgresql.org; Tue, 12 Oct 2021 06:06:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1maAvk-00010T-8r for pgadmin-hackers@arkaria.postgresql.org; Tue, 12 Oct 2021 06:06:28 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maAvj-0000wW-I9 for pgadmin-hackers@lists.postgresql.org; Tue, 12 Oct 2021 06:06:28 +0000 Received: from mail-ua1-x932.google.com ([2607:f8b0:4864:20::932]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1maAvc-0001wU-QR for pgadmin-hackers@postgresql.org; Tue, 12 Oct 2021 06:06:26 +0000 Received: by mail-ua1-x932.google.com with SMTP id f4so10836888uad.4 for ; Mon, 11 Oct 2021 23:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SFSpCtCQtJDcXrRSM/RUqWkQO/2CxMixATmDIzXXAXQ=; b=L3h9w79lby4IMGxFIFdyhHLF8TR8ElfFZFKs9nnZlVy+VH5W7YoHXteCeyLcRFwmVD 6xEBj8qbKKhpBw0LPxpGcHojejcYJ5gz+hKSG6OSbF8JHp33cnBluKDFqyJGitd46SfU Oe+a9B4w/9gVU/9kVG42tNOKMORE60VsRaAO/HH+w4vN2syT0McJH73bZ4KtiXwMtTTp HwXPxxEU1Fs3pwL4zT8ldEJPlamEtyoVzpvfoKgefY/aBIY8xRIqFGvkAcbM8MvLI23B RLVyZNTGDxvIDtTpoGX3bDuZB7cXXKsfDd5QKWUqRkZBWWiLhg5hfunonHII50wbtIYQ IRAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SFSpCtCQtJDcXrRSM/RUqWkQO/2CxMixATmDIzXXAXQ=; b=I5NWPJVxE5FpWqEvZZYQNhuzqpiNLPmH13hCqu4cqw7Y2d82gef4/B/f8HXF5boYP+ 397kFUQI4wUHDf7C1+jRzttbZsK29p6dSpx7V/X1yg1sajP9rRCeoskMUUCkpJXP7VA5 P3MCEdAXbRylI4nTE5Hu6ptxmYIFVX2mQ3fHqe1QJwSY7Egmv8cNKs/ygCCjboSUidra BWDOLdQWIixjI1CyJlwuxotWXbfoJBbOigq29ijxlnuFGwFzQl1G8dmDrLPuK0pjdoh1 Sp3cT8Y33/hcBklAa9h6h16Bl2iVKOjbgfp/SmxzrrjfvSPLbGc76KDelHKX8rGdIzdV QZqg== X-Gm-Message-State: AOAM531FaGZs133An+vW6WlDw9qRNMrX4t8BVZ014MF2xuHgfhSkmrtZ M5DLa7elbeSpM9Ym+mi6TPDsMDao36NESdh1L9W2A6Jmybz+/CemQ7pFkbag9wyAwtLjnPw3IEl 6/wbhvyhxaqe0l1AFFTRHPAZGiuG2EzpxplfRS6DB7AZaH3Tni/lHR80u3cmCU0DVHTf8bEAMge MC1NQ2b7be3AbCM5YIyhPf7fmki6ezlMxaWZL5ZHVbi1NO2isPvpk3utNjEQ== X-Google-Smtp-Source: ABdhPJxoD+O7YHCRCxh1pnzFPF6iOVhN37wgA8JCzNs1H5G9btxCJaRf4DCR9qNyahmXOQwYxp0Q9qkn0np/6nNG528= X-Received: by 2002:ab0:30ce:: with SMTP id c14mr20107505uam.46.1634018779502; Mon, 11 Oct 2021 23:06:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Tue, 12 Oct 2021 11:35:43 +0530 Message-ID: Subject: Re: [pgAdmin][RM6081] Advanced table fields in ERD To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000e8b92405ce21a4d6" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000e8b92405ce21a4d6 Content-Type: multipart/alternative; boundary="000000000000e8b92205ce21a4d4" --000000000000e8b92205ce21a4d4 Content-Type: text/plain; charset="UTF-8" Hi, Please review the attached patch to fix failing API test case. On Mon, Oct 11, 2021 at 5:44 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Mon, Oct 11, 2021 at 5:14 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached patch will port Backbone based dialogs in ERD to React based >> using the schema view UI framework. This allows us to use the existing >> table UI, remove repeated code and enable advanced fields. I have hidden >> fields from the existing table UI for ERD. >> Please note, this also fixes #6529. >> >> Please review. >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin Hacker | Software Architect | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --000000000000e8b92205ce21a4d4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Please review the attached patch to fix=C2=A0failing A= PI test case.

On Mon, Oct 11, 2021 at 5:44 PM Akshay Joshi <akshay.joshi@enterprisedb.com= > wrote:
Thanks, the patch applied.

On Mon, Oct 11, 2021 at 5:14 PM Adit= ya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,
Attached=C2=A0patch will port Backbone based dialogs in ERD to React base= d using the schema view UI framework. This allows us to use the existing ta= ble UI, remove repeated code and enable advanced fields. I have hidden fiel= ds from the existing table UI for ERD.
Please=C2=A0note, this also fixes #6= 529.

Please review.

--
Than= ks,
Aditya Toshniwal=
=
pgAdmin Hacker=C2=A0| Software Architect=C2=A0| edbpostgres.com
"Don= 't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin Hacker=C2=A0| Software A= rchitect=C2=A0| edbpostgres.com
"Don't Complain about Heat, Plant a TREE&qu= ot;
--000000000000e8b92205ce21a4d4-- --000000000000e8b92405ce21a4d6 Content-Type: application/octet-stream; name="RM6081.api.patch" Content-Disposition: attachment; filename="RM6081.api.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kunokh2n0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2VyZC9zdGF0aWMvanMvZXJkX3Rvb2wvRVJE Q29yZS5qcyBiL3dlYi9wZ2FkbWluL3Rvb2xzL2VyZC9zdGF0aWMvanMvZXJkX3Rvb2wvRVJEQ29y ZS5qcwppbmRleCBiNjNiMTc4NmEuLjYwZGJmNGUzNCAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4v dG9vbHMvZXJkL3N0YXRpYy9qcy9lcmRfdG9vbC9FUkRDb3JlLmpzCisrKyBiL3dlYi9wZ2FkbWlu L3Rvb2xzL2VyZC9zdGF0aWMvanMvZXJkX3Rvb2wvRVJEQ29yZS5qcwpAQCAtMzgxLDIxICszODEs NiBAQCBleHBvcnQgZGVmYXVsdCBjbGFzcyBFUkRDb3JlIHsKICAgICAgIH0pXSwKICAgICB9KTsK IAotICAgIC8vIGxldCB0YWJsZURhdGEgPSB7Ci0gICAgLy8gICBuYW1lOiBgJHtsZWZ0Tm9kZS5n ZXREYXRhKCkubmFtZX1fJHtyaWdodE5vZGUuZ2V0RGF0YSgpLm5hbWV9YCwKLSAgICAvLyAgIHNj aGVtYTogbGVmdE5vZGUuZ2V0RGF0YSgpLnNjaGVtYSwKLSAgICAvLyAgIGNvbHVtbnM6IFt7Ci0g ICAgLy8gICAgIC4uLmxlZnROb2RlLmdldENvbHVtbkF0KG1hbnl0b21hbnlEYXRhLmxlZnRfdGFi bGVfY29sdW1uX2F0dG51bSksCi0gICAgLy8gICAgICduYW1lJzogYCR7bGVmdE5vZGUuZ2V0RGF0 YSgpLm5hbWV9XyR7bGVmdE5vZGUuZ2V0Q29sdW1uQXQobWFueXRvbWFueURhdGEubGVmdF90YWJs ZV9jb2x1bW5fYXR0bnVtKS5uYW1lfWAsCi0gICAgLy8gICAgICdpc19wcmltYXJ5X2tleSc6IGZh bHNlLAotICAgIC8vICAgICAnYXR0bnVtJzogMCwKLSAgICAvLyAgIH0sewotICAgIC8vICAgICAu Li5yaWdodE5vZGUuZ2V0Q29sdW1uQXQobWFueXRvbWFueURhdGEucmlnaHRfdGFibGVfY29sdW1u X2F0dG51bSksCi0gICAgLy8gICAgICduYW1lJzogYCR7cmlnaHROb2RlLmdldERhdGEoKS5uYW1l fV8ke3JpZ2h0Tm9kZS5nZXRDb2x1bW5BdChtYW55dG9tYW55RGF0YS5yaWdodF90YWJsZV9jb2x1 bW5fYXR0bnVtKS5uYW1lfWAsCi0gICAgLy8gICAgICdpc19wcmltYXJ5X2tleSc6IGZhbHNlLAot ICAgIC8vICAgICAnYXR0bnVtJzogMSwKLSAgICAvLyAgIH1dLAotICAgIC8vIH07CiAgICAgbGV0 IG5ld05vZGUgPSB0aGlzLmFkZE5vZGUodGFibGVEYXRhKTsKICAgICB0aGlzLmNsZWFyU2VsZWN0 aW9uKCk7CiAgICAgbmV3Tm9kZS5zZXRTZWxlY3RlZCh0cnVlKTsKZGlmZiAtLWdpdCBhL3dlYi9w Z2FkbWluL3Rvb2xzL2VyZC90ZXN0cy90ZXN0X3NxbF9pbnB1dF9kYXRhLmpzb24gYi93ZWIvcGdh ZG1pbi90b29scy9lcmQvdGVzdHMvdGVzdF9zcWxfaW5wdXRfZGF0YS5qc29uCmluZGV4IDNjODE4 MmU2OC4uYmQxNDlhMjM3IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi90b29scy9lcmQvdGVzdHMv dGVzdF9zcWxfaW5wdXRfZGF0YS5qc29uCisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL2VyZC90ZXN0 cy90ZXN0X3NxbF9pbnB1dF9kYXRhLmpzb24KQEAgLTgwLDYgKzgwLDIxIEBACiAgICAgICAgICAg XSwKICAgICAgICAgICAiaW5jbHVkZSI6IFtdCiAgICAgICAgIH0KKyAgICAgIF0sCisgICAgICAi Zm9yZWlnbl9rZXkiOiBbCisgICAgICAgIHsKKyAgICAgICAgICAic2NoZW1hIjogInB1YmxpYyIs CisgICAgICAgICAgInRhYmxlIjogIm5ld3RhYmxlMiIsCisgICAgICAgICAgInJlbW90ZV9zY2hl bWEiOiAicHVibGljIiwKKyAgICAgICAgICAicmVtb3RlX3RhYmxlIjogIm5ld3RhYmxlMSIsCisg ICAgICAgICAgImNvbHVtbnMiOiBbCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICJsb2Nh bF9jb2x1bW4iOiAidGFibGUxX2lkIiwKKyAgICAgICAgICAgICAgInJlZmVyZW5jZWQiOiAiaWQi LAorICAgICAgICAgICAgICAicmVmZXJlbmNlcyI6ICIxZDlkYzU2ZS1lNGY5LTQ4YjktODg5Yi02 MDg0ZWM2NDQ2YmYiCisgICAgICAgICAgICB9CisgICAgICAgICAgXQorICAgICAgICB9CiAgICAg ICBdCiAgICAgfSwKICAgICAiZjAwMWE3NzAtZDZmYS00NTcyLWI4OGItMTFkZDVlMzhkMzBjIjog ewpAQCAtODgsMTkgKzEwMyw1IEBACiAgICAgICAic2NoZW1hIjogInB1YmxpYyIsCiAgICAgICAi cHJpbWFyeV9rZXkiOiBbXQogICAgIH0KLSAgfSwKLSAgImxpbmtzIjogewotICAgICI5OThkZTE5 YS1jYWEwLTQzMWUtOWNmNy05NzgyN2YwMTAyMmIiOiB7Ci0gICAgICAic2NoZW1hIjogInB1Ymxp YyIsCi0gICAgICAidGFibGUiOiAibmV3dGFibGUyIiwKLSAgICAgICJyZW1vdGVfc2NoZW1hIjog InB1YmxpYyIsCi0gICAgICAicmVtb3RlX3RhYmxlIjogIm5ld3RhYmxlMSIsCi0gICAgICAiY29s dW1ucyI6IFsKLSAgICAgICAgewotICAgICAgICAgICJsb2NhbF9jb2x1bW4iOiAidGFibGUxX2lk IiwKLSAgICAgICAgICAicmVmZXJlbmNlZCI6ICJpZCIKLSAgICAgICAgfQotICAgICAgXQotICAg IH0KICAgfQogfQo= --000000000000e8b92405ce21a4d6--