Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qZQH7-005FKm-7r for pgadmin-hackers@arkaria.postgresql.org; Fri, 25 Aug 2023 06:26:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qZQH6-0008AP-3p for pgadmin-hackers@arkaria.postgresql.org; Fri, 25 Aug 2023 06:26:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qZQH5-00089x-N1 for pgadmin-hackers@lists.postgresql.org; Fri, 25 Aug 2023 06:26:27 +0000 Received: from mail-oo1-xc30.google.com ([2607:f8b0:4864:20::c30]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qZQGx-000qIQ-7P for pgadmin-hackers@postgresql.org; Fri, 25 Aug 2023 06:26:25 +0000 Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-57325fcd970so411628eaf.1 for ; Thu, 24 Aug 2023 23:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1692944778; x=1693549578; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KeEGOTVFHNQ2+r0NcBRiifGvPGq9Ny2Uet2CxrOqCPc=; b=kwjoH+Qv2EmwlYINjU/baIYx4I8af5mWe2DA+58/MXCGGRNXZwCPVpBeI437M8Xgy9 SiTP8JtCMdgL1+zsZuL3rlaxnAQmngthRK6EdBEbvrjV97E0Cg5kb1j6fqrsQfIA8pFV QiEHzkicIWx8O9raW10wPQMCMaAWANHHRNylaDVfQ/7BJeBidPgpSuXD+E3oLROalEMo WZPR/RDKIl94yneModSchwcuZZpDpa0Wks2zlJsH/N0Lpv+8nbSpSynThJeGBW46Gr7w lGrlseY24kfP3QeACpOOexG+SDSnS0QGJkCG1gyf+3vgSlyEGLhpC4045nM07InJC9BZ ywtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692944778; x=1693549578; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KeEGOTVFHNQ2+r0NcBRiifGvPGq9Ny2Uet2CxrOqCPc=; b=BzYv8xS/rEX8ZfF1Bn/B11+GzT5tslL9ECqwi6rB2Otu6paWqYsBw46RiQLt+FDC0l ruxzIrucSk1blGJ/DXyGeK4gSgX+lYJy8WuGt3ueZcnq4Fxl9BNNax7XQ70EmLyDYonN dzwk9n9x832Zr5YnQKUZ44eFVmhLPw2QBckxQZXvIq7lbSe81E2UQE7W85ZGJczPtVbW rFW6+VqFz7JhxS8SaMBjocDhnlaxpOamVX4BqWefK/hiIB8S49J5N54x3KJa1bT8UhkU YahJALSes5AO8364nsFLGSD/UQKi7rG7xtlmQ8JHLqi7bJYaJG0P5srOTfwKx94MSFXI zu3g== X-Gm-Message-State: AOJu0YxlOLFu+t4RXusR7Q4+4xW+yOOhgXv7E+EvlZ51w0COf+4Q6cy/ 1/ZFAPbJ+0uuMk/3gujFBiuOnE328tWN1GXpMKvyzw== X-Google-Smtp-Source: AGHT+IHCv6UYL3QZ6sJLvEU1mKnRoPNfX4aSlyV0bte0OscznC2Nk5NSZ0R/4D7FRK1XWxRBTakHSbh4dFThYoEu6as= X-Received: by 2002:a4a:920d:0:b0:571:28d5:2c77 with SMTP id f13-20020a4a920d000000b0057128d52c77mr4085689ooh.5.1692944778445; Thu, 24 Aug 2023 23:26:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Fri, 25 Aug 2023 11:55:41 +0530 Message-ID: Subject: Re: Pgadmin4 System Stats Extension Design To: Sahil Harpal Cc: Khushboo Vashi , pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="00000000000024dd5e0603b96cfd" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000024dd5e0603b96cfd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Sahil, On Fri, Aug 25, 2023 at 11:30=E2=80=AFAM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Sahil, > > On Thu, Aug 24, 2023 at 8:28=E2=80=AFPM Sahil Harpal > wrote: > >> On Sat, 19 Aug 2023 at 16:20, Sahil Harpal >> wrote: >> >>> On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> >>>> - Sometimes graphs start from left and then shift to right. This >>>> issue I have reported in my initial review too. >>>> >>>> For StreamingChart should I ignore it for now? >>> On Mon, 7 Aug 2023 at 17:12, Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> OK I thought you wanted the graph to go from left to right. Yeah, I >>>> have seen that glitch a few times (but rare). I think you can ignore i= t for >>>> now, we can look into it once we get time. It is not a priority. >>>> >>> >>> Or try the solution below? >>> On Sun, 6 Aug 2023 at 13:21, Sahil Harpal >>> wrote: >>> >>>> I've tried one more approach here. If our data array is full, this >>>> graph shifting won't happen. So, if we initialize our data list with n= ull >>>> values, there won't be any visible shift. What do you think about this >>>> solution? >>>> >>> Can you please help me with this? >> > Let me apply your patch and try once. > Can you please share the rebased patch? > > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* > > "Don't Complain about Heat, Plant a TREE" > --=20 Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* "Don't Complain about Heat, Plant a TREE" --00000000000024dd5e0603b96cfd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Sahil,

On Fri, Aug 25, 2023 at 11= :30=E2=80=AFAM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> w= rote:
Hi= =C2=A0Sahil,

On Thu, Aug 24, 2023 at 8:28=E2=80=AFPM Sahil Harpal <= sahilharpal1= 234@gmail.com> wrote:
On Sat, 19 Aug 2023 at 16:20= , Sahil Harpal <sahilharpal1234@gmail.com> wrote:
3D""
On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi <= ;khush= boo.vashi@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
    =
  • Sometimes graphs start from left and then shift to right. This issue I = have reported in my initial review too.
For StreamingChart should I i= gnore it for now?=C2=A0
On Mon, 7 Aug 2023 at 17:12, Aditya Toshniwal <aditya.toshniwal@enter= prisedb.com> wrote:
OK I thought you wanted= the graph to go from left to right.=C2=A0=C2=A0Yeah, I have seen that g= litch a few times (but rare). I think you can ignore it for now, we can loo= k into it once we get time. It is not a priority.
<= /blockquote>

Or try the solution below?=C2=A0
<= /div>
On Sun, 6 Aug 2023 at 13:21, Sahil Harpal <sahilharpal1234@gmail.com&= gt; wrote:
I've tried one more approach h= ere. If our data array is full, this graph shifting won't happen. So, i= f we initialize our data list with null values, there won't be any visi= ble shift. What do you think about this solution?
Can you please help me with = this?
Let me apply your patch and try on= ce.=C2=A0
Can you please share the re= based patch?=C2=A0


--
Thanks,
Aditya Toshniwal
pgAdmin Hacker=C2=A0| Sr. Software Architect=C2=A0| enterprisedb.com

--
Thanks,
Aditya Toshniwal
pgAdmin Hacker=C2=A0| Sr. Software Architect=C2=A0| enterprisedb.com