Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYrOM-0001an-PU for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Jun 2018 11:16:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fYrOK-0003uI-Aq for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Jun 2018 11:16:40 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYrOJ-0003u1-LI for pgadmin-hackers@lists.postgresql.org; Fri, 29 Jun 2018 11:16:40 +0000 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fYrOF-0001CV-Vg for pgadmin-hackers@postgresql.org; Fri, 29 Jun 2018 11:16:37 +0000 Received: by mail-lj1-x232.google.com with SMTP id t21-v6so7019820lji.0 for ; Fri, 29 Jun 2018 04:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TddRCtyFcn5l1g9Pk6ERiBwSoHf2iI1USU5s+B9IFiI=; b=DQUPqRSthYoQSybz/CrWwYGIwqs0qv7pUh/u1te1GxAQpFRj723jyVaOUI8kbKmhjD iKeI/8tRMbLbKlUEDJ7Wr2vpwDluUc5wLelnaUZRe6Jj0Gl3SY8KLaksUAMVYh2Buirl L4ZOVHLeXjAj2a9Hih+jqQJCOZvot15s+8y/fSkOTe54YWPhluMWOhBgRy8np7sFeuYf gWzv4TCATGtTIcdea4av8KD7M+MbNQYnWKiTRSoE09VYRCqsY4kUYFu9e4wFrG5mitpz 57aPWCM2cMBha68LUY7I7dGDN248zUoI8MYgps/ndhvDryE+5lcehS04YtxPYaRkqOor Bd2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TddRCtyFcn5l1g9Pk6ERiBwSoHf2iI1USU5s+B9IFiI=; b=VqYFy1aI7uD8nmIrpVwt2kpn/wxzpX+TZoRqK+XUEQJFFEXmduYp5c6gmCMsT6Pv/w qB/2wdutKDE/2kkIdjG6pjRFU44j83hj8kenwewj0eTh1qaJywlouO1cn6xyMxmiOvLj edahQ6zfayAW1u6EJi5qp2QReAx36diTi2PURVqDOCIWeTfyYvoxtXrvHf53S2HZlSs3 hr2vvHzD9tFp++/8gTdbsNbjx7bu+MM71cXQAWzOu/d6tQy7ntFlyW58hKstGlTAeqJ0 AauRAbH0wsF2tPs4KKVIiEEcCL+4RhhWc+OYyZQs3RGduUhJftd2kC1g9qeMjRsP9h5W c6lA== X-Gm-Message-State: APt69E0RbqQBy1+TdOzsM4T+MZd9B1A98gjUyustc/v8MkrnylXXjgdy ZmqU+CXLeM9KvqVVlWdMAi1ye8ErjRuDR0ujUaRkUA== X-Google-Smtp-Source: AAOMgpeEmqg1Blt7qlB7s0RpCEZLwYaDkLMPsL6ltC2dZxcN4ZsovqdLEbl3iuFvh33AmT2Ffj+42X1wPHbX8g5lw3I= X-Received: by 2002:a2e:4811:: with SMTP id v17-v6mr9528705lja.39.1530270994179; Fri, 29 Jun 2018 04:16:34 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:850b:0:0:0:0:0 with HTTP; Fri, 29 Jun 2018 04:16:33 -0700 (PDT) In-Reply-To: References: From: Aditya Toshniwal Date: Fri, 29 Jun 2018 16:46:33 +0530 Message-ID: Subject: Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000004c0c0056fc5fb5b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000004c0c0056fc5fb5b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Akshay, On Fri, Jun 29, 2018 at 3:42 PM, Akshay Joshi wrote: > Hi Aditya > > I have applied your patch and run pgAdmin4. I have found following two > issue in the browser: > > - Found error while open Preferences dialog. Refer > Open_Preferences_Dialog.png > > =E2=80=8BThis error occurs even with the latest pull without changes.=E2= =80=8B > > - Set the preferences setting "Open in new browser tab" to True and > open the query tool. Refer "Open_In_New_Broswer.png". > > =E2=80=8BWill look into this.=E2=80=8B > I haven't review the code. > > On Thu, Jun 28, 2018 at 8:04 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for making preferences realtime and applying >> without reseting the layout. Please note, the patch is only for one modu= le >> - SQL Editor and is the first part for the RM. There are lot of changes = to >> be done to cover all and hence sending in parts. This will not affect/br= eak >> existing code. Further patches will cover other modules. >> >> Highlights of this patch include: >> - Changes will affect SQL Editors in Create dialog boxes, SQL tab of the >> main screen, Query tool, History entries in the query tool, Query tool >> opened in New Tab/Window >> - All the components of SQL editor will refer to single source of >> preferences which is cached in the Browser object. All other redundant a= jax >> get preference calls are removed. >> - SQL editor will not refer template JS variables anymore, once all the >> references are removed the template variables will also be removed. >> - Code refactoring wherever possible. >> - Covered JS test cases wherever possible. >> >> Request you to kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > --=20 Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" --00000000000004c0c0056fc5fb5b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,

On Fri, Jun 29, 2018 at 3:42 PM, Akshay Joshi = <aksh= ay.joshi@enterprisedb.com> wrote:
Hi Aditya=C2=A0

I have applied y= our patch and run pgAdmin4. I have found following two issue in the browser= :
  • Found error while open Preferences dialog. Refer Open_P= references_Dialog.png
=E2= =80=8BThis error occurs even with the latest pull without changes.=E2=80=8B=
=C2=A0
    =
  • Set the preferences setting "Open in new browser tab" to True= and open the query tool. Refer "Open_In_New_Broswer.png".
=E2=80=8BWill look into this.=E2= =80=8B
=C2=A0
I haven't review the code.

On Thu, Jun 28, 2018 at 8= :04 PM, Aditya Toshniwal <aditya.toshniwal@enterprise= db.com> wrote:
Hi Hackers,

Attached is the patch for making preferences realtime a= nd applying without reseting the layout. Please note, the patch is only for= one module - SQL Editor and is the first part for the RM. There are lot of= changes to be done to cover all and hence sending in parts. This will not = affect/break existing code. Further patches will cover other modules.
=

Highlights of this patch include:
- Changes will affect SQL Editors in C= reate dialog boxes, SQL tab of the main screen, Query tool, History entries= in the query tool, Query tool opened in New Tab/Window
- All the components of SQL editor will ref= er to single source of preferences which is cached in the Browser object. A= ll other redundant ajax get preference calls are removed.
-=C2=A0SQL editor will not refer temp= late JS variables anymore, once all the references are removed the template= variables will also be removed.
- Code refactoring wherever possible.
- Covered JS test cases wherever possible.

Request you to kindly review.

--=
Thanks an= d Regards,
Aditya Toshniw= al
S= oftware Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
=
"Don't Complain about Heat, Plant a tree"



--
Akshay Joshi
= Sr. Software Architect

<= img src=3D"http://www.enterprisedb.com/sites/default/files/EDB-logo-4c.png"= width=3D"96" height=3D"54">

Phone: +91 20-3058-9517
= Mobile: +91 976-788-8246



--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Sol= utions |=C2=A0Pune
"Don't Complain about Heat, Plant a tr= ee"
--00000000000004c0c0056fc5fb5b--