Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPnVA-0008EP-GH for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Oct 2019 12:55:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iPnV8-0002zG-BR for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Oct 2019 12:55:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPnV7-0002yw-O4 for pgadmin-hackers@lists.postgresql.org; Wed, 30 Oct 2019 12:55:02 +0000 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iPnV2-0000DJ-9h for pgadmin-hackers@postgresql.org; Wed, 30 Oct 2019 12:55:00 +0000 Received: by mail-ot1-x341.google.com with SMTP id b19so1962398otq.10 for ; Wed, 30 Oct 2019 05:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fyJ3ClR/cSIUUnJ9Wn80Daw6ULTFDkqjgp0NJCC2B0M=; b=vDpRl6MIKQYiR173tEDccGSbvOK7jCfPe4g5Za32+0NpvXVhHtF0+VD1qtriRf4R9S Kal04DXbHU5QFY9bW4YDhbLh2kn9NKF1qoJBoNT9bqJWbKe0KRukAWs/dH+f+iiHMrX+ 6rgGtm7/roSRq7V/Q5hkgpu1oj3MMdpfORTkiFph03JSIpmTsRysRmFbNtBGNmuUauoU h2nYMZh93opxeJp8dHCMQXuExMTXc7hqKCDs/ewNcubTm+VGQy4Z65UEkgJIjAf50UuX o+yDemIazmJa4kUE9TX3ls9MNdJt/aXT9QlGzOBzly/ouQeAvH9JWlcsL3ilrU/I0dnH IOMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fyJ3ClR/cSIUUnJ9Wn80Daw6ULTFDkqjgp0NJCC2B0M=; b=YiPjnOVYJW7IiO+SGwQvVlBzWCCLV6Fu9O/6wGtPu0HATu3kaYv41LSVg71K49QY/Q 6tXa8xJrL9J75dQKrayz33nby+M45UxadLWeqSJoEo27UPSz5pXDmKOuDcqHsviHwwLq ZMREkQv4DVZ1mHayPG2gdjuvAuAVzoO+1LUjE9v3+ywA5AkuilPHxcj6pOgrRkFPVHGt N8sZQ3ALGWtZ4ToLknlYtGGdOEwQGeERzwYvV2jlRIOk7p9W3KuG89rEPSrA6MMMLv2U CQYco94I3QKEe3o2AGmEl9ceIHmGsGFrKB/w3GMo5IV8jbgmsTonUAG/nJXeBvJjX8We fo8g== X-Gm-Message-State: APjAAAXmiqq28SinnRpEAfg59VpgfFdE9PtqDRygoCvPvtJM0josBiv6 iODvIMWlUjRx+ngEIfrok7C1/DZJ9DT0PWzjKQSfgR6T2T0Ij7DxYGFpwiYev2mlYWyHTpe0gZa UkscDnxfsSGdm1ZFOokHDHcKSVry6V27opufTFRY+e7t6kG9ktVLNvTSiFiDvom64+korNvfHLs Qzqbs+4I4z5169ebedUmKt4fGpioaCaPynpajrjUSgagegzxPJmZTx6dr+ X-Google-Smtp-Source: APXvYqyWDyJr2N+BkXipsdXNdlASFyGO2j8V5P1sTrAC0NxLU2q8ow8n0lOAgOswze2zqdj52O3NSEZ6I6MY2RE6tJg= X-Received: by 2002:a9d:7413:: with SMTP id n19mr9803212otk.236.1572440094861; Wed, 30 Oct 2019 05:54:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Wed, 30 Oct 2019 18:24:18 +0530 Message-ID: Subject: Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000004901e00596203dec" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000004901e00596203dec Content-Type: text/plain; charset="UTF-8" On Wed, Oct 30, 2019 at 3:44 PM Dave Page wrote: > Hi > > On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi, >> >> On Tue, Oct 29, 2019 at 9:01 PM Dave Page wrote: >> >>> Hi >>> >>> I just found an, umm, embarrassing issue with this. It asks for the >>> cancel confirmation even when pressing the OK button :-o >>> >> Tested all but missed the obvious. Bad miss :/ >> Attached is the patch to fix the issue. >> > > Thanks - applied. Should we also warn on Reset? That seems logical to me. > Can be added. Preference option should be common for both Cancel and Reset. Will send an add-on patch for this. > > >> >>> Can you fix that ASAP please? >>> >>> On Tue, Oct 29, 2019 at 2:35 PM Dave Page wrote: >>> >>>> Thanks, applied. >>>> >>>> On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch to warn the user before closing an unsaved >>>>> properties dialog. >>>>> Additionally, I have added a preference option in Browser->Display >>>>> where the user can disable this. Default is enabled. >>>>> Docs updated. >>>>> >>>>> Kindly review. >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Sr. Software Engineer | EnterpriseDB India | Pune >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --0000000000004901e00596203dec Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Oct 30, 2019 at 3:44 PM Dave= Page <dpage@pgadmin.org> wr= ote:
Hi

On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
Hi,

On Tue, Oct 29, 2019 at 9:01 PM Dave Page <dpage@pgadmin.org> wrote:
=
Hi

I just found an, umm, embarrassi= ng issue with this. It asks for the cancel confirmation even when pressing = the OK button :-o
Tested all but missed the obviou= s. Bad miss :/
Attached is the patch to fix the issue.= =C2=A0

Thanks - applied. = Should we also warn on Reset? That seems logical to me.
Can be added. Preference option should be common for both Cance= l and Reset. Will send an add-on patch for this.=C2=A0
=C2=A0

Can you fix that= ASAP please?

On Tue, Oct 29, 2019 at 2:35 PM Dave Page <dpage@pgadmin.org> wrote= :
Thanks, applied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <aditya.= toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the p= atch to warn the user before closing an unsaved properties dialog.
Additionally, I have added a pre= ference option in Browser->Display where the=C2=A0user can disable this.= Default is enabled.
Doc= s updated.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB In= dia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"
=


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB In= dia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"
=
--0000000000004901e00596203dec--