Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRwtb-0003Ss-Cz for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Oct 2020 12:25:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kRwtZ-0000cw-1L for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Oct 2020 12:25:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRwtY-0000ce-Qg for pgadmin-hackers@lists.postgresql.org; Mon, 12 Oct 2020 12:25:40 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kRwtQ-0001j3-DT for pgadmin-hackers@postgresql.org; Mon, 12 Oct 2020 12:25:39 +0000 Received: by mail-ed1-x532.google.com with SMTP id t20so10401011edr.11 for ; Mon, 12 Oct 2020 05:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TbfY3PN3bfUk66Bx1Hng8scnNt+cjP3JzvJnUhPufDE=; b=mKNvNd91EwNXeOEL0n2xzzW2sVSvfK5gkUAT/flNG1r3N/gAI896q1TwOncObd6q3h 6kGAnQqCvjyA2bxVeHmLgz4Y1kluSyY8AtwJF+6ILVYzcrl6mtLmdKQ7dvqPiegJU55j rnAL7HfAMC+5pGKT0q3+vL8B7k59SMLQn9nTdKu5enDrsNFizMeXiWAyxF28Za1mELss 8XtGx/zkMpE2YLQthsb1u+K3anwKfeJMzmJoMypkzPzusWDs2zWw6Szo9FH2BJda9Ezl YzCTnaTGW5hk3Ybmmq0/NPdIT9MrKCOvoIqHWKy/PE82gGguJLvYKg8OEMppqD2Vnfnj fpAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TbfY3PN3bfUk66Bx1Hng8scnNt+cjP3JzvJnUhPufDE=; b=P7C/TR/IvVSdvAGwTNP3tWveecXLQqY4hhaGQrXT9hreKa9Lg6IHxco6PdWFR6QJ3D ME7e+C4HGd8FxQm39jYn9gF4xw/ZhQS8oO0fMNXlzZeSA9fHlY78C/zstMF3FvCxFNMj Ozm3fiLAR7NzeiV3VY+R0rewYkBBBaVktO+N/j6eKECGVAmB2vWwoqAe1NNketoZDrSl uWTY3kUEyqqh28b9Dxpj4WZG1yXNW5NGIZW5N8Ru3PyZGBwC/RG00OLY1UchBb9uFtpS +dhUWn4VkEWSBig4oIYWtZG77i/pzBlDOcxvnQT8IAGPse3WEvfjoBw26SFzf0jsgHbO P1eQ== X-Gm-Message-State: AOAM533IcvcMXwf2pJbQCYu9Z3Fg7QnsrzrwAu6Xar2JLtVZXyG0hoPO 2NEnqMnAoTEu+DgcGx+B9tZlIMAbphn2ZvTVIgoAoiwBEVXTk2g+XnqV8QlRhJguyHuyXPJ9Ng9 xc+kqcuHB/N3k//LvNtRStwFmyYANuV/zh9hhn9kAMk88tB66E4wEnAL+ld8VIQmM46VEjOwR1/ NNuOoKS3sqRi+qowyumKOxVecONbzIEo/S6TkoskW6h2fnXL89OKfbv3bgBFyPQgovoQ== X-Google-Smtp-Source: ABdhPJzIhuxc0lCP/r+siG05vtAESt3M0xXK73GmvYyIbPLxM4fY6t802b1FX5q6NaDbcgMz+CL7wmCcGHPMRBFfOIY= X-Received: by 2002:aa7:d1d5:: with SMTP id g21mr14237464edp.348.1602505530510; Mon, 12 Oct 2020 05:25:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Mon, 12 Oct 2020 17:54:53 +0530 Message-ID: Subject: Re: [pgAdmin][RM4855] Renaming a file removes the file extension To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000e5ec8c05b1786402" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e5ec8c05b1786402 Content-Type: multipart/alternative; boundary="000000000000e5ec8a05b1786400" --000000000000e5ec8a05b1786400 Content-Type: text/plain; charset="UTF-8" Hi Hackers, Attached is a patch to improve this further. It will skip adding the extension if the file already has the extension selected from the format dropdown. Please review. On Fri, Oct 9, 2020 at 11:53 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Oct 8, 2020 at 6:34 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi, >> >> Attached patch will add the .sql when saving a file and and format -> sql >> selected, no matter what the file name is. >> Please review. >> >> On Thu, Oct 8, 2020 at 6:27 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Mon, Sep 28, 2020 at 6:08 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the patch to fix a bug where extension file extension is >>>> stripped on renaming a file. >>>> Pleasure review. >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>> >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Sr. Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Sr. Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --000000000000e5ec8a05b1786400 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

Attached is a patch to improve this further. I= t will skip adding the extension if the file already has the extension sele= cted from the format dropdown.
Please review.

On Fri, Oct 9, 2020 at 1= 1:53 AM Akshay Joshi <a= kshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.
On Thu, = Oct 8, 2020 at 6:34 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

Attached patch will add the .sql wh= en saving a file and and format -> sql selected, no matter what the file= name is.
Please review.

On Thu, Oct 8, 2020 at 6:= 27 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch = applied.

On Mon, Sep 28, 2020 at 6:08 PM Aditya Toshniwal <aditya.toshniwal@e= nterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix a = bug where extension file extension is stripped on renaming a file.
Pleasure= =C2=A0review.

--
=
Thanks,<= div>Aditya Toshniwal
pgA= dmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
"Don't Co= mplain about Heat, Plant a TREE"
=


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Softwa= re Engineer | edbpostgres.com<= /font>
"Don't Complain about Heat, Plant a TREE&qu= ot;
--000000000000e5ec8a05b1786400-- --000000000000e5ec8c05b1786402 Content-Type: application/octet-stream; name="RM4855.part3.patch" Content-Disposition: attachment; filename="RM4855.part3.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kg6ie4u80 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL21pc2MvZmlsZV9tYW5hZ2VyL3N0YXRpYy9qcy9jcmVh dGVfZGlhbG9ndWUuanMgYi93ZWIvcGdhZG1pbi9taXNjL2ZpbGVfbWFuYWdlci9zdGF0aWMvanMv Y3JlYXRlX2RpYWxvZ3VlLmpzCmluZGV4IGM3ZTRiNmI2MC4uNjM0NzQyYTBkIDEwMDY0NAotLS0g YS93ZWIvcGdhZG1pbi9taXNjL2ZpbGVfbWFuYWdlci9zdGF0aWMvanMvY3JlYXRlX2RpYWxvZ3Vl LmpzCisrKyBiL3dlYi9wZ2FkbWluL21pc2MvZmlsZV9tYW5hZ2VyL3N0YXRpYy9qcy9jcmVhdGVf ZGlhbG9ndWUuanMKQEAgLTE1MSw3ICsxNTEsOSBAQCBtb2R1bGUuZXhwb3J0cyA9ICBBbGVydGlm eS5kaWFsb2coJ2NyZWF0ZU1vZGVEbGcnLCBmdW5jdGlvbigpIHsKICAgICAgICAgICAgdGhlcmUg aXMgYSAuIGFscmVhZHkgYnV0IGl0J3Mgbm90IGZvbGxvd2luZyB0aGUgbGFzdCAvLCBBTkQgdGhl CiAgICAgICAgICAgIGV4dGVuc2lvbiBpc24ndCAqLCB0aGVuIHdlIGFkZCB0aGUgZXh0ZW5zaW9u LgogICAgICAgICAgKi8KLSAgICAgICAgaWYgKGV4dCAhPSAnKicpIHsKKyAgICAgICAgaWYgKCgh bmV3RmlsZS5pbmNsdWRlcygnLicpIHx8CisgICAgICAgICAgICBuZXdGaWxlLnNwbGl0KCcuJyku cG9wKCkgIT0gZXh0KSAmJgorICAgICAgICAgICAgZXh0ICE9ICcqJykgewogICAgICAgICAgIG5l d0ZpbGUgPSBuZXdGaWxlICsgJy4nICsgZXh0OwogICAgICAgICAgICQoJy5zdG9yYWdlX2RpYWxv ZyAjdXBsb2FkZXIgLmlucHV0LXBhdGgnKS52YWwobmV3RmlsZSk7CiAgICAgICAgIH0K --000000000000e5ec8c05b1786402--