Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9nLU-0004Dg-QA for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 Feb 2021 11:07:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l9nLT-0004n7-Mb for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 Feb 2021 11:07:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9nLT-0004n0-9c for pgadmin-hackers@lists.postgresql.org; Wed, 10 Feb 2021 11:07:43 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l9nLP-0001lV-CY for pgadmin-hackers@postgresql.org; Wed, 10 Feb 2021 11:07:42 +0000 Received: by mail-lf1-x12e.google.com with SMTP id v30so1852703lfq.6 for ; Wed, 10 Feb 2021 03:07:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sa347UagnCaeJ5SPB60LwwlfhcKNQwvCqpjc9iCJD2g=; b=WaC746R1DUy1PHFx3AVCRsqYxYqdXXrgI1VkEBeZKYs2/eLn0S0HBl711nPcMyGEGQ 1OZmJ5uRS1oOA7zXkKX9vaowMkylRvhudWv17zqITe/TPvmJ0PYAMPFu3dUjLUZCvu+z L1e9Bki9I0t5XFansdRF5ZZGpcxcTsr3+rmZzvPHC3qX4vu1gSAntij0Qx56xt4VQ2nG vdcA+tjoBf2tNExVAk78P3deKFa2deZBuY+u9PqljcvsQIbsdTSVCIyo1IBju7TCUvZJ QIdr9Is7tr1Mm+41PZF2s4GoyV0b12WBo9akaSK9d/kzBwSeEc0X2/eDnqDwBMEfj/KN x3JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sa347UagnCaeJ5SPB60LwwlfhcKNQwvCqpjc9iCJD2g=; b=ANKfydJN8mSN6xy/IHDmVYFGFZdD7eCbXQvHUkRrv3LdUa0+xspbP8DetC4ooFVk1C 2OPJJ3oftE4i3L5w998lKFT1BHEjmbTjeVZtXU/0NCoVgEGqA/Yjn6GG6jMTejHOgXWH vLtFaXzJcWx+GYoDXgWLDCY9GwDfxmSvFf3mHYIwhnx/vuYz9MKR25k8zrUV23Y7SflK oWy83JaY5xwKxdqpXPmvC111d59FTehrN0iE/bSMSqkjfWC8b4OOGNHYyE3bVllLuWxN 2tcxvjSSic6dAmQtpQK2GQOOEFn/K8jtog+UwuGHNkX1w41ljFE2uSW8J4XO14kQAxzg koww== X-Gm-Message-State: AOAM531x1yf/+u5IovK66uZXWF8Y0fqq1sE14BkGWYJWals5F63vFDJ3 bhcJ6W0wJkupjJJwO6JYE2RGFtZjs2pJgC5ITvu2/9djRkKRACzuvpA7SrJzlnDWsDLUHF+klib LB9O8cojXy6u9FMXHAAHln0BCrjXlk6Px0Ki9yEEkeWkCW/B9by/SmiZ3Y+Da8fG9trIqyp/xrv uMXirNPsaAhed2nGq+JjVImZQAy2xG62Nr8w56euy/xXHTr8nEBLY6X1Q2+IGMrnBqiA== X-Google-Smtp-Source: ABdhPJyWgWv2jqdf4HHUGn+8vZFR1hl7dA7vVwZu3S5oNg8PGdQj5jPjmW2NY3ziP9dI+etDcqOl1N6jk6M/tGNdsIQ= X-Received: by 2002:a05:6512:519:: with SMTP id o25mr1426477lfb.529.1612955258258; Wed, 10 Feb 2021 03:07:38 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Wed, 10 Feb 2021 16:37:01 +0530 Message-ID: Subject: Re: [pgAdmin][RM6207] Update JS dependencies To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000003530df05baf9696f" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000003530df05baf9696f Content-Type: multipart/alternative; boundary="0000000000003530dd05baf9696d" --0000000000003530dd05baf9696d Content-Type: text/plain; charset="UTF-8" Hi, The preview images for the themes are not visible after this. Please find the attached patch to fix. On Wed, Feb 10, 2021 at 1:47 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Feb 10, 2021 at 1:37 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi, >> >> The imagemin-gifsicle package is used to compress gif images. The latest >> version of imagemin-gifsicle requires the binaries to be built from source, >> which has a big dependency of dh-autoreconf. >> pgAdmin has very few gifs. Instead of installing dh-autoreconf, I've >> removed imagemin-gifsicle from package.json since the cost of installing >> dh-autoreconf is more than the output of compressing gif. >> Attached is the patch. >> >> >> On Wed, Feb 10, 2021 at 12:51 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Wed, Feb 10, 2021 at 12:08 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> On Tue, Feb 9, 2021 at 4:35 PM Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Hi Aditya >>>>> >>>>> One jasmine test is failing, please fix that and resend the patch. >>>>> >>>> It was failing because of a side effect of some other test case. Fixed. >>>> >>>> Please review. >>>> >>>>> >>>>> On Mon, Feb 8, 2021 at 5:07 PM Aditya Toshniwal < >>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Attached is the patch to update the JS dependencies to latest. >>>>>> Changes include: >>>>>> 1) Migrate from webpack 4 to webpack 5. This had a lot of breaking >>>>>> changes, so updated multiple webpack plugins and changed the config >>>>>> accordingly. >>>>>> 2) Replaced iconfont-webpack-plugin with a more maintained >>>>>> webfonts-loader. >>>>>> 3) Replaced deprecated babel-eslint with @babel/eslint-parser >>>>>> 4) Replaced optimize-css-assets-webpack-plugin with a more >>>>>> maintained css-minimizer-webpack-plugin >>>>>> 5) Updated all other JS packages and made the required code changes. >>>>>> >>>>>> Note, there is an update available for slickgrid and I tried to >>>>>> update it. But it was not working as expected. So without wasting time, >>>>>> I've not updated slickgrid, and can be updated as a separate task. >>>>>> >>>>>> Please review. >>>>>> >>>>>> -- >>>>>> Thanks, >>>>>> Aditya Toshniwal >>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>> >>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> *pgAdmin Hacker | Principal Software Architect* >>>>> *EDB Postgres * >>>>> >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>> >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --0000000000003530dd05baf9696d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

The preview images for the themes are not visible afte= r this. Please find the attached patch to fix.

On Wed, Feb 10, 2021 at= 1:47 PM Akshay Joshi <= akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.
<= br>
On Wed,= Feb 10, 2021 at 1:37 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com= > wrote:
=
Hi,

The imagemin= -gifsicle package is used to compress gif images. The latest version of ima= gemin-gifsicle requires the binaries to be built from source, which has a b= ig dependency of dh-autoreconf.
pgAdmin has very few gifs. Instead of in= stalling dh-autoreconf, I've removed imagemin-gifsicle from package.jso= n since the cost of installing dh-autoreconf is more than the output of com= pressing gif.
Attached is the patch.


On Wed, Feb 10, = 2021 at 12:51 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
<= /div>
Tha= nks, patch applied.

On Wed, Feb 10, 2021 at 12:08 PM Aditya Toshniwal <aditya= .toshniwal@enterprisedb.com> wrote:
Hi,
=
On Tue= , Feb 9, 2021 at 4:35 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wro= te:
Hi=C2=A0Aditya

One jasmine test is failing, please = fix that and resend the patch.
It was failing beca= use of a side effect of some other test case. Fixed.

Please review.=C2=A0

On Mon, Feb 8, 2021 at 5:07 PM Aditya Toshniwal <aditya.toshniwal= @enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to update the J= S dependencies to latest. Changes include:
1) Migrate from webpack 4 to = webpack 5. This had a lot of breaking changes, so updated multiple webpack = plugins and changed the config accordingly.
2) Replaced iconfont-webpack= -plugin with a more maintained =C2=A0webfonts-loader.
3) =C2=A0Replac= ed deprecated babel-eslint with @babel/eslint-parser
4) =C2=A0Replaced o= ptimize-css-assets-webpack-plugin with a more maintained css-minimizer-webp= ack-plugin
5) Updated all other JS packages and made the required code c= hanges.

Note, there is an update available for slic= kgrid and I tried to update it. But it was not working as expected. So with= out wasting time, I've not updated slickgrid, and can be updated as a s= eparate task.

=
Please review.
<= /font>

--
Thanks,
Aditya Toshniwal
pgAdmin h= acker=C2=A0| Sr. Software Engineer | edbpostgres.com
"Don't Complain abou= t Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Softwa= re Engineer | edbpostgres.com<= /font>
"Don't Complain about Heat, Plant a TREE&qu= ot;
--0000000000003530dd05baf9696d-- --0000000000003530df05baf9696f Content-Type: application/octet-stream; name="RM6207.img.patch" Content-Disposition: attachment; filename="RM6207.img.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kkzbvyjg0 ZGlmZiAtLWdpdCBhL3dlYi93ZWJwYWNrLmNvbmZpZy5qcyBiL3dlYi93ZWJwYWNrLmNvbmZpZy5q cwppbmRleCAyZjZjYmM3MGMuLmU5YTlkOWUwZiAxMDA2NDQKLS0tIGEvd2ViL3dlYnBhY2suY29u ZmlnLmpzCisrKyBiL3dlYi93ZWJwYWNrLmNvbmZpZy5qcwpAQCAtNjksNyArNjksNyBAQCBjb25z dCBjb3B5RmlsZXMgPSBuZXcgQ29weVBsdWdpbih7CiAgICAgcGdhZG1pblRoZW1lc0pzb24sCiAg ICAgewogICAgICAgZnJvbTogJy4vcGdhZG1pbi9zdGF0aWMvc2Nzcy9yZXNvdXJjZXMvKiovKi5w bmcnLAotICAgICAgdG86IG91dHB1dFBhdGggKyAnL2ltZycsCisgICAgICB0bzogJ2ltZy9bbmFt ZV0uW2V4dF0nLAogICAgIH0sCiAgIF0sCiB9KTsK --0000000000003530df05baf9696f--