Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qDfAr-0000xu-E9 for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Jun 2023 05:54:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qDfAq-0006g7-4V for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Jun 2023 05:54:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qDfAp-0006fy-LM for pgadmin-hackers@lists.postgresql.org; Mon, 26 Jun 2023 05:54:03 +0000 Received: from mail-oo1-xc2c.google.com ([2607:f8b0:4864:20::c2c]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qDfAm-000URc-Av for pgadmin-hackers@postgresql.org; Mon, 26 Jun 2023 05:54:01 +0000 Received: by mail-oo1-xc2c.google.com with SMTP id 006d021491bc7-560c617c820so2209680eaf.3 for ; Sun, 25 Jun 2023 22:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1687758839; x=1690350839; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4GeBc7AKI9JVqMazWRah83h3oGrDbc5LdzEmjtqBUnQ=; b=YE7ftX2Wbwmh0aIsUW309xlDzOQpELTDo/YO/3HLK40KISI9mvBJIfweXtXdkg7Wpk mMP8f07FI9Va3zwo5BWizjm2y5CcrrEfOAR56AGGkq6yJp21BzRzLRGCqHXau2v4KPy4 6ALHMQtEnhvDR1NG6I6NH0V2b0A+SGdU6yWuN2Y82G9J+CP7XAUee1XIQgKXmB68ZPpU CXBCFNk6KGSEbszsuANnq79dJNl8MZFui16Ne4Ou+h86SemcDHJoJM1x0cVI7B7uCacZ FY1WRXAKGObd5GQ1j9oeOrxz6VoIFWs0cxEKjk/ZbOt/q1T0IpSKrxiEP7ctHFwfc3pb L6OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687758839; x=1690350839; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4GeBc7AKI9JVqMazWRah83h3oGrDbc5LdzEmjtqBUnQ=; b=aA/tzvxu7I1xXiPIZZDWXwG/WzDd8OcVDDkeJ93i3XWzXi3nHl7ObuLPI3ldOPv2M1 zgWzelkK3VaOdC5CJq3uzjtslO0h9LBJpWXXkVrr1ztB/z4LDsJ0N2t+Dq+RyAUwSdHo dx7XUL/m/GA/gdpxBvnkMSpWfCznx1DUNqHj4JshqgkHZPJHeftharRrekun8HcBGvsQ d1G0vB/ncFpmXaisgf5M+spUi8f9a4AbjIen5AMCdFMqWBAQadQPP238eJdwcvft9D4M Ip3OQRg6ykcKbC4MXtL9Ea71t69/ux/21CH5uqPRyddgqIHQFQCBBBLt0fYvfiuyGaoT Kbzg== X-Gm-Message-State: AC+VfDw16M8hjMnFhENvFQTGWpP/+jAf1xpwmOzdyxbi3gWf8bd8EMkc ccm6DiDhuhPNAGAGq8VDsJ79n5+C9KFuj2SrOIA9ww== X-Google-Smtp-Source: ACHHUZ7ubuwr9t7msVHdurBXQcktvyxLWTQ/NV0zYal0q8w8dlOKKPz/GmDIpbOj3zo+hfj4Hyua3MRGtpuzlUUx5s0= X-Received: by 2002:a4a:d6cc:0:b0:563:52c2:17db with SMTP id j12-20020a4ad6cc000000b0056352c217dbmr798647oot.8.1687758839622; Sun, 25 Jun 2023 22:53:59 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Mon, 26 Jun 2023 11:23:23 +0530 Message-ID: Subject: Re: Adding storage parameters on index To: Akshay Joshi Cc: Pravesh Sharma , pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="0000000000001a457805ff01fa3c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000001a457805ff01fa3c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, I would also suggest moving Columns and Include Columns to a separate tab - Columns. On Mon, Jun 26, 2023 at 11:19=E2=80=AFAM Akshay Joshi wrote: > Hi Pravesh > > On Fri, Jun 23, 2023 at 2:28=E2=80=AFPM Pravesh Sharma < > pravesh.sharma@enterprisedb.com> wrote: > >> Hi All, >> >> I am working on feature #6374 >> which is >> adding storage parameters while creating an index. I have made changes i= n >> the definition tab of create index to have all the required parameters. >> Attached is the new design, please review it. >> >> I also have a few points which require suggestions. >> >> 1. Storage parameters are different for different access methods. If >> an access method does not support a parameter we can either disable i= t or >> hide it (I am thinking of hiding it based on the access method). >> >> Disable the controls. > >> >> 1. There is a storage parameter named *buffering *which is by >> default auto and takes on/off value. What type of control should I us= e for >> it? Should it be a switch or a drop down with three options on, off a= nd >> auto, if we have a switch user won't be able to move to auto. >> >> It should be a drop-down with all three options. > >> >> 1. There is a parameter *vacuum_cleanup_index_scale_factor *that was >> added on PostgreSQL 11 but was removed on PostgreSQL 13, should we ad= d this >> too? >> >> No need to add the above parameter. > >> >> >> Thanks >> Pravesh Sharma >> >> -- >> >> >> >> Pravesh Sharma >> >> Software Engineer >> >> +91 9406461406 >> >> www.enterprisedb.com >> >> Power to Postgres >> >> >> >> >> >> > --=20 Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* "Don't Complain about Heat, Plant a TREE" --0000000000001a457805ff01fa3c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

I would also suggest moving Columns and Include Column= s to a separate tab - Columns.

On Mon, Jun 26, 2023 at 11:19=E2=80=AFA= M Akshay Joshi <akshay.= joshi@enterprisedb.com> wrote:
Hi Pravesh
On Fri, J= un 23, 2023 at 2:28=E2=80=AFPM Pravesh Sharma <pravesh.sharma@enterprisedb.com= > wrote:
=
Hi All,

I am working on feature= =C2=A0#6374=C2=A0which is adding=C2=A0storage parameters = while creating an index. I have made changes in the definition=C2=A0tab of = create index to have all the required parameters. Attached is the new desig= n, please review it.

I also have a few points whic= h=C2=A0require suggestions.
  1. St= orage parameters=C2=A0are different for different=C2=A0access methods. If a= n access method=C2=A0does not support=C2=A0a parameter we can either disabl= e it or hide it (I am thinking of hiding it based on the access method).
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0Disable the controls.
  1. There is a storage parameter named=C2=A0buffering=C2=A0which is by default=C2=A0auto and takes on/off value. Wha= t type of control should=C2=A0I use for it? Should it be a switch=C2=A0or a= drop down with three options on, off and auto, if we have a switch user wo= n't be able to move to auto.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 It should be a dro= p-down with all three options.
  1. There i= s a parameter=C2=A0vacuum_cleanup_index_scale_factor=C2=A0th= at was added on PostgreSQL 11 but was removed on PostgreSQL 13, should=C2= =A0we add this too?
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 No need to add the above p= arameter.


Thanks
Pravesh Sha= rma

--
=

<= /p>

Pravesh Sharma

Software Engineer

+91 9406461406

www.enterprisedb.com

Power to Postgres

<= /span>

=C2=A0 =C2=A0 =C2=A0 <= /span> =C2=A0 =C2=A0 =C2=A0 =C2=A0 <= /span>



--
Thanks,
Aditya Toshniwal
pgAdmin Hacker=C2=A0| Sr. Software Architect=C2=A0| enterprisedb.com