Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKGrD-0000x5-Jq for pgadmin-hackers@arkaria.postgresql.org; Mon, 21 Sep 2020 08:07:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kKGrB-0006wB-2X for pgadmin-hackers@arkaria.postgresql.org; Mon, 21 Sep 2020 08:07:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKGrA-0006w4-OB for pgadmin-hackers@lists.postgresql.org; Mon, 21 Sep 2020 08:07:28 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kKGr7-0002Gz-1q for pgadmin-hackers@postgresql.org; Mon, 21 Sep 2020 08:07:28 +0000 Received: by mail-ej1-x633.google.com with SMTP id lo4so16373204ejb.8 for ; Mon, 21 Sep 2020 01:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=Et9ID+UOrL4uWsz4UrhGjFAlYIOGw6bStff9fcHUq84=; b=DzzjX6xapWlOL1d3gQvD/ow/UGFhyBgoeLwMLROjdN9QW9/suZ5vlYWZjW/BLifFWE s2sYEpkuHrTAwnBfJdf/p+8voAE3T51vyVNzvPbV7VdNzeB1J7TfYcsNYlFdFqEBwo1H T42A/d3nOYtuV5QsuYICiugzM/AGdZw4wkApYoZNjUJVnBArc8PKB8YfPysff7Mt7Ix3 AxIHzaQ8u+Ady1YRYv3EzQay9WHM0sYVVXq9xYxGydzDqncmAglsx0iE0mVw39E+zDpV maD/E5/8dQJdNcxPkKoVgh75Rp/6EFc7LRtHDAtXAKBZA7hcfekuuE0KNvx3s3To+Lax zpSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Et9ID+UOrL4uWsz4UrhGjFAlYIOGw6bStff9fcHUq84=; b=iCD9MYIQA6RclAVBs+7xHIW9JyZgzSph6AE1lB/dZnQh1qglbRLiyhgtMF6OYMm+9I GlZLINmnYX1gh1e8BYXqNz8LbiOl1gW/PLufk6R5U9nvSwdDCYORXUDuldLCYmz2dYyg tclkhSFqVQCdCPhkO6AqcQGELZ8KEcR5RfXdZwf3e0ihARCKUc8tOuz47UZB0FbaYP09 WhE5gBpcFgeyFavCU0Enkmo3/Ge/eWniPtTOtpoBSmmqQ+fXWJAbvgh/a95TduALdNRs p/rc58x3a42COT7LIY0tBJ1/m3aplCzPhcm74CppxmkgDQnQir5c8QD/41s1vp8MWMZF bw5g== X-Gm-Message-State: AOAM533UqahRsgwUpOPROQYxdluSmOJMgDjfTbp/N0ZiTs+35Yj9Eam2 B7zQhO7+CBdHkPbj5ulGXErQGd9pCywscOPJ/bddgNmKmTl0x3NWw4M2wPrpUumss2RVhln1cYc lOxRA0rRyLW5C32I2Wg9Xn67tqUZeUmp2AgKLhmjXO8q7/IaFwmH53Wytu7Q6DKc82xXEHw+WaR gENDrg1zNIDo4qJnW7b/lrPfevmCVpWd4+M6xDK/Gx5QvbehPhffSlNuNtBr1eI73M1y1y X-Google-Smtp-Source: ABdhPJw7v0dPUrb1BNYXdtHxVnr0M+Efr+yJwI6/RsKmPqa8uyJVT98ZlMbEOnnFrevkFXJ7hdriM0tdZC1avJo2dHg= X-Received: by 2002:a17:906:4093:: with SMTP id u19mr49190266ejj.520.1600675643608; Mon, 21 Sep 2020 01:07:23 -0700 (PDT) MIME-Version: 1.0 From: Aditya Toshniwal Date: Mon, 21 Sep 2020 13:36:47 +0530 Message-ID: Subject: [pgAdmin][RM5845] Free query windows hard capped to 1000 results sometimes To: pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000024321a05afce570e" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000024321a05afce570e Content-Type: multipart/alternative; boundary="00000000000024321905afce570c" --00000000000024321905afce570c Content-Type: text/plain; charset="UTF-8" Hi Hackers, Attached is the patch to fix the issue where the query tool is not fetching more than 1000 rows. The issue occurs only when a table does not have any primary key. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --00000000000024321905afce570c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

Attached is the patch to fix the issue where t= he query tool is not fetching more than 1000 rows. The issue occurs only wh= en a table does not have any primary key.

Please review.
--
Thanks,
<= span style=3D"color:rgb(18,22,70)">Aditya = Toshniwal
pgAdmin hacker=C2=A0| Sr. Software Engine= er | edbpostgres.com
--00000000000024321905afce570c-- --00000000000024321a05afce570e Content-Type: application/octet-stream; name="RM5845.patch" Content-Disposition: attachment; filename="RM5845.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kfc8x9710 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci91dGlscy9pc19xdWVyeV9y ZXN1bHRzZXRfdXBkYXRhYmxlLnB5IGIvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3V0aWxz L2lzX3F1ZXJ5X3Jlc3VsdHNldF91cGRhdGFibGUucHkKaW5kZXggMDEzYzA1ZGE4Li45OWM4ZmU1 M2QgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci91dGlscy9pc19xdWVy eV9yZXN1bHRzZXRfdXBkYXRhYmxlLnB5CisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRv ci91dGlscy9pc19xdWVyeV9yZXN1bHRzZXRfdXBkYXRhYmxlLnB5CkBAIC03NSwxNyArNzUsMTYg QEAgZGVmIGlzX3F1ZXJ5X3Jlc3VsdHNldF91cGRhdGFibGUoY29ubiwgc3FsX3BhdGgpOgogICAg ICAgICBpc19yZXN1bHRzZXRfdXBkYXRhYmxlID0gaGFzX29pZHMgb3IgKHByaW1hcnlfa2V5cyBp cyBub3QgTm9uZSBhbmQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBsZW4ocHJpbWFyeV9rZXlzKSAhPSAwKQogCi0gICAgICAgIGlmIGlzX3Jlc3VsdHNldF91 cGRhdGFibGU6Ci0gICAgICAgICAgICBjb2x1bW5fdHlwZXMgPSBnZXRfY29sdW1uc190eXBlcyhj b2x1bW5zX2luZm89Y29sdW1uc19pbmZvLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgdGFibGVfb2lkPXRhYmxlX29pZCwKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbm49Y29ubiwKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGhhc19vaWRzPWhhc19vaWRzLAotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaXNfcXVlcnlfdG9vbD1UcnVlKQotICAg ICAgICAgICAgcmV0dXJuIFRydWUsIGhhc19vaWRzLCBwcmltYXJ5X2tleXMsIFwKLSAgICAgICAg ICAgICAgICBwa19uYW1lcywgdGFibGVfb2lkLCBjb2x1bW5fdHlwZXMKLSAgICAgICAgZWxzZToK KyAgICAgICAgaWYgbm90IGlzX3Jlc3VsdHNldF91cGRhdGFibGU6CiAgICAgICAgICAgICBfc2V0 X2FsbF9jb2x1bW5zX25vdF9lZGl0YWJsZShjb2x1bW5zX2luZm89Y29sdW1uc19pbmZvKQotICAg ICAgICAgICAgcmV0dXJuIHJldHVybl9ub3RfdXBkYXRhYmxlKCkKKworICAgICAgICBjb2x1bW5f dHlwZXMgPSBnZXRfY29sdW1uc190eXBlcyhjb2x1bW5zX2luZm89Y29sdW1uc19pbmZvLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0YWJsZV9vaWQ9dGFibGVfb2lk LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25uPWNvbm4sCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhhc19vaWRzPWhhc19vaWRz LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpc19xdWVyeV90b29s PVRydWUpCisgICAgICAgIHJldHVybiBpc19yZXN1bHRzZXRfdXBkYXRhYmxlLCBoYXNfb2lkcywg cHJpbWFyeV9rZXlzLCBcCisgICAgICAgICAgICBwa19uYW1lcywgdGFibGVfb2lkLCBjb2x1bW5f dHlwZXMKICAgICBlbHNlOgogICAgICAgICByYWlzZSBJbnRlcm5hbFNlcnZlckVycm9yKFNFUlZF Ul9DT05ORUNUSU9OX0NMT1NFRCkKIAo= --00000000000024321a05afce570e--