public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree
Date: Wed, 26 Jun 2019 17:08:12 +0530
Message-ID: <CAM9w-_kPPak3LyuYnYiCauUAwRrddSVZQmpP4s7MCydz2Z9RSA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoyABTHRkBS++mFDc6cD6SswOZ-p8r=gpctLHXkxnyF5Pg@mail.gmail.com>
References: <CAM9w-_mxRdG6peLx3VdF1z-+yY11qQEPNTQ0ekT5TNaEWT05QQ@mail.gmail.com>
<CA+OCxowrfff5pU-sKTpk8G4oDpxpYRSmJ-mZbrhWWTYPB7fubQ@mail.gmail.com>
<CAM9w-_nD6z_DtLWyKbU9nh34_jQVbj9UcHesznRiqeAoQ0LCKw@mail.gmail.com>
<CA+OCxoyABTHRkBS++mFDc6cD6SswOZ-p8r=gpctLHXkxnyF5Pg@mail.gmail.com>
Hi,
On Wed, Jun 26, 2019 at 5:06 PM Dave Page <[email protected]> wrote:
>
>
> On Wed, Jun 26, 2019 at 7:28 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi,
>>
>> On Wed, Jun 26, 2019 at 4:51 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is the patch to allow tree nodes to be dragged and dropped in
>>>> query editor wherever you take the drop cursor. The drop text will be fully
>>>> qualified and double quoted if required.
>>>> For functions/procedures it will drop the the label stripping away the
>>>> parameter names, with empty pair of round brackets. It will also set the
>>>> focus cursor inside the brackets if there were params otherwiser to the end
>>>> of text.
>>>> For adding a node type, you need to register it in browser.js along
>>>> with a callback function which will return drop text along with cursor
>>>> positioning and selection. Currently, I have registered for "table
>>>> partition type sequence package view mview foreign_table edbvar schema
>>>> column edbfunc function edbproc procedure".
>>>>
>>>> Please note, the drag design customisation is not supported in IE.
>>>>
>>>
>>> I think for functions/procedures, we should include placeholders for the
>>> parameters, so the user has a hint about what they need to fill in to
>>> complete the call.
>>>
>> I can fill in the parameter names same as tree node, with cursor
>> selection on all the params ?
>>
>
> Can you select the first one, and put the cursor in front of it?
>
Yes. Will do that. So that, just after drop if the user types anything it
will replace the first param name.
>
>
>>
>>> Also; shouldn't there be a doc update?
>>>
>> Yeah :/
>> Should there be any screenshots ?
>>
>
> I don't see much need.
>
Cool.
>
> Thanks.
>
>
>>
>>> Thanks.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree
In-Reply-To: <CAM9w-_kPPak3LyuYnYiCauUAwRrddSVZQmpP4s7MCydz2Z9RSA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox