MIME-Version: 1.0
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Fri, 1 Nov 2019 15:23:29 +0530
Message-ID: 
 <CAM9w-_kU7FWKee=BB7wZYnN5cNt0AQ=bZX-0jS3BdMs8rpUPjw@mail.gmail.com>
Subject: [pgAdmin][RM4451]Cannot construct SQL script for composite type
 having only one field variable
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000056350f059645f260"
Precedence: bulk

--00000000000056350f059645f260
Content-Type: multipart/alternative; boundary="00000000000056350b059645f25e"

--00000000000056350b059645f25e
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

pgAdmin allows to create composite type only with 2 or more members.
Attached is the patch to remove the restriction as PostgreSQL allows zero
or more and fix the issue where SQL is not generated for types having less
than 2 members.

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

--00000000000056350b059645f25e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif">Hi Hackers,</div><div class=3D"gmail_default" style=3D"font-fam=
ily:verdana,sans-serif"><br></div><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif">pgAdmin allows to create composite type only w=
ith 2 or more members.</div><div class=3D"gmail_default" style=3D"font-fami=
ly:verdana,sans-serif">Attached is the patch to remove the restriction as P=
ostgreSQL allows zero or more and fix the issue where SQL is not generated =
for types having less than 2 members.</div><div class=3D"gmail_default" sty=
le=3D"font-family:verdana,sans-serif"><br></div><div class=3D"gmail_default=
" style=3D"font-family:verdana,sans-serif">Kindly review.</div><div><br></d=
iv>-- <br><div dir=3D"ltr" class=3D"gmail_signature" data-smartmail=3D"gmai=
l_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><=
div><div dir=3D"ltr"><font size=3D"2" color=3D"#000000" face=3D"verdana, sa=
ns-serif">Thanks and Regards,</font><div><span style=3D"background-color:rg=
b(255,255,255)"><font size=3D"2" color=3D"#000000" face=3D"verdana, sans-se=
rif">Aditya Toshniwal</font></span></div><div><font face=3D"verdana, sans-s=
erif"><span style=3D"background-color:rgb(255,255,255)"><font size=3D"2" co=
lor=3D"#000000">Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0</fo=
nt></span><span style=3D"color:rgb(0,0,0)">Pune</span></font></div><div><fo=
nt color=3D"#38761d" face=3D"verdana, sans-serif" size=3D"1">&quot;Don&#39;=
t Complain about Heat, Plant a TREE&quot;</font></div></div></div></div></d=
iv></div></div></div></div></div>

--00000000000056350b059645f25e--

--00000000000056350f059645f260
Content-Type: application/octet-stream; name="RM4451.patch"
Content-Disposition: attachment; filename="RM4451.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_k2fympt70>
X-Attachment-Id: f_k2fympt70

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2Rh
dGFiYXNlcy9zY2hlbWFzL3R5cGVzL19faW5pdF9fLnB5IGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9z
ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdHlwZXMvX19pbml0X18ucHkK
aW5kZXggOGQ0MjhkYzFmLi5iNTBlNmQ3ZDcgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2Jyb3dz
ZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3R5cGVzL19faW5pdF9f
LnB5CisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFi
YXNlcy9zY2hlbWFzL3R5cGVzL19faW5pdF9fLnB5CkBAIC05MjksMTYgKzkyOSw2IEBAIGNsYXNz
IFR5cGVWaWV3KFBHQ2hpbGROb2RlVmlldywgRGF0YVR5cGVSZWFkZXIpOgogICAgICAgICAgICAg
ICAgICAgICApCiAgICAgICAgICAgICAgICAgKQogICAgICAgICAgICAgIyBBZGRpdGlvbmFsIGNo
ZWNrcyBnb2VzIGhlcmUKLSAgICAgICAgICAgICMgSWYgdHlwZSBpcyBjb21wb3NpdGUgdGhlbiBj
aGVjayBpZiBpdCBoYXMgdHdvIG1lbWJlcnMKLSAgICAgICAgICAgIGlmIGRhdGEgYW5kIGRhdGFb
YXJnXSA9PSAnYyc6Ci0gICAgICAgICAgICAgICAgaWYgbGVuKGRhdGFbJ2NvbXBvc2l0ZSddKSA8
IDI6Ci0gICAgICAgICAgICAgICAgICAgIHJldHVybiBtYWtlX2pzb25fcmVzcG9uc2UoCi0gICAg
ICAgICAgICAgICAgICAgICAgICBzdGF0dXM9NDEwLAotICAgICAgICAgICAgICAgICAgICAgICAg
c3VjY2Vzcz0wLAotICAgICAgICAgICAgICAgICAgICAgICAgZXJyb3Jtc2c9Z2V0dGV4dCgKLSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAnQ29tcG9zaXRlIHR5cGVzIHJlcXVpcmUgYXQgbGVh
c3QgdHdvIG1lbWJlcnMuJwotICAgICAgICAgICAgICAgICAgICAgICAgKQotICAgICAgICAgICAg
ICAgICAgICApCiAgICAgICAgICAgICAjIElmIHR5cGUgaXMgcmFuZ2UgdGhlbiBjaGVjayBpZiBz
dWJ0eXBlIGlzIGRlZmluZWQgb3Igbm90CiAgICAgICAgICAgICBpZiBkYXRhIGFuZCBkYXRhW2Fy
Z10gPT0gJ3InOgogICAgICAgICAgICAgICAgIGlmICd0eXBuYW1lJyBub3QgaW4gZGF0YSBvciBk
YXRhWyd0eXBuYW1lJ10gaXMgTm9uZToKQEAgLTEyODUsMTEgKzEyNzUsNiBAQCBjbGFzcyBUeXBl
VmlldyhQR0NoaWxkTm9kZVZpZXcsIERhdGFUeXBlUmVhZGVyKToKICAgICAgICAgICAgICAgICAg
ICAgcmV0dXJuICItLSBkZWZpbml0aW9uIGluY29tcGxldGUiCiAKICAgICAgICAgICAgICMgQWRk
aXRpb25hbCBjaGVja3MgZ28gaGVyZQotICAgICAgICAgICAgIyBJZiB0eXBlIGlzIGNvbXBvc2l0
ZSB0aGVuIGNoZWNrIGlmIGl0IGhhcyB0d28gbWVtYmVycwotICAgICAgICAgICAgaWYgZGF0YSBh
bmQgZGF0YVthcmddID09ICdjJzoKLSAgICAgICAgICAgICAgICBpZiBsZW4oZGF0YVsnY29tcG9z
aXRlJ10pIDwgMjoKLSAgICAgICAgICAgICAgICAgICAgcmV0dXJuICItLSBkZWZpbml0aW9uIGlu
Y29tcGxldGUiCi0KICAgICAgICAgICAgICMgSWYgdHlwZSBpcyByYW5nZSB0aGVuIGNoZWNrIGlm
IHN1YnR5cGUgaXMgZGVmaW5lZCBvciBub3QKICAgICAgICAgICAgIGlmIGRhdGEgYW5kIGRhdGFb
YXJnXSA9PSAncic6CiAgICAgICAgICAgICAgICAgaWYgJ3R5cG5hbWUnIG5vdCBpbiBkYXRhIG9y
IGRhdGFbJ3R5cG5hbWUnXSBpcyBOb25lOgpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vYnJvd3Nl
ci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdHlwZXMvdGVzdHMvZGVm
YXVsdC9jcmVhdGVfY29tcG9zaXRlX3R5cGVfb25lX2ZpZWxkLnNxbCBiL3dlYi9wZ2FkbWluL2Jy
b3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3R5cGVzL3Rlc3Rz
L2RlZmF1bHQvY3JlYXRlX2NvbXBvc2l0ZV90eXBlX29uZV9maWVsZC5zcWwKbmV3IGZpbGUgbW9k
ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwLi4xNmQ1NzU4YmIKLS0tIC9kZXYvbnVsbAorKysgYi93
ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1h
cy90eXBlcy90ZXN0cy9kZWZhdWx0L2NyZWF0ZV9jb21wb3NpdGVfdHlwZV9vbmVfZmllbGQuc3Fs
CkBAIC0wLDAgKzEsMTEgQEAKKy0tIFR5cGU6IGNvbXBvc2l0ZV90eXBlXyQle31bXSgpJipeIUAi
J2BcLyMKKworLS0gRFJPUCBUWVBFIHB1YmxpYy4iY29tcG9zaXRlX3R5cGVfJCV7fVtdKCkmKl4h
QCIiJ2BcLyMiOworCitDUkVBVEUgVFlQRSBwdWJsaWMuImNvbXBvc2l0ZV90eXBlXyQle31bXSgp
JipeIUAiIidgXC8jIiBBUworKAorCW1uYW1lMSBiaWdpbnQKKyk7CisKK0FMVEVSIFRZUEUgcHVi
bGljLiJjb21wb3NpdGVfdHlwZV8kJXt9W10oKSYqXiFAIiInYFwvIyIKKyAgICBPV05FUiBUTyA8
T1dORVI+OwpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3Nl
cnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdHlwZXMvdGVzdHMvZGVmYXVsdC90ZXN0cy5qc29uIGIv
d2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVt
YXMvdHlwZXMvdGVzdHMvZGVmYXVsdC90ZXN0cy5qc29uCmluZGV4IGNhZGVkNzY5Ny4uNjBhMTdi
NWE3IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVy
cy9kYXRhYmFzZXMvc2NoZW1hcy90eXBlcy90ZXN0cy9kZWZhdWx0L3Rlc3RzLmpzb24KKysrIGIv
d2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVt
YXMvdHlwZXMvdGVzdHMvZGVmYXVsdC90ZXN0cy5qc29uCkBAIC0xMDgsNiArMTA4LDMyIEBACiAg
ICAgICAiZGF0YSI6IHt9CiAgICAgfSwKIAorICAgIHsKKyAgICAgICJ0eXBlIjogImNyZWF0ZSIs
CisgICAgICAibmFtZSI6ICJDcmVhdGUgQ29tcG9zaXRlIHR5cGUgLSBvbmUgZmllbGQiLAorICAg
ICAgImVuZHBvaW50IjogIk5PREUtdHlwZS5vYmoiLAorICAgICAgInNxbF9lbmRwb2ludCI6ICJO
T0RFLXR5cGUuc3FsX2lkIiwKKyAgICAgICJkYXRhIjogeworICAgICAgICAibmFtZSI6ICJjb21w
b3NpdGVfdHlwZV8kJXt9W10oKSYqXiFAXCInYFxcLyMiLAorICAgICAgICAiaXNfc3lzX3R5cGUi
OmZhbHNlLAorICAgICAgICAidHlwdHlwZSI6ImMiLAorICAgICAgICAic2NoZW1hIjoicHVibGlj
IiwKKyAgICAgICAgImNvbXBvc2l0ZSI6WworICAgICAgICAgICAgeyJtZW1iZXJfbmFtZSI6Im1u
YW1lMSIsInR5cGUiOiJiaWdpbnQiLCJpc190bGVuZ3RoIjpmYWxzZSwiaXNfcHJlY2lzaW9uIjpm
YWxzZX0KKyAgICAgICAgXSwKKyAgICAgICAgInR5cGFjbCI6W10sCisgICAgICAgICJzZWNsYWJl
bHMiOltdLAorICAgICAgICAiZGVzY3JpcHRpb24iOiIiCisgICAgICB9LAorICAgICAgImV4cGVj
dGVkX3NxbF9maWxlIjogImNyZWF0ZV9jb21wb3NpdGVfdHlwZV9vbmVfZmllbGQuc3FsIgorICAg
IH0sCisgICAgeworICAgICAgInR5cGUiOiAiZGVsZXRlIiwKKyAgICAgICJuYW1lIjogIkRyb3Ag
Q29tcG9zaXRlIHR5cGUgLSBvbmUgZmllbGQiLAorICAgICAgImVuZHBvaW50IjogIk5PREUtdHlw
ZS5vYmpfaWQiLAorICAgICAgInNxbF9lbmRwb2ludCI6ICJOT0RFLXR5cGUuc3FsX2lkIiwKKyAg
ICAgICJkYXRhIjoge30KKyAgICB9LAogCiAgICAgewogICAgICAgInR5cGUiOiAiY3JlYXRlIiwK
--00000000000056350f059645f260--