Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rKeQR-003ozc-EG for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jan 2024 13:03:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rKeQP-00FWsx-TH for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jan 2024 13:03:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rKeQP-00FWsp-KG for pgadmin-hackers@lists.postgresql.org; Tue, 02 Jan 2024 13:03:17 +0000 Received: from mail-oo1-xc31.google.com ([2607:f8b0:4864:20::c31]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rKeQM-00F9YL-5g for pgadmin-hackers@postgresql.org; Tue, 02 Jan 2024 13:03:16 +0000 Received: by mail-oo1-xc31.google.com with SMTP id 006d021491bc7-595617d039eso898697eaf.3 for ; Tue, 02 Jan 2024 05:03:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1704200591; x=1704805391; darn=postgresql.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=0vtTrK50VX34xvHgcFqaRJvVBt78fCaRtjFasFCpeUQ=; b=dTacvydCQoPtMxfQlSnmTx/TW8iLAuUlSPoaqcrstB6prFeRfjYeOiw25AudlvKP/6 VJ+eS7Z6ACBIUKNE4O/W6FKh3G+FeBAzYtmvNq7WvqlrD34SGBPjZcqi5lMw7UNWtyBb aWedhwYaq08ztVuc/BVwdeTa7oMjo/PYYMND4dKeH1L7Dvq11HT3JQwmg8O4TTxELMBO dYXkK1i6ZVhcPqE3BInrpgoeeZP0gfORA33a0dkmRT1xvqGkUyCiHRyR6OfNFrXKHXWl HLCtT7kyYKOe9E7tHpkLdrycPIblQkF5wB0xvkX8nzRgTAyJQcfmKpYf+NsLKz/wABeg a4PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704200591; x=1704805391; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0vtTrK50VX34xvHgcFqaRJvVBt78fCaRtjFasFCpeUQ=; b=kS1SDyG1ANDcBWV9mtt2vC7dhjrgW6OHrrf34MBOD1/5/FKFMk52hCqJDGmBKZ01WY 91WLH6oOOGsV6v68Bf+8Th4ALeiBOB02iEc4VnNnwR+ETm3lu1P+U4ynIT0W/5sf5DSB Jx7pTNniNRjYWifNLlyuRTURDZ4SyVwfFwhNojwCtl8uM6R3fjd01VeQ/o/YD3xY8yH9 92uiXlTiJvOqgooMTajQZl+iEs3UKM4QS8WfjImomU3XZiFu8synlYKjO4mmqit7VEMa 64Ola/QiKOujnoAPEtHZiEEBuSb1uLWBv+SraD0IlJGq9PxCWzhinKkzMSATBfAhoo/8 xN4w== X-Gm-Message-State: AOJu0YyfBj7sfUjqTPbxd+RsQhBQrwPS4j0zwMI3VW+EjCjt9+gEynrt oiga9lcXaoyG7we3XPWnoJrgASFNVbQWxm7jkwmK7nJdhCBuMMow0zrSWe0= X-Google-Smtp-Source: AGHT+IGOtgdU8fYSUSdUK0fCK8FTjXZYNvrbdzsQCWWuj+35YruAH6VGDoTUWlGsLWs3jWVcv/U0eszS8aDSOQtc7H8= X-Received: by 2002:a05:6820:2409:b0:590:9dc5:cc69 with SMTP id cp9-20020a056820240900b005909dc5cc69mr8107378oob.12.1704200590973; Tue, 02 Jan 2024 05:03:10 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Tue, 2 Jan 2024 18:32:34 +0530 Message-ID: Subject: Re: Regarding codemirror upgrade and query tool autocomplete To: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000da1bc1060df61e9c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000da1bc1060df61e9c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Just to add to my previous email, double quoted table autocomplete works now with the latest minor version. More reasons to use the new approach. On Tue, Jan 2, 2024 at 4:44=E2=80=AFPM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > I am working on upgrading the CodeMirror package (used by SQL input/Query > editor) to the latest version. One major improvement is on the autocomple= te > part. CodeMirror provides a very versatile way of using autocomplete now. > One needs to pass the schema, table and columns data and it will show up = in > intellisense on typing. > Right now, we send the query to the backend and the backend sends the > suggestions which are shown on the screen. This can be very slow for remo= te > PostgreSQL servers as it queries everytime to the server for data and > requires an active connection. Also, not a good user experience. > I was playing around with the new autocomplete and I have attached the > screen-recording for the same. The data from the backend is loaded once t= he > query tool opens. > It has a few issues though. Column suggestions don't work correctly for > double quoted tables aliases. It doesn't suggest "joins" which we do righ= t > now. > I still need to figure out how we can refresh the data when new > tables/columns are added/removed. Overall, I find it more useful to the > users as it is quick and does the job what someone expects from an > autocomplete/intellisense. > > Thoughts/Suggestions on whether we should use it or continue with existin= g? > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* > > "Don't Complain about Heat, Plant a TREE" > --=20 Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* "Don't Complain about Heat, Plant a TREE" --000000000000da1bc1060df61e9c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,
Just to add to my previous email, double quoted table autoc= omplete works now with the latest minor version. More reasons to use the ne= w approach.

On Tue, Jan 2, 2024 at 4:44=E2=80=AFPM Aditya Toshniwal &l= t;aditya.toshniwal@ent= erprisedb.com> wrote:
Hi Hackers,

I am working on upgrading the Cod= eMirror package (used by SQL input/Query editor) to the latest version. One= major improvement is on the autocomplete part. CodeMirror provides a very = versatile way of using autocomplete now. One needs to pass the schema, tabl= e and columns data and it will show up in intellisense on typing.
Right now= , we send the query to the backend and the backend sends the suggestions wh= ich are shown on the screen. This can be very slow for remote PostgreSQL se= rvers as it queries everytime to the server for data and requires an active= connection. Also, not a good user experience.
I was playing=C2=A0around wi= th the=C2=A0new autocomplete and I have attached the screen-recording for t= he same. The data from the backend is loaded once the query tool opens.
It = has a few issues though. Column suggestions don't=C2=A0work correctly f= or double quoted tables aliases. It doesn't suggest "joins" w= hich we do right now.
I still need to figure out how we can refresh the dat= a when new tables/columns are added/removed. Overall, I find it more useful= to the users as it is quick and does the job what someone expects from an = autocomplete/intellisense.

Thoughts/Suggestions on whether we should= =C2=A0use it or continue with existing?

--
<= div dir=3D"ltr">
Thanks,
Aditya Toshniwal<= /font>
pgAdmin Hacker=C2=A0| Sr. Software Architect=C2=A0= | enterprisedb.com
"Don't Complain about Heat, Plant a TREE"=


--
Thanks,
Aditya Toshniwal
pgAdmin Hacker=C2=A0| Sr. Software Architect=C2=A0| enterprisedb.com